Re: EE10 - Jakarta Security OIDC

2024-06-12 Thread Markus Jung
Hi David, I can absolutely understand that this is a bit much to ask for to review. I think this is what really needs a closer look and maybe needs to be discussed: - JWT Validation is using jose.4.j, this introduces a new dependency in all tomee flavours (wasn't in webprofile before).

Re: EE10 - Jakarta Security OIDC

2024-06-11 Thread David Blevins
Are there specific parts you'd like eyes on? Maybe some things you imaged could be done a few different ways and chose one hoping for feedback if it wasn't right? Perhaps any new deployment or runtime concepts that were added? -David > On Jun 11, 2024, at 3:33 PM, David Blevins wrote: > >

Re: EE10 - Jakarta Security OIDC

2024-06-11 Thread David Blevins
I've only had a change to take a cursory look at the PR, but I was immediately impressed. I can't thank you enough -- what an amazing undertaking! It might be crickets getting a review for a PR that big especially given our starved state, so as long as you're a good sport about changes to the

Re: EE10 - Jakarta Security OIDC

2024-06-02 Thread Thomas Andraschko
Great work! Markus Jung schrieb am So., 2. Juni 2024, 17:34: > Hi all, > > small update after a long time of silence, my implementation now passes > the (admittedly very few) openid tests in the TCK: > [INFO] Reactor Summary for Jakarta Security TCK - main 3.0.1: > [INFO] > [INFO] Jakarta

Re: EE10 - Jakarta Security OIDC

2024-06-02 Thread Markus Jung
Hi all, small update after a long time of silence, my implementation now passes the (admittedly very few) openid tests in the TCK: [INFO] Reactor Summary for Jakarta Security TCK - main 3.0.1: [INFO] [INFO] Jakarta Security TCK - main SUCCESS [ 2.725 s] [INFO] common

Re: EE10 - Jakarta Security OIDC

2024-04-20 Thread Richard Zowalla
Cool! Thanks, Markus! Feel free to ask any question you might come across while implementing! Am Freitag, dem 19.04.2024 um 17:14 +0200 schrieb Markus Jung: > Hey all, > > just a quick heads up, i've began trying to work on this a couple of > days ago here:

Re: EE10 - Jakarta Security OIDC

2024-04-19 Thread Markus Jung
Hey all, just a quick heads up, i've began trying to work on this a couple of days ago here: https://github.com/jungm/tomee/tree/openid It's still a huge work in progress right now though > On 13. Apr 2024, at 20:29, Richard Zowalla wrote: > > Hi, > > looks like we need to implement

EE10 - Jakarta Security OIDC

2024-04-13 Thread Richard Zowalla
Hi, looks like we need to implement OpenID connect for Jakarta Security 3.0 - https://jakarta.ee/specifications/security/3.0/ If anyone wants to jump in and dive into the spec -> feel free :) Gruß Richard