Thanks Jean-Louis.
Fixed
Bruno Baptista
https://twitter.com/brunobat_
On 06/12/18 14:46, Jean-Louis Monteiro wrote:
There are some typos in there. See review
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Thu, Dec 6, 2018 at 3:43 PM Jean-Louis Monteiro
There are some typos in there. See review
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Thu, Dec 6, 2018 at 3:43 PM Jean-Louis Monteiro
wrote:
> Thanks Bruno. I'll review it very quick
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
>
Thanks Bruno. I'll review it very quick
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Thu, Dec 6, 2018 at 2:44 PM Bruno Baptista wrote:
> Hi folks,
>
> I've created a jira and a PR to define the rules/guidelines in the
> creation of new examples.
>
>
Hi folks,
I've created a jira and a PR to define the rules/guidelines in the
creation of new examples.
Jira: https://issues.apache.org/jira/browse/TOMEE-2326
PR: https://github.com/apache/tomee/pull/257
Please feel free to comment and ask for changes.
Cheers.
Bruno Baptista
> On Dec 5, 2018, at 10:28 AM, Bruno Baptista wrote:
>
> I'd say we have a problem here. What do you guys think we should do?
>
> • Remove Parent definition on examples and fix the ones that will break.
> • Use Parent always and fix the dependencies scope.
> • A mix of both.
Hi folks,
In my examples I've never declared the parent in the pom.xml like in here:
examples
org.apache.tomee
8.0.0-SNAPSHOT
This is because I wanted to precisely control the dependencies on the
project.
I was reviewing a PR from José Ventura and I noticed that even if he was
