Re: Finish the bval setup

2018-10-31 Thread Romain Manni-Bucau
It is mainly about ensuring it is ok then merge yes The jfx tests are not executed if not configured as such, the flag does it If I got it right Romain Manni-Bucau @rmannibucau | Blog | Old Blog

Re: Finish the bval setup

2018-10-31 Thread Matthew Broadhead
i  installed JavaFX on OpenJDK as I use it on another project.  but is he saying to use a flag to include it in TomEE?? On 31/10/2018 14:25, Matthew Broadhead wrote: does that mean pull the branch including the PR and compile? On 31/10/2018 12:09, Romain Manni-Bucau wrote: Hi guys, Wonder

Re: Finish the bval setup

2018-10-31 Thread Matthew Broadhead
does that mean pull the branch including the PR and compile? On 31/10/2018 12:09, Romain Manni-Bucau wrote: Hi guys, Wonder if somebody wants to review https://github.com/apache/tomee/pull/180 for merge From my point of view it looks good and would enable us (bval+tomee) to appear on bean

Finish the bval setup

2018-10-31 Thread Romain Manni-Bucau
Hi guys, Wonder if somebody wants to review https://github.com/apache/tomee/pull/180 for merge >From my point of view it looks good and would enable us (bval+tomee) to appear on bean validation site being certified once we'll release bval 2.0.1. If anyone has a few cycles to check the PR and