Re: Fix for tomee-webapp archetype

2018-12-06 Thread Daniel Cunha
Hi Bruno, thank you for review it. I really appreciate it. Em qua, 5 de dez de 2018 às 12:52, Bruno Baptista escreveu: > Daniel, > > It looks ok to me. > > Thanks for the PR! > > Bruno Baptista > https://twitter.com/brunobat_ > > > On 05/12/18 15:06, Bruno Baptista wrote: > > Hi Daniel, > > > >

Re: Fix for tomee-webapp archetype

2018-12-05 Thread Bruno Baptista
Daniel, It looks ok to me. Thanks for the PR! Bruno Baptista https://twitter.com/brunobat_ On 05/12/18 15:06, Bruno Baptista wrote: Hi Daniel, I'll review it Bruno Baptista https://twitter.com/brunobat_ On 05/12/18 14:55, Daniel Cunha wrote: Hi guys, Can someone review it: https://gith

Re: Fix for tomee-webapp archetype

2018-12-05 Thread Bruno Baptista
Hi Daniel, I'll review it Bruno Baptista https://twitter.com/brunobat_ On 05/12/18 14:55, Daniel Cunha wrote: Hi guys, Can someone review it: https://github.com/apache/tomee/pull/238? Thank you! :) Em ter, 4 de dez de 2018 às 19:45, César Hernández Mendoza < cesargu...@gmail.com> escreveu:

Re: Fix for tomee-webapp archetype

2018-12-05 Thread Daniel Cunha
Hi guys, Can someone review it: https://github.com/apache/tomee/pull/238? Thank you! :) Em ter, 4 de dez de 2018 às 19:45, César Hernández Mendoza < cesargu...@gmail.com> escreveu: > Got it, thanks for the feedback. > > > El mar., 4 dic. 2018 a las 13:59, Daniel Cunha () > escribió: > > > Hi Ces

Re: Fix for tomee-webapp archetype

2018-12-04 Thread César Hernández Mendoza
Got it, thanks for the feedback. El mar., 4 dic. 2018 a las 13:59, Daniel Cunha () escribió: > Hi Cesar, > > Thank you. Moving forward discussion here: > > Well... I believe which we don't need to have it sync with version used on > TomEE. > Just the others make sense (javaee-api, openejb, tomee

Re: Fix for tomee-webapp archetype

2018-12-04 Thread Daniel Cunha
Hi Cesar, Thank you. Moving forward discussion here: Well... I believe which we don't need to have it sync with version used on TomEE. Just the others make sense (javaee-api, openejb, tomee and openjpa). It will depends of the maven version that user are using. The current version that we are usi

Re: Fix for tomee-webapp archetype

2018-12-04 Thread César Hernández Mendoza
Hi Daniel, awesome, I already added my comments on the PR. El mar., 4 dic. 2018 a las 12:14, Daniel Cunha () escribió: > Hey, > > I just send a PR with the improvements and a little fix: > https://github.com/apache/tomee/pull/238 > > Let me know what do you think. > > Em seg, 3 de dez de 2018 às

Re: Fix for tomee-webapp archetype

2018-12-04 Thread Daniel Cunha
Hey, I just send a PR with the improvements and a little fix: https://github.com/apache/tomee/pull/238 Let me know what do you think. Em seg, 3 de dez de 2018 às 20:11, César Hernández Mendoza < cesargu...@gmail.com> escreveu: > Thank you, > I'm going to update my pr with the improvement you hi

Re: Fix for tomee-webapp archetype

2018-12-03 Thread César Hernández Mendoza
Thank you, I'm going to update my pr with the improvement you highlighted. El lun., 3 dic. 2018 a las 16:58, Daniel Cunha () escribió: > Hey Cesar, > > I pushed a comment on your PR. Hope it helps. > > Em seg, 3 de dez de 2018 às 19:54, César Hernández Mendoza < > cesargu...@gmail.com> escreveu:

Re: Fix for tomee-webapp archetype

2018-12-03 Thread Daniel Cunha
Hey Cesar, I pushed a comment on your PR. Hope it helps. Em seg, 3 de dez de 2018 às 19:54, César Hernández Mendoza < cesargu...@gmail.com> escreveu: > Hi, > > I created a PR for fixing the issue reported on > https://issues.apache.org/jira/browse/TOMEE-2313 about the failure on the > maven proj

Fix for tomee-webapp archetype

2018-12-03 Thread César Hernández Mendoza
Hi, I created a PR for fixing the issue reported on https://issues.apache.org/jira/browse/TOMEE-2313 about the failure on the maven project generated by tomee-webapp archetype. Could someone please review this PR? -- Atentamente: César Hernández Mendoza.