Re: MP JWT example revisited

2018-12-12 Thread Daniel Cunha
Hey Cesar, It seems good to go. I pushed my +1 on the PR. Em qua, 12 de dez de 2018 2:26 AM, César Hernández Mendoza < cesargu...@gmail.com escreveu: > Thank you @Roberto for the comments. > > I finish my PR and removed the "WIP" from the PR name, can somebody please > review it: https://github

Re: MP JWT example revisited

2018-12-11 Thread César Hernández Mendoza
Thank you @Roberto for the comments. I finish my PR and removed the "WIP" from the PR name, can somebody please review it: https://github.com/apache/tomee/pull/233 El mar., 11 dic. 2018 a las 4:32, Roberto Cortez () escribió: > If I remember correctly, you only need one of the roles in RolesAl

Re: MP JWT example revisited

2018-12-11 Thread Roberto Cortez
If I remember correctly, you only need one of the roles in RolesAllowed to be authorized. > On 11 Dec 2018, at 06:24, César Hernández Mendoza > wrote: > > I started to move forward this PR. > > I have one question: > What would be the correct behavior of a request containing a valid token > t

Re: MP JWT example revisited

2018-12-10 Thread César Hernández Mendoza
I started to move forward this PR. I have one question: What would be the correct behavior of a request containing a valid token that only hast the Group of Claims "crud" but the REST endpoint is annotated like this: @RolesAllowed({"crud", "read-only"}) Should the REST endpoint reply with a 403

Re: MP JWT example revisited

2018-12-03 Thread Bruno Baptista
Hi César, Looking forward to review it. Cheers. Bruno Baptista https://twitter.com/brunobat_ On 30/11/18 22:44, César Hernández Mendoza wrote: Hi, I'm planning to implement a couple of small improvements on the MicroProfile JWT example the project already has. I opened https://issues.apache

MP JWT example revisited

2018-11-30 Thread César Hernández Mendoza
Hi, I'm planning to implement a couple of small improvements on the MicroProfile JWT example the project already has. I opened https://issues.apache.org/jira/browse/TOMEE-2304 for this. I'll keep you updated with the proposal and progress. Ideas, proposal are more than welcome! -- Atentamente: C