Re: MP JWT filter eating exceptions

2018-09-26 Thread Thiago Veronezi
Tx Roberto, I was (still am) busy the past week too. No problem bud. Thanks for taking a look at that. []s, Thiago. On Mon, Sep 24, 2018 at 6:47 AM Roberto Cortez wrote: > Hi Thiago, > > I was on vacations. I’ll have al look. > > I was actually updating our current mp-jwt code to that latest s

Re: MP JWT filter eating exceptions

2018-09-24 Thread Roberto Cortez
Hi Thiago, I was on vacations. I’ll have al look. I was actually updating our current mp-jwt code to that latest spec. Cheers, Roberto > On 21 Sep 2018, at 14:46, Thiago Veronezi wrote: > > Hi Romain, > > Tx bud. PR updated. I will merge it later today. > Regarding the side note: I like wher

Re: MP JWT filter eating exceptions

2018-09-21 Thread Thiago Veronezi
Hi Romain, Tx bud. PR updated. I will merge it later today. Regarding the side note: I like where it is currently.It makes it simpler to contribute. []s, Thiago. On Thu, Sep 20, 2018 at 12:58 AM Romain Manni-Bucau wrote: > Hi Thiago > > The block was fine to handle jwt errors and convert them

Re: MP JWT filter eating exceptions

2018-09-19 Thread Romain Manni-Bucau
Hi Thiago The block was fine to handle jwt errors and convert them in 4xx but it was missing a final "else" to rethrow the original exception. Side note: since other mp spec are Geronimo ones, maybe this one should be migrated too to G impl? Le jeu. 20 sept. 2018 00:22, Thiago Veronezi a écrit

MP JWT filter eating exceptions

2018-09-19 Thread Thiago Veronezi
Guys (probably Jean-Louis or Roberto), Can you guys check this PR? https://github.com/apache/tomee/pull/169/ I'm trying to use JWT in this project, and got bitten by this catch block hiding a problem with my code. Is this the right way? Maybe I didn't quite get what the original comment tries to