Re: Metrics Gauge Example and Bug

Sure, Will have a look after lunch. Cheers. Bruno Baptista https://twitter.com/brunobat_ On 26/11/18 13:29, Ivan Junckes Filho wrote: Bruno, can you review again please? On Mon, Nov 26, 2018 at 10:46 AM Ivan Junckes Filho wrote: Awesome, thanks Bruno On Mon, Nov 26, 2018 at 10:23 AM

Re: Metrics Gauge Example and Bug

Bruno, can you review again please? On Mon, Nov 26, 2018 at 10:46 AM Ivan Junckes Filho wrote: > Awesome, thanks Bruno > > On Mon, Nov 26, 2018 at 10:23 AM Bruno Baptista > wrote: > >> Hi Ivan, >> >> I've requested some changes. >> >> Cheers >> >> Bruno Baptista >>

Re: Metrics Gauge Example and Bug

Awesome, thanks Bruno On Mon, Nov 26, 2018 at 10:23 AM Bruno Baptista wrote: > Hi Ivan, > > I've requested some changes. > > Cheers > > Bruno Baptista > https://twitter.com/brunobat_ > > > On 26/11/18 11:29, Bruno Baptista wrote: > > Hi, > > > > I can review it. > > > > Bruno Baptista > >

Re: Metrics Gauge Example and Bug

Hi Ivan, I've requested some changes. Cheers Bruno Baptista https://twitter.com/brunobat_ On 26/11/18 11:29, Bruno Baptista wrote: Hi, I can review it. Bruno Baptista https://twitter.com/brunobat_ On 23/11/18 18:27, Ivan Junckes Filho wrote: Hey guys can anyone review and merge this?

Re: Metrics Gauge Example and Bug

Hi, I can review it. Bruno Baptista https://twitter.com/brunobat_ On 23/11/18 18:27, Ivan Junckes Filho wrote: Hey guys can anyone review and merge this? https://github.com/apache/tomee/pull/218 On Fri, Nov 23, 2018 at 2:22 PM Roberto Cortez wrote: And it did cover. The test was

Re: Metrics Gauge Example and Bug

Hey guys can anyone review and merge this? https://github.com/apache/tomee/pull/218 On Fri, Nov 23, 2018 at 2:22 PM Roberto Cortez wrote: > And it did cover. The test was failing. > > > On 23 Nov 2018, at 16:00, Romain Manni-Bucau > wrote: > > > > >

Re: Metrics Gauge Example and Bug

And it did cover. The test was failing. > On 23 Nov 2018, at 16:00, Romain Manni-Bucau wrote: > > https://github.com/apache/tomee/blob/4c7fd4af95983a92bef89dc598873310dd13dd2e/server/openejb-cxf-rs/src/test/java/org/apache/openejb/server/cxf/rs/johnzon/JsonbJaxrsProviderTest.java > was

Re: Metrics Gauge Example and Bug

https://github.com/apache/tomee/blob/4c7fd4af95983a92bef89dc598873310dd13dd2e/server/openejb-cxf-rs/src/test/java/org/apache/openejb/server/cxf/rs/johnzon/JsonbJaxrsProviderTest.java was supposed to cover that Romain Manni-Bucau @rmannibucau | Blog

Re: Metrics Gauge Example and Bug

We should probably add a test for that regression. Bruno Baptista https://twitter.com/brunobat_ On 23/11/18 15:50, Ivan Junckes Filho wrote: It worked, thanks man! On Fri, Nov 23, 2018 at 12:40 PM Roberto Cortez wrote: Yes, that was the issue. This should fix it:

Re: Metrics Gauge Example and Bug

It worked, thanks man! On Fri, Nov 23, 2018 at 12:40 PM Roberto Cortez wrote: > Yes, that was the issue. This should fix it: > > https://github.com/apache/tomee/commit/1bfb65a1837235f4e9ad4458f67aabcab5eff829 > > Try to pull the code and test it again. > > Cheers, > Roberto > > On 23 Nov 2018,

Re: Metrics Gauge Example and Bug

Yes, that was the issue. This should fix it: https://github.com/apache/tomee/commit/1bfb65a1837235f4e9ad4458f67aabcab5eff829 Try to pull the code and test it again. Cheers, Roberto > On 23 Nov 2018, at 14:14,

Re: Metrics Gauge Example and Bug

No point. I’ve found the issue: It’s here: https://github.com/tomitribe/tomee/commit/7f18f4bcfe64119b9001d5ac6bffeb7324987a37 This commit reverted back the new JsonbProvider to the old JohnzonProvider. The

Re: Metrics Gauge Example and Bug

I was using the current master. 1.1.9 I will try to use the version Romain proposed and see how it works. On Thu, Nov 22, 2018 at 7:36 PM Roberto Cortez wrote: > Hey, > > I think metrics doesn’t even run properly on TomEE 7.x because of CDI 2.0. > > Regarding the fail, I’m not sure what is

Re: Metrics Gauge Example and Bug

Hey, I think metrics doesn’t even run properly on TomEE 7.x because of CDI 2.0. Regarding the fail, I’m not sure what is wrong. I remember seeing that before and I think it got fixed when we added the JsonB JAX-RS Provider. Maybe there is a regression in some place. Cheers, Roberto > On 22

Re: Metrics Gauge Example and Bug

Hi Ivan Do you use tomee 8 with johnzon 1.1.10? Works well on this one normally if johnzon defaults are not broken. On tomee 7 you need to add jsonb ;) Le jeu. 22 nov. 2018 21:51, Ivan Junckes Filho a écrit : > Also there are a lot of properties being returned on that payload that are > not

Re: Metrics Gauge Example and Bug

Also there are a lot of properties being returned on that payload that are not needed like rate1, rate5... etc. On Thu, Nov 22, 2018 at 6:26 PM Ivan Junckes Filho wrote: > The issue with the TCK is because meter in the spec expects fifteenMinRate > instead of fifteenMinuteRate. > > Same apply

Re: Metrics Gauge Example and Bug

The issue with the TCK is because meter in the spec expects fifteenMinRate instead of fifteenMinuteRate. Same apply for the other properties like fiveMin..oneMin.. @JsonbProperty("fifteenMinRate") is probably being ignored. On Thu, Nov 22, 2018 at 5:46 PM Ivan Junckes Filho wrote: > Hey

Re: Metrics Gauge Example and Bug

Hey Romain, it is actually a mapping issue. I created the PR but the microprofile metrics TCK seems to be broken on TomEE, so I am not sure if the PR is reliable. https://github.com/apache/geronimo-metrics/pull/2 I will try to check what is going on with the TCK on TomEE, if you have any tips let

Re: Metrics Gauge Example and Bug

Hi Ivan It is a bug in tomee scanning I think Le mer. 21 nov. 2018 21:35, Ivan Junckes Filho a écrit : > Hey guys, I was writing an example of metrics gauge (WIP). > > https://github.com/apache/tomee/pull/213 > > And I found a bug when trying access a gauge with "Accept: > application/json".

Metrics Gauge Example and Bug

Hey guys, I was writing an example of metrics gauge (WIP). https://github.com/apache/tomee/pull/213 And I found a bug when trying access a gauge with "Accept: application/json". Just to let you know that I will work on a fix for this: 21-Nov-2018 17:24:08.811 WARNING [http-nio-8080-exec-4]