Re: PR review and merge

Thanks a lot Roberto! Bruno Baptista https://twitter.com/brunobat_ On 29/01/19 17:19, Roberto Cortez wrote: I think all of them are now merged, except for https://github.com/apache/tomee/pull/370 My concern here is we are changing the equals implem

Re: PR review and merge

I think all of them are now merged, except for https://github.com/apache/tomee/pull/370 My concern here is we are changing the equals implementation, which is usually auto generated by our IDE’s. So, most likely these changes will be lost if someone r

Re: PR review and merge

Thanks Roberto. Bruno Baptista https://twitter.com/brunobat_ On 28/01/19 15:29, Roberto Cortez wrote: I’ll be looking into the current list of PR’s and try to merge the ones that are ready. Cheers, Roberto On 24 Jan 2019, at 15:23, Otávio Gonçalves de Santana wrote: Thank you for the ex

Re: PR review and merge

I’ll be looking into the current list of PR’s and try to merge the ones that are ready. Cheers, Roberto > On 24 Jan 2019, at 15:23, Otávio Gonçalves de Santana > wrote: > > Thank you for the explanation it Roberto. > > On Thu, Jan 24, 2019 at 12:50 PM Roberto Cortez > wrote: > >> We didn’t

Re: PR review and merge

Thank you for the explanation it Roberto. On Thu, Jan 24, 2019 at 12:50 PM Roberto Cortez wrote: > We didn’t. > > If we are moving forward with the release, I would prefer to keep these in > stand by until we are done. Right now, we are on a green build, and we > can’t be sure if any of these PR

Re: PR review and merge

We didn’t. If we are moving forward with the release, I would prefer to keep these in stand by until we are done. Right now, we are on a green build, and we can’t be sure if any of these PR’s would break it, so better to be safe :) > On 24 Jan 2019, at 12:05, Otávio Gonçalves de Santana > wro

Re: PR review and merge

Hello everyone, please don't forget these PRs On Wed, Jan 23, 2019 at 8:01 AM Bruno Baptista wrote: > Hi, > > Can one of the committers please take a look at these PRs? > > https://github.com/apache/tomee/pull/377 > https://github.com/apache/tomee/pull/376 > https://github.com/apache/tomee/pull/

PR review and merge

Hi, Can one of the committers please take a look at these PRs? https://github.com/apache/tomee/pull/377 https://github.com/apache/tomee/pull/376 https://github.com/apache/tomee/pull/375 https://github.com/apache/tomee/pull/370 https://github.com/apache/tomee/pull/366 https://github.com/apache/to