TransactionManagerLocator for QPID

2013-09-10 Thread Thiago Veronezi
Hi devs, I'm playing with Apache TomEE and Apache QPID. QPID resquires a TransactionManagerLocator class. I've proposed a solution at their side (https://issues.apache.org/jira/browse/QPID-5125) but I guess we could have it in our side too. I was thinking about adding a really simple class in TomE

Re: TransactionManagerLocator for QPID

2013-09-10 Thread Romain Manni-Bucau
Hi IIRC QPid doesn't need any API import so just putting it in core in a transaction package or something like it sounds enough for me. wdyt? *Romain Manni-Bucau* *Twitter: @rmannibucau * *Blog: **http://rmannibucau.wordpress.com/*

Re: TransactionManagerLocator for QPID

2013-09-10 Thread Thiago Veronezi
>>you can patch to check the method is static and can be called ;) I like that! Thanks! On Tue, Sep 10, 2013 at 1:08 PM, Romain Manni-Bucau wrote: > oki, you can patch to check the method is static and can be called ;). That > said we can allow to instantiate OpenEJB ;) and call a method getTm()

Re: TransactionManagerLocator for QPID

2013-09-10 Thread Romain Manni-Bucau
oki, you can patch to check the method is static and can be called ;). That said we can allow to instantiate OpenEJB ;) and call a method getTm() (ok it sounds hacky) *Romain Manni-Bucau* *Twitter: @rmannibucau * *Blog: **http://rmannibucau.wordpress.com/*

Re: TransactionManagerLocator for QPID

2013-09-10 Thread Thiago Veronezi
Ah! Thats true! :O) Duh! On Tue, Sep 10, 2013 at 11:43 AM, Romain Manni-Bucau wrote: > PS: just saw transactionManagerLocatorClass and > transactionManagerLocatorMethod > configs, isn't it enough and then we can reuse what we already have (ie > OpenEJB.getTransactionmanager())? > > *Romain Mann

Re: TransactionManagerLocator for QPID

2013-09-10 Thread Thiago Veronezi
Tkx! On Tue, Sep 10, 2013 at 11:49 AM, Thiago Veronezi wrote: > Ah! Thats true! > :O) Duh! > > > > On Tue, Sep 10, 2013 at 11:43 AM, Romain Manni-Bucau < > rmannibu...@gmail.com> wrote: > >> PS: just saw transactionManagerLocatorClass and >> transactionManagerLocatorMethod >> configs, isn't it e

Re: TransactionManagerLocator for QPID

2013-09-10 Thread Thiago Veronezi
H actually no. It seems that QPID creates a new instance of the locator class. I will wait a bit and see if my patch is accepted. Thanks, Thiago. On Tue, Sep 10, 2013 at 11:49 AM, Thiago Veronezi wrote: > Tkx! > > > On Tue, Sep 10, 2013 at 11:49 AM, Thiago Veronezi wrote: > >> Ah! Thats tr

Re: TransactionManagerLocator for QPID

2013-09-10 Thread Romain Manni-Bucau
PS: just saw transactionManagerLocatorClass and transactionManagerLocatorMethod configs, isn't it enough and then we can reuse what we already have (ie OpenEJB.getTransactionmanager())? *Romain Manni-Bucau* *Twitter: @rmannibucau * *Blog: **http://rmannibucau.wordp