Ok i have reviewed it and it’s good to go. Lemme merge it for you.
Le ven. 11 janv. 2019 à 09:07, Bruno Baptista a écrit :
> The new test run was successful.
>
> It's ready for review.
>
> Bruno Baptista
> https://twitter.com/brunobat_
>
>
> On 10/01/19 21:49, Bruno Baptista wrote:
> > Thanks Je
The new test run was successful.
It's ready for review.
Bruno Baptista
https://twitter.com/brunobat_
On 10/01/19 21:49, Bruno Baptista wrote:
Thanks Jean-Louis. It's appreciated. :)
The problem seems to be the testng version. Some TCK tests, on Config
and JWT don't like the new v6.14.3. Wil
Thanks Jean-Louis. It's appreciated. :)
The problem seems to be the testng version. Some TCK tests, on Config
and JWT don't like the new v6.14.3. Will keep the old v6.8.21 globaly
and override on the Fault Tolerance TCK.
We will have to come up with a migration plan.
I'm going to run all the
We can go step by step, it's fine if it's not perfect.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Thu, Jan 10, 2019 at 3:43 PM Bruno Baptista wrote:
> Talked too soon. I found some issues. Investigating now.
>
> Bruno Baptista
> https://twitter.com/brun
Talked too soon. I found some issues. Investigating now.
Bruno Baptista
https://twitter.com/brunobat_
On 10/01/19 14:34, Bruno Baptista wrote:
I've run the full build and it was green.
It should be good to go.
Bruno Baptista
https://twitter.com/brunobat_
On 09/01/19 23:24, Bruno Baptista
I've run the full build and it was green.
It should be good to go.
Bruno Baptista
https://twitter.com/brunobat_
On 09/01/19 23:24, Bruno Baptista wrote:
Hi,
The PR to integrate the latest Safeguard into TomEE is ready for
review here: https://github.com/apache/tomee/pull/365/
The TCK now
Hi,
The PR to integrate the latest Safeguard into TomEE is ready for review
here: https://github.com/apache/tomee/pull/365/
The TCK now passes with TomEE.
[INFO] Results:
[INFO]
[INFO] Tests run: 213, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
I'll run a full build tomorrow because thi
I think I found the problem.
The old version uses a different lifecycle event to declare the errors:
public void throwExceptions(@Observes AfterBeanDiscovery afterBeanDiscovery) {
microProfileValidator.forThrowable(afterBeanDiscovery::addDefinitionError);
}
The new one:
void addDefinitionEr
Yes, it was using a DefinitionException, but it shouldn’t matter that much,
since the problem should happen anyway as you describe.
> On 8 Jan 2019, at 17:27, Bruno Baptista wrote:
>
> Correct, but on the TCK, the FaultToleranceDefinitionException has not been
> released yet...
>
> I was also
Correct, but on the TCK, the FaultToleranceDefinitionException has not
been released yet...
I was also wondering about the old version while I was going for some
tea...
I'll run the same test on the old version and see want happens.
Bruno Baptista
https://twitter.com/brunobat_
On 08/01/19
Hum, I wonder how was that working before with the old version?
Are the expected exceptions new in the TCK? Looking into the code, it seems
they are there since 2017, and actually you changed the expect from
DefinitionException to FaultToleranceDefinitionException.
Anyway, in the previous Safeg
Hi folks,
This is a status update on the upgrade of Safeguard.
I was able to fix most issues, but a deeper problem remains.
When an app is being deployed, the /SafeguardExtension/ goes over it's
annotations and if something wrong is detected, a /DefinitionException/
is thrown, as expected. Th
12 matches
Mail list logo
