Re: [EXTERNAL] Deprecate /federation_resolvers/{{ID}}

2019-11-13 Thread ocket8888
Alright, I know it was over the weekend, but I'm gonna take my single "+1" and run with it. The PR will still be open for review likely for at least the rest of the day so if anyone still has concerns there's still time.

Re: [EXTERNAL] Deprecate /federation_resolvers/{{ID}}

2019-11-11 Thread ocket 8888
Sort of. I can't off the top of my head think of a route like `foo/{{ID}}` that only supported DELETE that was deprecated in the past, but I'd argue `/user/current/update` being deprecated in favor of the existing PUT handler for `/user/current` is analogous. On Mon, Nov 11, 2019 at 11:31 AM Hoppa

Re: [EXTERNAL] Deprecate /federation_resolvers/{{ID}}

2019-11-11 Thread Hoppal, Michael
Generally I would be +1 on the approach. My question would be have we taken the same approach on other similar endpoints? My hope would be to keep a consistent approach. For what is worth for the ones I have rewritten I did not take that approach. I left in the route that had just the DELETE ve