Re: [EXTERNAL] Re: Removing uid and gid from user

2018-09-17 Thread Robert Butts
>the "confirmLocalPasswd" field (and related db column) should also be deprecated +1 On Sat, Sep 15, 2018 at 3:29 PM Dan Kirkwood wrote: > +1 on this plan -- remove UID/GID from the db, keep (deprecated) in the API > until the next major version of the API. > > Sorry to add to it, but the "co

Re: [EXTERNAL] Re: Removing uid and gid from user

2018-09-15 Thread Dan Kirkwood
+1 on this plan -- remove UID/GID from the db, keep (deprecated) in the API until the next major version of the API. Sorry to add to it, but the "confirmLocalPasswd" field (and related db column) should also be deprecated. Traffic Portal should keep this and check the fields as now, but only pa

Re: [EXTERNAL] Re: Removing uid and gid from user

2018-09-14 Thread Robert Butts
>i would be curious if > >PUT api/*/users/:id >PUT api/*/user/current > >really allows you to change them and if it does even more of a reason to >keep them because maybe somebody is setting those id's for some reason... Well, if someone is using a TC data field for something outside TC, I don't k

Re: [EXTERNAL] Re: Removing uid and gid from user

2018-09-14 Thread Moltzau, Matthew
PUT api/*/users/:id Doesn't actually exist in v13 (which is perl for this particular endpoint) On 9/14/18, 2:46 PM, "Jeremy Mitchell" wrote: Yeah, like Rob said, have to keep those fields because they are part of the 1.x contract even though they are null...which does seem kinda silly b

Re: [EXTERNAL] Re: Removing uid and gid from user

2018-09-14 Thread Jeremy Mitchell
Yeah, like Rob said, have to keep those fields because they are part of the 1.x contract even though they are null...which does seem kinda silly but api versioning is a promise... i would be curious if PUT api/*/users/:id PUT api/*/user/current really allows you to change them and if it does eve

Re: [EXTERNAL] Re: Removing uid and gid from user

2018-09-14 Thread Robert Butts
-1 on removing them from the API, they're part of API 1.x, we can't remove them without breaking Semantic Versioning. +1 on removing from the db, hard-coding the API to return nulls, and documenting them as deprecated in the API. The db has no "version promise", we can definitely clean that up.

Re: [EXTERNAL] Re: Removing uid and gid from user

2018-09-14 Thread Moltzau, Matthew
Yes, this might also affect PUT for /api/*/user/current. At least the documentation says that the gid and uid may be altered, though I don't currently know if that's actually the case. On 9/14/18, 2:37 PM, "Jeremy Mitchell" wrote: Which endpoints are you talking about specifically?