Re: Proposal: ORT/t3c git

2021-03-16 Thread Dave Neuman
+1 to adding this as a local option. It could be a good stepping stone for something like Rawlin is suggesting. On Tue, Mar 16, 2021 at 16:46 Rawlin Peters wrote: > I don't really see a reason not to provide this option, even if it is > just local. > > However, I could see us using a remote git

Re: Proposal: ORT/t3c git

2021-03-16 Thread Rawlin Peters
I don't really see a reason not to provide this option, even if it is just local. However, I could see us using a remote git server to actually propagate configs to caches. For instance, every server would get its own branch in the repo, and ORT would periodically pull its server's branch to get n

Re: [EXTERNAL] Re: Proposal: ORT/t3c git

2021-03-16 Thread Robert O Butts
@Jonathan_Gray The current PR commits everything in the ATS config directory. This excludes any config files outside that directory, and typically includes SSL certificates and keys. This shouldn't be a security concern, as the git repo is created with the same permissions as the ORT script. If a u

Re: [EXTERNAL] Re: Proposal: ORT/t3c git

2021-03-16 Thread Gray, Jonathan
Also, DS SSL certificate/key data is considered configuration for ATS. Is that intended to be captured in the git repo, a reference to the riak key version included, or excluded entirely? If it's excluded, wouldn't that create a gap in rollbacks? Jonathan G On 3/16/21, 3:06 PM, "Eric Fried

Re: Proposal: ORT/t3c git

2021-03-16 Thread Robert O Butts
It's entirely local. Basically, ORT/t3c is just doing "git init" and "git commit." We could make it remote, but that'd be a much larger feature. I'm not sure how useful remote would be, other than maybe for backups. Because every server is going to have slightly different config, you wouldn't want

Re: Proposal: ORT/t3c git

2021-03-16 Thread Eric Friedrich
Can you explain more about how the git repo works? Is it a local repo or a git server somewhere? How are configs on different servers stored (diff repos, diff branches, diff directories, etc...)? It sounds like a useful feature, but I think I'm missing the big picture. On Tue, Mar 16, 2021, 4:

Proposal: ORT/t3c git

2021-03-16 Thread Robert O Butts
I'd like to propose adding a feature to ORT/t3c to track config changes in a git repo. My plan is to add a flag `--git` with the options yes/no/auto, defaulting to `auto`. With 'auto' a repo will be committed to if it exists, but not created. With 'yes' the repo will be created and committed to. W