[GitHub] trafficserver pull request: TS-3792: Crash with non-existant or mi...

2015-07-28 Thread bgaff
Github user bgaff commented on the pull request: https://github.com/apache/trafficserver/pull/262#issuecomment-125851594 I'm happy with this implementation, if the user does something stupid like specify a resolv conf that is nonexistent or doesn't contain any resolvers the behavior w

[GitHub] trafficserver pull request: TS-3792: Crash with non-existant or mi...

2015-07-28 Thread zizhong
Github user zizhong commented on the pull request: https://github.com/apache/trafficserver/pull/262#issuecomment-125850171 Thanks for the useful information. I updated the pull request. Now it would not crash when it doesn't have a DNS resolver. Looking forward to new feedbacks. ---

[GitHub] trafficserver pull request: Coverity issues:

2015-07-28 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/259#discussion_r35712793 --- Diff: mgmt/Alarms.cc --- @@ -413,6 +413,7 @@ Alarms::constructAlarmMessage(const AppVersionInfo &version, char *ip, char *mes if

[GitHub] trafficserver pull request: TS-3740: header_rewrite set-redirect e...

2015-07-28 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/253#issuecomment-125773588 Looks reasonable, except master is frozen until we clean up 6.0.0, --- If your project is set up for it, you can reply to this email and have your reply a

[DISCUSS] CTR vs RTC

2015-07-28 Thread Leif Hedstrom
Hi all, I think we need to have this discussion again, for various reasons: 1) Our code base is getting bigger, with a fair amount of new changes from contributors old and new to the projects. 2) We’re sort of already doing this on a largish number of commits via Github, so maybe formalizing

[URGENT] Please keep master stable for a few days

2015-07-28 Thread Leif Hedstrom
Hi all, we’re trying to figure out how to deal with the 6.0.x release / branch, so I’m asking everyone to keep changes to the master branch at a minimum for the time being (at least a couple of days). Fixes for outright bugs is fine, but use your best judgement. Fwiw, our two options right now