Github user masaori335 commented on the pull request:
https://github.com/apache/trafficserver/pull/454#issuecomment-182204034
I didn't know this one. Thanks!
I'll fix with this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/454#issuecomment-182203667
Sorry, you need to use
[##__VA_ARGS__](https://gcc.gnu.org/onlinedocs/cpp/Variadic-Macros.html).
---
If your project is set up for it, you can reply to this email
Github user masaori335 commented on the pull request:
https://github.com/apache/trafficserver/pull/454#issuecomment-182203173
@jpeach I thought that too, but it has error in my box (CentOS7, gcc-4.8)
Diff: https://paste.apache.org/4tlm
Result: https://paste.apache.org/gnEb
--
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/454#issuecomment-182201097
You should not need both ``DebugHttp2StreamMsg`` and
``DebugHttp2StreamFmt``, since is it valid (widely implemented GCC extension)
to not pass any format arguments
Github user masaori335 commented on the pull request:
https://github.com/apache/trafficserver/pull/454#issuecomment-182201082
(Because of I force pushed, James's comment is disappeared:\ )
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user masaori335 commented on the pull request:
https://github.com/apache/trafficserver/pull/454#issuecomment-182200775
@bryancall It looks good. But it totally needs 3 macros like below as far
as I tried.
```
#define DebugHttp2Con(ua_session, fmt, ...) \
Debug
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/464
TS-4178: Memory leak in SplitDNSConfig when shutting down
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-41
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/463
TS-4181: Memory leak in aio threads when shutting down
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-4188
I measured the HPACK compression ratio of Traffic Server 6.1.1
(+TS-4092) with hpack-test-cases.
http://paste.apache.org/0uY6
It looks the result is good enough. There are few things we can do for
compression ratio, but I think it would be better to focus on
improving performance.
I'm going to cr
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/459
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/454#issuecomment-182151443
I think it would make sense to have a DebugHttp2Stream that would be used
at the stream level and format both ids, which is most of the debugging.
---
If your
Github user sc0ttbeardsley commented on the pull request:
https://github.com/apache/trafficserver/pull/459#issuecomment-182104126
@mlibbey it is a global plugin. @dmorilha we should add a "how to configure
and use" section in the readme. I'll send you a PR if I get a chance
---
If yo
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/459#issuecomment-182093202
I reviewed this before in our work repository and I am happy with it.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user dmorilha commented on the pull request:
https://github.com/apache/trafficserver/pull/459#issuecomment-182034464
I will make sure to squash it again once we reach an agreement here.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user sc0ttbeardsley commented on the pull request:
https://github.com/apache/trafficserver/pull/459#issuecomment-182003287
@dmorilha ya, looks pretty good. We should add some details about adding
the remaps for image asset urls since that is a bit tricky. Also we should add
in
Github user robguima commented on the pull request:
https://github.com/apache/trafficserver/pull/455#issuecomment-181994021
@zwoop @shukitchan please let me know if the std::string free version above
is OK - if so I will squash it thx
---
If your project is set up for it, you can rep
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/462
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/462#issuecomment-181983212
@jpeach Http2::initial_window_size is used to store the configured value.
HTTP2_INITIAL_WINDOW_SIZE can't be changed.
---
If your project is set up for it, yo
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/462#issuecomment-181976678
Looks good to me. I think I ran into something similar playing with
different window options for nghttp a while back.
---
If your project is set up for it, you
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/462
Ts 4188
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver ts-4188
Alternatively you can review and apply these c
The deadline for talk proposals for Apachecon NA is this Friday.
http://events.linuxfoundation.org/events/apachecon-north-america/program/cfp
Please consider submitting something about your current work, planned
work, experiences, etc. using ATS and/or other Apache open source
projects. We n
Github user mlibbey commented on the pull request:
https://github.com/apache/trafficserver/pull/459#issuecomment-181897910
Re: doc. I think the read me is a great start. Is the plugin a global or
remap plugin?
---
If your project is set up for it, you can reply to this email and have
22 matches
Mail list logo
