Re: Avoid copy data in Http2Stream::update_write_request()

2017-11-27 Thread Masaori Koshiba
All right, I'll try to get rid of the copy. Thanks! - Masaori 2017年11月28日(火) 11:26 shinr...@ieee.org : > Masori, > > We probably don't need to copy. The copy is just moving blocks between > lists but I agree that it adds complexity. > > At the time I was getting rid of the PluginVC wrapper I wa

Re: Avoid copy data in Http2Stream::update_write_request()

2017-11-27 Thread shinr...@ieee.org
Masori,  We probably don't need to copy.  The copy is just moving blocks between lists but I agree that it adds complexity. At the time I was getting rid of the PluginVC wrapper I was trying to understand both sides of the do_io operations.  So things probably ended up more complex than they nee

Avoid copy data in Http2Stream::update_write_request()

2017-11-27 Thread Masaori Koshiba
Hi HTTP/2 hackers, I’m fighting with #2795. And I’m really confused by `Http2Stream::update_write_request()`. Why do we need to copy over data from `write_vio` to `response_buffer`? ( https://github.com/apache/trafficserver/blob/master/proxy/http2/Http2Stream.cc#L538-L556 ) It looks like this mak