Re: [API] Expose Client request SSL Stats

2019-07-17 Thread Valentín Gutierrez
That's right, what we need are SSL attributes like the protocol version or the cipher used On Wed, Jul 17, 2019, 23:16 Sudheer Vinukonda wrote: > Oh, it looks like the goal is to actually get SSL context attributes for > a given TXN and not so much _STATS_. Sorry, I was confused by the use of >

Re: [API] Expose Client request SSL Stats

2019-07-17 Thread Sudheer Vinukonda
Oh, it looks like the goal is to actually get SSL context attributes for a given TXN and not so much _STATS_. Sorry, I was confused by the use of word _STAT_ and assumed you were trying to collect metrics/counters. Assuming it is the SSL Context attributes for a TXN that you are looking to get,

Re: [API] Expose Client request SSL Stats

2019-07-17 Thread Alan Carroll
Looking at the current API in this area, I think it might be better to model it on TSStatFindName and related functions. This would mean something like TSReturnCode TSSslStatFindName(const char * name, int * idx); TSMgmtInt TSSslStatGet(idx); On Wed, Jul 17, 2019 at 12:39 AM Valentín Gutierrez <

Re: [API] Expose Client request SSL Stats

2019-07-16 Thread Valentín Gutierrez
So something like this would be more appealing? typedef enum { TS_STAT_SSL_PROTOCOL = 0, TS_STAT_SSL_CIPHER, TS_STAT_SSL_CURVE, } TSStatSsl; int TSHttpTxnClientReqIsSslReused(TSHttpTxn txnp); const char *TSHttpTxnClientReqSslStatGet(TSHttpTxn txnp, TSStatSsl stat_ssl); On Wed, Jul 17, 2019 at 1:

Re: [API] Expose Client request SSL Stats

2019-07-16 Thread Sudheer Vinukonda
Hmm...feels like this is a bit of an overload to write a separate API for each stat - Would it be better to write generic APIs that can return any stat (defined as an ENUM for example)?  On Tuesday, July 16, 2019, 11:07:19 AM PDT, Valentín Gutierrez wrote: Hi, We need to expose sev

[API] Expose Client request SSL Stats

2019-07-16 Thread Valentín Gutierrez
Hi, We need to expose several client request SSL stats that are currently being gathered in the HttpSM to the Lua plugin. To achieve this I'd like to propose adding several functions to the API: int TSHttpTxnClientReqIsSslReused(TSHttpTxn txnp); const char *TSHttpTxnClientReqSslCipherGet(TSHttpTx