Github user oknet commented on the pull request:
https://github.com/apache/trafficserver/pull/673#issuecomment-222517497
Due to the #629 already merged, I will update the patch to fit it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/673#issuecomment-222324666
Good point on the lock check. Could have finished the current vio in the
signal and then end of mysteriously disabling the next vio.
---
If your project is s
Github user oknet commented on the pull request:
https://github.com/apache/trafficserver/pull/673#issuecomment-222300709
vote on PR #629, but the 2nd issue: did not check the change of lock after
return from wbe callback, not included.
---
If your project is set up for it, you can re
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/673#issuecomment-222175909
I think the right thing to do is push PR #629. That moves the read/write
loops to use the IOBuffer interface instead of the IOBlock interface. I've
been holdin
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/673#discussion_r64913857
--- Diff: iocore/net/UnixNetVConnection.cc ---
@@ -545,57 +545,61 @@ write_to_net_io(NetHandler *nh, UnixNetVConnection
*vc, EThread *thread)
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/673#discussion_r64913617
--- Diff: iocore/net/UnixNetVConnection.cc ---
@@ -545,57 +545,61 @@ write_to_net_io(NetHandler *nh, UnixNetVConnection
*vc, EThread *thread)
GitHub user oknet opened a pull request:
https://github.com/apache/trafficserver/pull/673
TS-4487: fix write_to_net_io issues
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/oknet/trafficserver patch-13
Alternatively you can rev
