[GitHub] [incubator-tubemq] duli559 commented on a change in pull request #128: [TUBEMQ-197] Support TubeMQ connector of source for Apache Flink

2020-06-04 Thread GitBox
duli559 commented on a change in pull request #128: URL: https://github.com/apache/incubator-tubemq/pull/128#discussion_r435201896 ## File path: tubemq-connectors/tubemq-connector-flink/src/main/java/org/apache/flink/connectors/tube/TubeTableSource.java ## @@ -0,0 +1,226 @@ +/

[GitHub] [incubator-tubemq] duli559 commented on a change in pull request #128: [TUBEMQ-197] Support TubeMQ connector of source for Apache Flink

2020-06-04 Thread GitBox
duli559 commented on a change in pull request #128: URL: https://github.com/apache/incubator-tubemq/pull/128#discussion_r435201803 ## File path: pom.xml ## @@ -68,6 +68,7 @@ tubemq-client tubemq-server tubemq-example + tubemq-connectors

[GitHub] [incubator-tubemq] duli559 commented on a change in pull request #128: [TUBEMQ-197] Support TubeMQ connector of source for Apache Flink

2020-06-04 Thread GitBox
duli559 commented on a change in pull request #128: URL: https://github.com/apache/incubator-tubemq/pull/128#discussion_r435194981 ## File path: tubemq-connectors/tubemq-connector-flink/src/main/java/org/apache/flink/connectors/tube/Tube.java ## @@ -0,0 +1,149 @@ +/* + * Licen

[GitHub] [incubator-tubemq] duli559 commented on a change in pull request #128: [TUBEMQ-197] Support TubeMQ connector of source for Apache Flink

2020-06-04 Thread GitBox
duli559 commented on a change in pull request #128: URL: https://github.com/apache/incubator-tubemq/pull/128#discussion_r435111357 ## File path: tubemq-server/src/test/resource/data/.tube ## @@ -0,0 +1 @@ +abcabc Review comment: sorry, it's a wrong f

[GitHub] [incubator-tubemq] duli559 commented on a change in pull request #128: [TUBEMQ-197] Support TubeMQ connector of source for Apache Flink

2020-06-04 Thread GitBox
duli559 commented on a change in pull request #128: URL: https://github.com/apache/incubator-tubemq/pull/128#discussion_r435111357 ## File path: tubemq-server/src/test/resource/data/.tube ## @@ -0,0 +1 @@ +abcabc Review comment: Sorry, it's a wrong f