[GitHub] [incubator-tubemq] netroby commented on pull request #49: [TUBEMQ-63] Replace force local dependency of protoc with auto-downloading

2020-06-02 Thread GitBox
netroby commented on pull request #49: URL: https://github.com/apache/incubator-tubemq/pull/49#issuecomment-637939508 @gosonzhang agree to delete protobuf, it not the must requirement . This is an automated message from the

[GitHub] [incubator-tubemq] netroby commented on pull request #49: [TUBEMQ-63] Replace force local dependency of protoc with auto-downloading

2020-06-04 Thread GitBox
netroby commented on pull request #49: URL: https://github.com/apache/incubator-tubemq/pull/49#issuecomment-639185205 anyway, this pull request solve one problem , User may not want download protoc, Fuck protobuf as my side(I hate protobuf)

[GitHub] [incubator-tubemq] netroby commented on pull request #49: [TUBEMQ-63] Replace force local dependency of protoc with auto-downloading

2020-06-04 Thread GitBox
netroby commented on pull request #49: URL: https://github.com/apache/incubator-tubemq/pull/49#issuecomment-639186151 For the bad side. Import the third party dependencies not always good things. especially for opensource project. --

[GitHub] [incubator-tubemq] netroby commented on pull request #49: [TUBEMQ-63] Replace force local dependency of protoc with auto-downloading

2020-06-04 Thread GitBox
netroby commented on pull request #49: URL: https://github.com/apache/incubator-tubemq/pull/49#issuecomment-639186634 If any one, such as a hacker inject backdoor with that compile plugin. may dangerous . It is possible lost control. --