cku328 opened a new pull request #24:
URL: https://github.com/apache/incubator-tubemq-website/pull/24
1. Merge the contents of docs user guide and quick start
2. Update start/stop service commands
3. Fix demo example
Th
gosonzhang opened a new pull request #126:
URL: https://github.com/apache/incubator-tubemq/pull/126
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
lamberliu merged pull request #126:
URL: https://github.com/apache/incubator-tubemq/pull/126
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
lamberliu commented on pull request #126:
URL: https://github.com/apache/incubator-tubemq/pull/126#issuecomment-638649938
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
gosonzhang commented on a change in pull request #125:
URL: https://github.com/apache/incubator-tubemq/pull/125#discussion_r435046493
##
File path:
tubemq-client/src/main/java/org/apache/tubemq/client/producer/SimpleMessageProducer.java
##
@@ -335,11 +336,13 @@ private void ch
wf123537200 merged pull request #24:
URL: https://github.com/apache/incubator-tubemq-website/pull/24
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
gosonzhang opened a new pull request #127:
URL: https://github.com/apache/incubator-tubemq/pull/127
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
gosonzhang opened a new pull request #25:
URL: https://github.com/apache/incubator-tubemq-website/pull/25
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
gosonzhang merged pull request #25:
URL: https://github.com/apache/incubator-tubemq-website/pull/25
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
lamberliu merged pull request #127:
URL: https://github.com/apache/incubator-tubemq/pull/127
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
duli559 opened a new pull request #128:
URL: https://github.com/apache/incubator-tubemq/pull/128
1. Add module of 'tubemq-connectors' for project, it will contains all types
of connector for TubeMQ, like Flink, Spark, etc.
2. Support TubeMQ connector of source for Apache Flink.
J
duli559 commented on pull request #128:
URL: https://github.com/apache/incubator-tubemq/pull/128#issuecomment-638714380
@gosonzhang
This is an automated message from the Apache Git Service.
To respond to the message, please
gosonzhang commented on a change in pull request #128:
URL: https://github.com/apache/incubator-tubemq/pull/128#discussion_r435103721
##
File path: tubemq-server/src/test/resource/data/.tube
##
@@ -0,0 +1 @@
+abcabc
Review comment:
Does the test data
duli559 opened a new pull request #129:
URL: https://github.com/apache/incubator-tubemq/pull/129
Delete duplicate dependency of jetty in tuber-server pom.
Jira link with: https://issues.apache.org/jira/browse/TUBEMQ-205
---
duli559 commented on pull request #129:
URL: https://github.com/apache/incubator-tubemq/pull/129#issuecomment-638725885
@gosonzhang
This is an automated message from the Apache Git Service.
To respond to the message, please
duli559 commented on a change in pull request #128:
URL: https://github.com/apache/incubator-tubemq/pull/128#discussion_r435111357
##
File path: tubemq-server/src/test/resource/data/.tube
##
@@ -0,0 +1 @@
+abcabc
Review comment:
sorry, it's a wrong f
duli559 commented on a change in pull request #128:
URL: https://github.com/apache/incubator-tubemq/pull/128#discussion_r435111357
##
File path: tubemq-server/src/test/resource/data/.tube
##
@@ -0,0 +1 @@
+abcabc
Review comment:
Sorry, it's a wrong f
gosonzhang merged pull request #129:
URL: https://github.com/apache/incubator-tubemq/pull/129
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
gosonzhang commented on pull request #129:
URL: https://github.com/apache/incubator-tubemq/pull/129#issuecomment-638787408
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on
guangxuCheng commented on a change in pull request #128:
URL: https://github.com/apache/incubator-tubemq/pull/128#discussion_r435182723
##
File path: pom.xml
##
@@ -68,6 +68,7 @@
tubemq-client
tubemq-server
tubemq-example
+ tubemq-connec
duli559 opened a new pull request #130:
URL: https://github.com/apache/incubator-tubemq/pull/130
There are some residual files after executed unit tests by 'tubemq-server'
module, create temporary files to avoid this problem.
Jira link with: https://issues.apache.org/jira/browse/TUBE
aloyszhang commented on a change in pull request #128:
URL: https://github.com/apache/incubator-tubemq/pull/128#discussion_r435190820
##
File path:
tubemq-connectors/tubemq-connector-flink/src/main/java/org/apache/flink/connectors/tube/TubeTableSource.java
##
@@ -0,0 +1,226 @@
duli559 commented on a change in pull request #128:
URL: https://github.com/apache/incubator-tubemq/pull/128#discussion_r435194981
##
File path:
tubemq-connectors/tubemq-connector-flink/src/main/java/org/apache/flink/connectors/tube/Tube.java
##
@@ -0,0 +1,149 @@
+/*
+ * Licen
duli559 commented on a change in pull request #128:
URL: https://github.com/apache/incubator-tubemq/pull/128#discussion_r435201803
##
File path: pom.xml
##
@@ -68,6 +68,7 @@
tubemq-client
tubemq-server
tubemq-example
+ tubemq-connectors
duli559 commented on a change in pull request #128:
URL: https://github.com/apache/incubator-tubemq/pull/128#discussion_r435201896
##
File path:
tubemq-connectors/tubemq-connector-flink/src/main/java/org/apache/flink/connectors/tube/TubeTableSource.java
##
@@ -0,0 +1,226 @@
+/
gosonzhang commented on a change in pull request #125:
URL: https://github.com/apache/incubator-tubemq/pull/125#discussion_r435272490
##
File path:
tubemq-core/src/main/java/org/apache/tubemq/corebase/utils/CompressionType.java
##
@@ -0,0 +1,94 @@
+/**
Review comment:
gosonzhang commented on a change in pull request #125:
URL: https://github.com/apache/incubator-tubemq/pull/125#discussion_r435276102
##
File path:
tubemq-core/src/main/java/org/apache/tubemq/corebase/utils/DataConverterUtil.java
##
@@ -233,8 +233,17 @@
pa
gosonzhang commented on a change in pull request #125:
URL: https://github.com/apache/incubator-tubemq/pull/125#discussion_r435278576
##
File path:
tubemq-client/src/main/java/org/apache/tubemq/client/producer/SimpleMessageProducer.java
##
@@ -335,11 +336,13 @@ private void ch
gosonzhang commented on a change in pull request #125:
URL: https://github.com/apache/incubator-tubemq/pull/125#discussion_r435284842
##
File path:
tubemq-client/src/main/java/org/apache/tubemq/client/producer/SimpleMessageProducer.java
##
@@ -321,7 +322,7 @@ private void chec
viviel opened a new pull request #131:
URL: https://github.com/apache/incubator-tubemq/pull/131
Remove the steps that need to explicitly configure protocol buffer on the
local machine, and directly use Maven plugin to complete, simplifying the
process of contributor's configuration of Pb e
aloyszhang commented on pull request #130:
URL: https://github.com/apache/incubator-tubemq/pull/130#issuecomment-638933278
Nice contribution. LGTM
This is an automated message from the Apache Git Service.
To respond to the m
guangxuCheng commented on pull request #49:
URL: https://github.com/apache/incubator-tubemq/pull/49#issuecomment-638963434
@TisonKun Can you fix these conflicts? This is a good idea. If no objection,
i will merge this PR
Thi
guangxuCheng commented on pull request #131:
URL: https://github.com/apache/incubator-tubemq/pull/131#issuecomment-638964615
duplicate of #49 ?
This is an automated message from the Apache Git Service.
To respond to the mess
zhenjunMa opened a new pull request #26:
URL: https://github.com/apache/incubator-tubemq-website/pull/26
change page quick start link from `/docs/tubeme_user_guide.html` to
`/docs/quick_start.html`
This is an automated messa
netroby commented on pull request #49:
URL: https://github.com/apache/incubator-tubemq/pull/49#issuecomment-639185205
anyway, this pull request solve one problem , User may not want download
protoc, Fuck protobuf as my side(I hate protobuf)
netroby commented on pull request #49:
URL: https://github.com/apache/incubator-tubemq/pull/49#issuecomment-639186151
For the bad side. Import the third party dependencies not always good
things. especially for opensource project.
--
netroby commented on pull request #49:
URL: https://github.com/apache/incubator-tubemq/pull/49#issuecomment-639186634
If any one, such as a hacker inject backdoor with that compile plugin. may
dangerous . It is possible lost control.
--
TisonKun commented on pull request #49:
URL: https://github.com/apache/incubator-tubemq/pull/49#issuecomment-639190047
> @TisonKun Can you fix these conflicts? This is a good idea. If no
objection, i will merge this PR
Done. Except the document side. Could you guide me to the new pla
guangxuCheng commented on pull request #49:
URL: https://github.com/apache/incubator-tubemq/pull/49#issuecomment-639211276
> > @TisonKun Can you fix these conflicts? This is a good idea. If no
objection, i will merge this PR
>
> Done. Except the document side. Could you guide me to t
aloyszhang merged pull request #130:
URL: https://github.com/apache/incubator-tubemq/pull/130
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
aloyszhang merged pull request #128:
URL: https://github.com/apache/incubator-tubemq/pull/128
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
aloyszhang commented on pull request #128:
URL: https://github.com/apache/incubator-tubemq/pull/128#issuecomment-639217832
@duli559 Thanks for you contribution, LGTM.
This is an automated message from the Apache Git Service
TisonKun commented on pull request #49:
URL: https://github.com/apache/incubator-tubemq/pull/49#issuecomment-639225394
@guangxuCheng thanks! Merging this one and will update document.
This is an automated message from the Apa
TisonKun merged pull request #49:
URL: https://github.com/apache/incubator-tubemq/pull/49
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
TisonKun commented on pull request #131:
URL: https://github.com/apache/incubator-tubemq/pull/131#issuecomment-639225822
Closed by #49 . Thanks for nudging this work.
This is an automated message from the Apache Git Service.
TisonKun closed pull request #131:
URL: https://github.com/apache/incubator-tubemq/pull/131
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
TisonKun commented on pull request #131:
URL: https://github.com/apache/incubator-tubemq/pull/131#issuecomment-639226195
@viviel from the original ticket it is still valid if you try to shade
protobuf deps for goods.
This is
TisonKun commented on pull request #49:
URL: https://github.com/apache/incubator-tubemq/pull/49#issuecomment-639228054
FYI:
https://github.com/apache/incubator-tubemq-website/commit/c376aac05b01f160043119782b1729dcf05b9311
https://github.com/apache/incubator-tubemq-website/commit
Daniel-Dos opened a new pull request #27:
URL: https://github.com/apache/incubator-tubemq-website/pull/27
fix link page contact link from /contact to ../contact.html
This is an automated message from the Apache Git Service.
T
guangxuCheng opened a new pull request #28:
URL: https://github.com/apache/incubator-tubemq-website/pull/28
these files will be auto-generated when build project. so delete them
This is an automated message from the Apache Gi
Daniel-Dos opened a new pull request #29:
URL: https://github.com/apache/incubator-tubemq-website/pull/29
add format java in doc consumer_example and producer_example
This is an automated message from the Apache Git Service.
gosonzhang merged pull request #26:
URL: https://github.com/apache/incubator-tubemq-website/pull/26
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
gosonzhang merged pull request #27:
URL: https://github.com/apache/incubator-tubemq-website/pull/27
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
gosonzhang merged pull request #29:
URL: https://github.com/apache/incubator-tubemq-website/pull/29
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
gosonzhang merged pull request #28:
URL: https://github.com/apache/incubator-tubemq-website/pull/28
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
viviel opened a new pull request #132:
URL: https://github.com/apache/incubator-tubemq/pull/132
Optimize code
```
List messageList = new ArrayList<>();
if (transferedMessageList == null || transferedMessageList.isEmpty()) {
return messageList;
}
change to
netroby opened a new pull request #30:
URL: https://github.com/apache/incubator-tubemq-website/pull/30
…rotoc .
User can just skip to next chapter.
This is an automated message from the Apache Git Service.
To respond t
netroby opened a new pull request #133:
URL: https://github.com/apache/incubator-tubemq/pull/133
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
erienniu opened a new pull request #31:
URL: https://github.com/apache/incubator-tubemq-website/pull/31
[TUBEMQ-207] [website] Translate error_code.md
This is an automated message from the Apache Git Service.
To respond to th
zhenjunMa opened a new pull request #134:
URL: https://github.com/apache/incubator-tubemq/pull/134
use ThreadUtil.sleep replace Thread.sleep to avoid too many try/catch
except we need to do something by process this exception
-
zhenjunMa opened a new pull request #135:
URL: https://github.com/apache/incubator-tubemq/pull/135
use ThreadUtil.sleep replace Thread.sleep to avoid too many try/catch
except we need to do something by process this exception
-
gosonzhang merged pull request #30:
URL: https://github.com/apache/incubator-tubemq-website/pull/30
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
gosonzhang merged pull request #31:
URL: https://github.com/apache/incubator-tubemq-website/pull/31
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
gosonzhang commented on pull request #31:
URL:
https://github.com/apache/incubator-tubemq-website/pull/31#issuecomment-639956270
Thanks @erienniu
This is an automated message from the Apache Git Service.
To respond to the m
netroby commented on pull request #133:
URL: https://github.com/apache/incubator-tubemq/pull/133#issuecomment-639959933
https://search.maven.org/artifact/com.sleepycat/je
Version 7.3.7 missing from public MVN repository.
So shall we upgrade to public release version?
The onl
gosonzhang commented on pull request #133:
URL: https://github.com/apache/incubator-tubemq/pull/133#issuecomment-639960440
The download path is changed, I'll fixed!
--
netroby commented on pull request #133:
URL: https://github.com/apache/incubator-tubemq/pull/133#issuecomment-639961147
As an opensource project. we should carefully handle third party dependency.
Should not depends on company self-hosted Maven Repository.
There is no guarated safe an
gosonzhang commented on pull request #133:
URL: https://github.com/apache/incubator-tubemq/pull/133#issuecomment-639961154
I submitted this issue to resolve this question:
https://issues.apache.org/jira/projects/TUBEMQ/issues/TUBEMQ-217?filter=allopenissues
---
gosonzhang commented on pull request #133:
URL: https://github.com/apache/incubator-tubemq/pull/133#issuecomment-639962153
Yes, is there any good way?
At the beginning, the system requires users to download these third-party
components, such as proto buffer and je, to allow users to
netroby commented on pull request #133:
URL: https://github.com/apache/incubator-tubemq/pull/133#issuecomment-639962933
Replace 7.3.7 with a valid download repository is an tempory resolution.
For long term maintain prespective. upgrade it to public maven repository
may be the only way
gosonzhang commented on pull request #133:
URL: https://github.com/apache/incubator-tubemq/pull/133#issuecomment-639964624
I agree with you, but if the new version is directly introduced into the
system as a white mouse without verification, it is likely to affect the
external services pro
netroby closed pull request #133:
URL: https://github.com/apache/incubator-tubemq/pull/133
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
netroby commented on pull request #133:
URL: https://github.com/apache/incubator-tubemq/pull/133#issuecomment-639965023
I am not ask merge this PR, i am just explain it . This pull reuqest can be
hold on. and wait for next time if somebody like to made some improvment .
I 'll close
gosonzhang opened a new pull request #136:
URL: https://github.com/apache/incubator-tubemq/pull/136
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
aloyszhang commented on pull request #136:
URL: https://github.com/apache/incubator-tubemq/pull/136#issuecomment-639987491
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log o
aloyszhang merged pull request #135:
URL: https://github.com/apache/incubator-tubemq/pull/135
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Technoboy- merged pull request #132:
URL: https://github.com/apache/incubator-tubemq/pull/132
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
cku328 opened a new pull request #32:
URL: https://github.com/apache/incubator-tubemq-website/pull/32
I configured the metadata of title for each markdown page.
This is an automated message from the Apache Git Service.
To res
dockerzhang opened a new pull request #33:
URL: https://github.com/apache/incubator-tubemq-website/pull/33
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dockerzhang closed pull request #33:
URL: https://github.com/apache/incubator-tubemq-website/pull/33
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
cku328 opened a new pull request #137:
URL: https://github.com/apache/incubator-tubemq/pull/137
- Replacing valueOf() with a static method of parseXXX()
- Remove unnecessary 'String.valueOf()' call in
BrokerAdminServlet#adminGetMemStoreStatisInfo
[Details on
JIRA.](https://issues
Technoboy- opened a new pull request #34:
URL: https://github.com/apache/incubator-tubemq-website/pull/34
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
Technoboy- closed pull request #34:
URL: https://github.com/apache/incubator-tubemq-website/pull/34
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dockerzhang opened a new pull request #35:
URL: https://github.com/apache/incubator-tubemq-website/pull/35
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dockerzhang closed pull request #35:
URL: https://github.com/apache/incubator-tubemq-website/pull/35
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
viviel opened a new pull request #138:
URL: https://github.com/apache/incubator-tubemq/pull/138
Fixed unnecessary method calls such as String.valueOf ()
For exmple:
```
String.valueOf(inputTopicName).trim();
change to
inputTopicName.trim();
```
```
String.valu
gosonzhang commented on pull request #34:
URL:
https://github.com/apache/incubator-tubemq-website/pull/34#issuecomment-640323576
+1
This is an automated message from the Apache Git Service.
To respond to the message, please
Technoboy- merged pull request #138:
URL: https://github.com/apache/incubator-tubemq/pull/138
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Technoboy- merged pull request #137:
URL: https://github.com/apache/incubator-tubemq/pull/137
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
gosonzhang merged pull request #136:
URL: https://github.com/apache/incubator-tubemq/pull/136
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
gosonzhang opened a new pull request #36:
URL: https://github.com/apache/incubator-tubemq-website/pull/36
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
guangxuCheng commented on pull request #34:
URL:
https://github.com/apache/incubator-tubemq-website/pull/34#issuecomment-640346802
@Technoboy- we should add the download entrance on the homepage of the
website，and also provide a Chinese download page
guangxuCheng commented on a change in pull request #35:
URL:
https://github.com/apache/incubator-tubemq-website/pull/35#discussion_r436444695
##
File path: docs/en-us/quick_start.md
##
@@ -33,23 +45,32 @@ If you want to use local `protoc` executable, you can
change the config
guangxuCheng commented on a change in pull request #35:
URL:
https://github.com/apache/incubator-tubemq-website/pull/35#discussion_r436444852
##
File path: docs/zh-cn/quick_start.md
##
@@ -1,51 +1,70 @@
-## 准备工作
+## 编译和构建
+### 准备工作
-- Java 1.7 或 1.8(Java 9 及以上，未经测试验证)
-- Mav
guangxuCheng commented on pull request #35:
URL:
https://github.com/apache/incubator-tubemq-website/pull/35#issuecomment-640348714
blocked by #34
This is an automated message from the Apache Git Service.
To respond to the m
guangxuCheng commented on a change in pull request #36:
URL:
https://github.com/apache/incubator-tubemq-website/pull/36#discussion_r436445599
##
File path: site_config/docs.js
##
@@ -46,6 +46,10 @@ export default {
title: 'Console introduction',
link:
guangxuCheng commented on a change in pull request #32:
URL:
https://github.com/apache/incubator-tubemq-website/pull/32#discussion_r436446645
##
File path: docs/en-us/architecture.md
##
@@ -1,3 +1,7 @@
+---
+title: Architecture - Apache TubeMQ
+---
Review comment:
