[GitHub] twill pull request #67: (TWILL-61) Fix to allow higher attempts to relaunch ...

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/67#discussion_r174644467 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterMain.java --- @@ -170,45 +167,7 @@ private

[jira] [Commented] (TWILL-61) Second launch attempt of AM always failed

[ https://issues.apache.org/jira/browse/TWILL-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399632#comment-16399632 ] ASF GitHub Bot commented on TWILL-61: - Github user chtyim commented on a diff in the pull request:

[jira] [Commented] (TWILL-61) Second launch attempt of AM always failed

[ https://issues.apache.org/jira/browse/TWILL-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399626#comment-16399626 ] ASF GitHub Bot commented on TWILL-61: - Github user anew commented on a diff in the pull request:

[jira] [Commented] (TWILL-61) Second launch attempt of AM always failed

[ https://issues.apache.org/jira/browse/TWILL-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399625#comment-16399625 ] ASF GitHub Bot commented on TWILL-61: - Github user anew commented on a diff in the pull request:

[GitHub] twill pull request #67: (TWILL-61) Fix to allow higher attempts to relaunch ...

Github user anew commented on a diff in the pull request: https://github.com/apache/twill/pull/67#discussion_r174643542 --- Diff: twill-zookeeper/src/main/java/org/apache/twill/zookeeper/ZKOperations.java --- @@ -281,6 +286,73 @@ public void onFailure(Throwable t) {

[GitHub] twill pull request #67: (TWILL-61) Fix to allow higher attempts to relaunch ...

Github user anew commented on a diff in the pull request: https://github.com/apache/twill/pull/67#discussion_r174643070 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterMain.java --- @@ -170,45 +167,7 @@ private

[jira] [Commented] (TWILL-61) Second launch attempt of AM always failed

[ https://issues.apache.org/jira/browse/TWILL-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399593#comment-16399593 ] ASF GitHub Bot commented on TWILL-61: - Github user anew commented on a diff in the pull request:

[GitHub] twill pull request #67: (TWILL-61) Fix to allow higher attempts to relaunch ...

Github user anew commented on a diff in the pull request: https://github.com/apache/twill/pull/67#discussion_r174639182 --- Diff: twill-core/src/main/java/org/apache/twill/internal/AbstractTwillService.java --- @@ -216,11 +217,52 @@ protected final void shutDown() throws Exception

[jira] [Commented] (TWILL-61) Second launch attempt of AM always failed

[ https://issues.apache.org/jira/browse/TWILL-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399591#comment-16399591 ] ASF GitHub Bot commented on TWILL-61: - Github user anew commented on a diff in the pull request:

[GitHub] twill pull request #67: (TWILL-61) Fix to allow higher attempts to relaunch ...

Github user anew commented on a diff in the pull request: https://github.com/apache/twill/pull/67#discussion_r174638923 --- Diff: twill-core/src/main/java/org/apache/twill/internal/AbstractTwillService.java --- @@ -216,11 +217,52 @@ protected final void shutDown() throws Exception

[jira] [Commented] (TWILL-61) Second launch attempt of AM always failed

[ https://issues.apache.org/jira/browse/TWILL-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399531#comment-16399531 ] ASF GitHub Bot commented on TWILL-61: - Github user chtyim commented on the issue:

[GitHub] twill issue #67: (TWILL-61) Fix to allow higher attempts to relaunch the app...

Github user chtyim commented on the issue: https://github.com/apache/twill/pull/67 I've addressed the comments and fixed one more issue (one deletion failure, if the node not exist, we can just go ahead and recreate the node instead of failing). Also refactored the callback

[jira] [Commented] (TWILL-61) Second launch attempt of AM always failed

[ https://issues.apache.org/jira/browse/TWILL-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399527#comment-16399527 ] ASF GitHub Bot commented on TWILL-61: - Github user chtyim commented on a diff in the pull request:

[GitHub] twill pull request #67: (TWILL-61) Fix to allow higher attempts to relaunch ...

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/67#discussion_r174626043 --- Diff: twill-core/src/main/java/org/apache/twill/internal/kafka/client/SimpleKafkaPublisher.java --- @@ -159,30 +159,37 @@ public void

[jira] [Commented] (TWILL-61) Second launch attempt of AM always failed

[ https://issues.apache.org/jira/browse/TWILL-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399470#comment-16399470 ] ASF GitHub Bot commented on TWILL-61: - Github user chtyim commented on a diff in the pull request:

[GitHub] twill pull request #67: (TWILL-61) Fix to allow higher attempts to relaunch ...

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/67#discussion_r174618874 --- Diff: twill-core/src/main/java/org/apache/twill/internal/AbstractTwillService.java --- @@ -216,11 +217,52 @@ protected final void shutDown() throws

[jira] [Commented] (TWILL-61) Second launch attempt of AM always failed

[ https://issues.apache.org/jira/browse/TWILL-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399466#comment-16399466 ] ASF GitHub Bot commented on TWILL-61: - Github user chtyim commented on a diff in the pull request:

[GitHub] twill pull request #67: (TWILL-61) Fix to allow higher attempts to relaunch ...

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/67#discussion_r174618395 --- Diff: twill-core/src/main/java/org/apache/twill/internal/AbstractTwillService.java --- @@ -216,11 +217,52 @@ protected final void shutDown() throws

[jira] [Commented] (TWILL-61) Second launch attempt of AM always failed

[ https://issues.apache.org/jira/browse/TWILL-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399465#comment-16399465 ] ASF GitHub Bot commented on TWILL-61: - Github user chtyim commented on a diff in the pull request:

[GitHub] twill pull request #67: (TWILL-61) Fix to allow higher attempts to relaunch ...

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/67#discussion_r174618087 --- Diff: twill-core/src/main/java/org/apache/twill/internal/AbstractTwillService.java --- @@ -216,11 +217,52 @@ protected final void shutDown() throws

[GitHub] twill pull request #67: (TWILL-61) Fix to allow higher attempts to relaunch ...

Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/67#discussion_r174617783 --- Diff: twill-core/src/main/java/org/apache/twill/internal/AbstractTwillService.java --- @@ -216,11 +217,52 @@ protected final void shutDown() throws

[jira] [Commented] (TWILL-61) Second launch attempt of AM always failed

[ https://issues.apache.org/jira/browse/TWILL-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399462#comment-16399462 ] ASF GitHub Bot commented on TWILL-61: - Github user chtyim commented on a diff in the pull request:

[jira] [Commented] (TWILL-61) Second launch attempt of AM always failed

[ https://issues.apache.org/jira/browse/TWILL-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399162#comment-16399162 ] ASF GitHub Bot commented on TWILL-61: - Github user anew commented on a diff in the pull request:

[jira] [Commented] (TWILL-61) Second launch attempt of AM always failed

[ https://issues.apache.org/jira/browse/TWILL-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399160#comment-16399160 ] ASF GitHub Bot commented on TWILL-61: - Github user anew commented on a diff in the pull request:

[jira] [Commented] (TWILL-61) Second launch attempt of AM always failed

[ https://issues.apache.org/jira/browse/TWILL-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399163#comment-16399163 ] ASF GitHub Bot commented on TWILL-61: - Github user anew commented on a diff in the pull request:

[jira] [Commented] (TWILL-61) Second launch attempt of AM always failed

[ https://issues.apache.org/jira/browse/TWILL-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399161#comment-16399161 ] ASF GitHub Bot commented on TWILL-61: - Github user anew commented on a diff in the pull request:

[GitHub] twill pull request #67: (TWILL-61) Fix to allow higher attempts to relaunch ...

Github user anew commented on a diff in the pull request: https://github.com/apache/twill/pull/67#discussion_r174580690 --- Diff: twill-core/src/main/java/org/apache/twill/internal/kafka/client/SimpleKafkaPublisher.java --- @@ -159,30 +159,37 @@ public void changed(BrokerService

[GitHub] twill pull request #67: (TWILL-61) Fix to allow higher attempts to relaunch ...

Github user anew commented on a diff in the pull request: https://github.com/apache/twill/pull/67#discussion_r174571435 --- Diff: twill-core/src/main/java/org/apache/twill/internal/AbstractTwillService.java --- @@ -216,11 +217,52 @@ protected final void shutDown() throws Exception

[GitHub] twill pull request #67: (TWILL-61) Fix to allow higher attempts to relaunch ...

Github user anew commented on a diff in the pull request: https://github.com/apache/twill/pull/67#discussion_r174571807 --- Diff: twill-core/src/main/java/org/apache/twill/internal/AbstractTwillService.java --- @@ -216,11 +217,52 @@ protected final void shutDown() throws Exception

[GitHub] twill pull request #67: (TWILL-61) Fix to allow higher attempts to relaunch ...

Github user anew commented on a diff in the pull request: https://github.com/apache/twill/pull/67#discussion_r174583711 --- Diff: twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterMain.java --- @@ -165,9 +168,47 @@ private

[GitHub] twill pull request #67: (TWILL-61) Fix to allow higher attempts to relaunch ...

Github user anew commented on a diff in the pull request: https://github.com/apache/twill/pull/67#discussion_r174573795 --- Diff: twill-core/src/main/java/org/apache/twill/internal/AbstractTwillService.java --- @@ -216,11 +217,52 @@ protected final void shutDown() throws Exception