Github user piaosama commented on a diff in the pull request:
https://github.com/apache/twill/pull/71#discussion_r225824325
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/yarn/YarnUtils.java ---
@@ -202,6 +223,28 @@ public static void cloneHaNnCredentials
Github user piaosama commented on a diff in the pull request:
https://github.com/apache/twill/pull/71#discussion_r225817747
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/yarn/YarnUtils.java ---
@@ -202,6 +223,28 @@ public static void cloneHaNnCredentials
Github user piaosama commented on the issue:
https://github.com/apache/twill/pull/71
add new code, modify the code as you suggested and add the HAutils method
judgement.
---
Github user piaosama commented on a diff in the pull request:
https://github.com/apache/twill/pull/71#discussion_r223182267
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/yarn/YarnUtils.java ---
@@ -345,6 +388,28 @@ private static FileSystem
getFileSystem
Github user piaosama commented on a diff in the pull request:
https://github.com/apache/twill/pull/71#discussion_r223181503
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/yarn/YarnUtils.java ---
@@ -202,6 +223,28 @@ public static void cloneHaNnCredentials
Github user piaosama commented on a diff in the pull request:
https://github.com/apache/twill/pull/71#discussion_r223181498
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/yarn/YarnUtils.java ---
@@ -202,6 +223,28 @@ public static void cloneHaNnCredentials
Github user piaosama commented on a diff in the pull request:
https://github.com/apache/twill/pull/71#discussion_r223181489
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/yarn/YarnUtils.java ---
@@ -202,6 +223,28 @@ public static void cloneHaNnCredentials
Github user piaosama commented on a diff in the pull request:
https://github.com/apache/twill/pull/71#discussion_r223181337
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/yarn/YarnUtils.java ---
@@ -72,7 +77,23 @@
HADOOP_26
}
- private
GitHub user piaosama opened a pull request:
https://github.com/apache/twill/pull/71
TWILL-262 YarnUtils#cloneHaNnCredentials uses DFSUtil#getHaNnRpcAddresses,
which is removed from DFSUtils from hadoop-2.8
TWILL-262 YarnUtils#cloneHaNnCredentials uses DFSUtil#getHaNnRpcAddresses
Github user piaosama closed the pull request at:
https://github.com/apache/twill/pull/70
---
Github user piaosama commented on the issue:
https://github.com/apache/twill/pull/70
seems code style check failed,will try to open a new pull request
---
GitHub user piaosama opened a pull request:
https://github.com/apache/twill/pull/70
TWILL-262 YarnUtils#cloneHaNnCredentials uses DFSUtil#getHaNnRpcAddresses,
which is removed from DFSUtils from hadoop-2.8
TWILL-262 YarnUtils#cloneHaNnCredentials uses DFSUtil#getHaNnRpcAddresses
12 matches
Mail list logo