Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/40
Thank @hsaputra for the review. Merging the change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user hsaputra commented on the issue:
https://github.com/apache/twill/pull/40
+1 for correctness
I just added suggestion of style of return null vs declarative check by
caller to determine if logging collection is disabled.
---
If your project is set up for it, you ca
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/40
@hsaputra Thanks for the review. Please see my replies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user hsaputra commented on the issue:
https://github.com/apache/twill/pull/40
I did a pass and add some comments. Mostly kind of concern of multiple ways
to check whether log collection is disabled or not.
---
If your project is set up for it, you can reply to this email and h
