Re: twill dependency on logback

2017-02-10 Thread Martin Serrano
Twill should not impose a logging framework on the runnables IMO. I think slf4j is reasonable and since twill is handling the Kafka hookup, the runnables themselves need know nothing about logback correct? I think ultimately, how logging is handled should be pluggable. In our use case, the

Re: twill dependency on logback

2017-02-10 Thread Henry Saputra
Ah ok, thanks for clarifying your concern, Martin. Twill currently do need the logback in the runnables running the YARN to be able to collect the logs and publish them to the embedded Kafka. So in your case, you want to use slf4j but backed up by log4j binding instead for client and runnables?

Re: twill dependency on logback

2017-02-10 Thread Martin Serrano
Terence, Correct, I don't want to use logback on the client side. slf4j is okay -- we ship with the log4j binding. In the twill containers, the AM doesn't matter for me, but the runnables does.So yes, flexibility for the runnables is important. Thanks, Martin On 02/10/2017 01:56 AM,

Re: twill dependency on logback

2017-02-08 Thread Martin Serrano
Any chance we could slack/chat on this tomorrow? Sent from my Verizon Wireless 4G LTE DROID On Feb 8, 2017 8:09 PM, Henry Saputra wrote: But the logback dependency should be included in the jar packaging that YARN client sends for Twill ApplicationMaster. Are you seeing

twill dependency on logback

2017-02-08 Thread Martin Serrano
Hey Devs, It seems like the twill project goes through some pain to try to insulate itself logging frameworks. I see use of the slf4j API. However, the appmaster code has a dependency on logback via the org.apache.twill.internal.logging.Loggings class. The appmaster will not start up