[GitHub] [incubator-uniffle] jerqi commented on issue #239: [Problem] RssUtils#transIndexDataToSegments should consider the length of the data file

2022-10-21 Thread GitBox
jerqi commented on issue #239: URL: https://github.com/apache/incubator-uniffle/issues/239#issuecomment-1287569816 > > When we encounter EOFException, we have read some index data, we can return the data that we have read. > > DataSkippableReadHandler#readShuffleData return

[GitHub] [incubator-uniffle] jerqi commented on issue #133: [Improvement] Netty replace Grpc on data transfer

2022-10-21 Thread GitBox
jerqi commented on issue #133: URL: https://github.com/apache/incubator-uniffle/issues/133#issuecomment-1287011268 This poc is based on Uber RSS netty implement, it's better that we can compare the Ali's rss netty implement, Uber's rss netty implement and other RSS netty implement. --

[GitHub] [incubator-uniffle] jerqi commented on issue #133: [Improvement] Netty replace Grpc on data transfer

2022-10-21 Thread GitBox
jerqi commented on issue #133: URL: https://github.com/apache/incubator-uniffle/issues/133#issuecomment-1287007372 Commit ID: 4463b80deacbcd47ddc151f8d7750d1e5f035077 git apply patch1 [netty1.txt](https://github.com/apache/incubator-uniffle/files/9839621/netty1.txt) git

[ANNOUNCE] Apache Uniffle (incubating) 0.6.0 available

2022-10-21 Thread roryqi
Hi all, Apache Uniffle (incubating) Team is glad to announce the new release of Apache Uniffle (incubating) 0.6.0. Apache Uniffle (incubating) is a high performance, general purpose Remote Shuffle Service for distributed compute engines like Apache Spark < https://spark.apache.org/>, Apache

[GitHub] [incubator-uniffle] zuston commented on issue #263: [Improvement] Introduce statestore of shuffle-server for upgrading quickly

2022-10-21 Thread GitBox
zuston commented on issue #263: URL: https://github.com/apache/incubator-uniffle/issues/263#issuecomment-1286699375 Agree with u about its big change. So I revisit this problem do we really need a statestore? Make a big change just for upgrading? Actually the shuffle-servers' state only

[GitHub] [incubator-uniffle] jerqi commented on issue #263: [Improvement] Introduce statestore of shuffle-server for upgrading quickly

2022-10-21 Thread GitBox
jerqi commented on issue #263: URL: https://github.com/apache/incubator-uniffle/issues/263#issuecomment-1286686537 > > OK, I think it's more convenient that we shutdown the shuffle servers for a period of time. All the applications use ess , we upgrade all the shuffle servers, we let the

[GitHub] [incubator-uniffle] zuston commented on issue #263: [Improvement] Introduce statestore of shuffle-server for upgrading quickly

2022-10-21 Thread GitBox
zuston commented on issue #263: URL: https://github.com/apache/incubator-uniffle/issues/263#issuecomment-1286680008 > OK, I think it's more convenient that we shutdown the shuffle servers for a period of time. All the applications use ess , we upgrade all the shuffle servers, we let the

[GitHub] [incubator-uniffle] jerqi commented on issue #263: [Improvement] Introduce statestore of shuffle-server for upgrading quickly

2022-10-21 Thread GitBox
jerqi commented on issue #263: URL: https://github.com/apache/incubator-uniffle/issues/263#issuecomment-1286663174 OK, I think it's more convenient that we shutdown the shuffle servers for a period of time. All the applications use ess , we upgrade all the shuffle servers, we let the

[GitHub] [incubator-uniffle] jerqi commented on issue #211: [Feature] User's resources quota

2022-10-21 Thread GitBox
jerqi commented on issue #211: URL: https://github.com/apache/incubator-uniffle/issues/211#issuecomment-1286660371 @smallzhongfeng If you add some extra interfaces, you should describe them in the document. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-uniffle] jerqi commented on issue #198: [Problem] Inconsistent blocks when reading shuffle data

2022-10-21 Thread GitBox
jerqi commented on issue #198: URL: https://github.com/apache/incubator-uniffle/issues/198#issuecomment-1286657466 > we also met this error, but in fact it's rpc timeout, when we in compose client mode, the one time read exception will be catch, then try to read other storage , and if the

[GitHub] [incubator-uniffle] zuston commented on issue #133: [Improvement] Netty replace Grpc on data transfer

2022-10-21 Thread GitBox
zuston commented on issue #133: URL: https://github.com/apache/incubator-uniffle/issues/133#issuecomment-1286648067 > > What is the progress of this proposal, maybe I can join the development? > > We only have some POC code. I don't have much time, if you like , I can assign this

[GitHub] [incubator-uniffle] jerqi commented on issue #133: [Improvement] Netty replace Grpc on data transfer

2022-10-21 Thread GitBox
jerqi commented on issue #133: URL: https://github.com/apache/incubator-uniffle/issues/133#issuecomment-1286644879 > What is the progress of this proposal, maybe I can join the development? We only have some POC code. I don't have much time, if you like , I can assign this issue to

[GitHub] [incubator-uniffle] zuston commented on issue #198: [Problem] Inconsistent blocks when reading shuffle data

2022-10-21 Thread GitBox
zuston commented on issue #198: URL: https://github.com/apache/incubator-uniffle/issues/198#issuecomment-1286630064 > suggest to change the code to raise another exception for this case to void the confuse +1. -- This is an automated message from the Apache Git Service. To

[GitHub] [incubator-uniffle] zuston closed issue #273: [Bug] Get shuffle result failed caused by concurrent calls to registerShuffle

2022-10-21 Thread GitBox
zuston closed issue #273: [Bug] Get shuffle result failed caused by concurrent calls to registerShuffle URL: https://github.com/apache/incubator-uniffle/issues/273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-uniffle] Gustfh commented on issue #198: [Problem] Inconsistent blocks when reading shuffle data

2022-10-21 Thread GitBox
Gustfh commented on issue #198: URL: https://github.com/apache/incubator-uniffle/issues/198#issuecomment-1286616973 we also met this error, but in fact it's rpc timeout, when we in compose client mode, the one time read exception will be catch, then try to read other storage , and if the

[GitHub] [incubator-uniffle] leixm commented on issue #133: [Improvement] Netty replace Grpc on data transfer

2022-10-21 Thread GitBox
leixm commented on issue #133: URL: https://github.com/apache/incubator-uniffle/issues/133#issuecomment-1286556123 What is the progress of this proposal, maybe I can join the development? -- This is an automated message from the Apache Git Service. To respond to the message, please log