[GitHub] [incubator-uniffle] advancedxy commented on issue #133: [Improvement] Netty replace Grpc on data transfer

2023-02-09 Thread via GitHub
advancedxy commented on issue #133: URL: https://github.com/apache/incubator-uniffle/issues/133#issuecomment-1425313049 > After offline discussion, we should involve more people to participate in this issue. @zuston @leixm @advancedxy @kaijchen @smallzhongfeng @xianjingfeng Maybe we

[GitHub] [incubator-uniffle] leixm commented on issue #587: [Subtask] [Netty] Coordinator supports netty

2023-02-09 Thread via GitHub
leixm commented on issue #587: URL: https://github.com/apache/incubator-uniffle/issues/587#issuecomment-1425304873 The communication protocols of the coordinator and the shuffleserver are different, which looks a bit weird. Of course, this is not a high priority. -- This is an automated

[GitHub] [incubator-uniffle] jerqi commented on issue #587: [Subtask] [Netty] Coordinator supports netty

2023-02-09 Thread via GitHub
jerqi commented on issue #587: URL: https://github.com/apache/incubator-uniffle/issues/587#issuecomment-1425300964 Why do we need modify the coordinator? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-uniffle] leixm opened a new issue, #587: [Subtask] [Netty] Coordinator supports netty

2023-02-09 Thread via GitHub
leixm opened a new issue, #587: URL: https://github.com/apache/incubator-uniffle/issues/587 ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) ### Search before asking - [X] I have

[GitHub] [incubator-uniffle] leixm opened a new issue, #586: [Subtask] [Netty] Support ShuffleServer to use off-heap memory to manage shuffle data

2023-02-09 Thread via GitHub
leixm opened a new issue, #586: URL: https://github.com/apache/incubator-uniffle/issues/586 ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) ### Search before asking - [X] I have

[GitHub] [incubator-uniffle] leixm opened a new issue, #584: [Subtask] [Netty] Implementation of client connection management

2023-02-09 Thread via GitHub
leixm opened a new issue, #584: URL: https://github.com/apache/incubator-uniffle/issues/584 ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) ### Search before asking - [X] I have

[GitHub] [incubator-uniffle] leixm opened a new issue, #585: [Subtask] [Netty] Startup script supports setting MaxDirectMemory.

2023-02-09 Thread via GitHub
leixm opened a new issue, #585: URL: https://github.com/apache/incubator-uniffle/issues/585 ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) ### Search before asking - [X] I have

[GitHub] [incubator-uniffle] leixm opened a new issue, #583: [Subtask] [Netty] Rewrite the serialization/deserialization protocol of each interface in ShuffleServer

2023-02-09 Thread via GitHub
leixm opened a new issue, #583: URL: https://github.com/apache/incubator-uniffle/issues/583 ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) ### Search before asking - [X] I have

[GitHub] [incubator-uniffle] leixm opened a new issue, #582: [Subtask] [Netty] Implementation of basic framework.

2023-02-09 Thread via GitHub
leixm opened a new issue, #582: URL: https://github.com/apache/incubator-uniffle/issues/582 ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) ### Search before asking - [X] I have

[GitHub] [incubator-uniffle] kaijchen commented on issue #551: [Improvement][Style] add autolink to issues in PR title and commit msg

2023-02-09 Thread via GitHub
kaijchen commented on issue #551: URL: https://github.com/apache/incubator-uniffle/issues/551#issuecomment-1425283306 Hi everyone, I've edited existing open PR titles (to show examples to new PR). How do you think?

[GitHub] [incubator-uniffle] leixm commented on issue #133: [Improvement] Netty replace Grpc on data transfer

2023-02-09 Thread via GitHub
leixm commented on issue #133: URL: https://github.com/apache/incubator-uniffle/issues/133#issuecomment-1425280933 > > https://github.com/leixm/incubator-uniffle/tree/netty_poc_2 > > Great. Do you think is it possible to submit an WIP pr now? > > > It is still in the

[GitHub] [incubator-uniffle] zuston commented on issue #133: [Improvement] Netty replace Grpc on data transfer

2023-02-09 Thread via GitHub
zuston commented on issue #133: URL: https://github.com/apache/incubator-uniffle/issues/133#issuecomment-1425279519 > After offline discussion, we should involve more people to participate in this issue. @zuston @leixm @advancedxy @kaijchen @smallzhongfeng @xianjingfeng Maybe we should

[GitHub] [incubator-uniffle] leixm commented on issue #133: [Improvement] Netty replace Grpc on data transfer

2023-02-09 Thread via GitHub
leixm commented on issue #133: URL: https://github.com/apache/incubator-uniffle/issues/133#issuecomment-1425277668 > After offline discussion, we should involve more people to participate in this issue. @zuston @leixm @advancedxy @kaijchen @smallzhongfeng @xianjingfeng Maybe we should

Re: 回复: [DISCUSS] Release 0.7.0

2023-02-09 Thread roryqi
https://github.com/apache/incubator-uniffle/issues/410 https://github.com/apache/incubator-uniffle/issues/462 We have finished all issues which we need. Xianjin Ye 于2023年2月3日周五 14:35写道: > Thanks for your help. > > For features to be included, I'd like to include this umbrella task: >

[GitHub] [incubator-uniffle] jerqi closed issue #410: [FEATURE] Support the hot reload of coordinator's configuration `rss.coordinator.shuffle.nodes.max`

2023-02-09 Thread via GitHub
jerqi closed issue #410: [FEATURE] Support the hot reload of coordinator's configuration `rss.coordinator.shuffle.nodes.max` URL: https://github.com/apache/incubator-uniffle/issues/410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-uniffle] kaijchen commented on issue #133: [Improvement] Netty replace Grpc on data transfer

2023-02-09 Thread via GitHub
kaijchen commented on issue #133: URL: https://github.com/apache/incubator-uniffle/issues/133#issuecomment-1425247639 Let's create a new branch such as `netty` for this feature. So we can collaborate on it before it's ready to be merged into master. -- This is an automated message from

[GitHub] [incubator-uniffle] smallzhongfeng commented on issue #133: [Improvement] Netty replace Grpc on data transfer

2023-02-09 Thread via GitHub
smallzhongfeng commented on issue #133: URL: https://github.com/apache/incubator-uniffle/issues/133#issuecomment-1425244146 > After offline discussion, we should involve more people to participate in this issue. @zuston @leixm @advancedxy @kaijchen @smallzhongfeng @xianjingfeng Maybe we

[GitHub] [incubator-uniffle] wangao1236 commented on issue #564: [Improvement] Integration test for operator

2023-02-09 Thread via GitHub
wangao1236 commented on issue #564: URL: https://github.com/apache/incubator-uniffle/issues/564#issuecomment-1425194196 Okay, I'll take care of that. Assign me the issue please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-uniffle] kaijchen opened a new issue, #580: [Umbrella] Improve CI

2023-02-09 Thread via GitHub
kaijchen opened a new issue, #580: URL: https://github.com/apache/incubator-uniffle/issues/580 ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) ### Search before asking - [X] I have

[GitHub] [incubator-uniffle] Gustfh commented on issue #133: [Improvement] Netty replace Grpc on data transfer

2023-02-09 Thread via GitHub
Gustfh commented on issue #133: URL: https://github.com/apache/incubator-uniffle/issues/133#issuecomment-1425135692 recently, we also working on this feature, since we found the problem is on the grpc, later we will share our result about this poc. +1 for the regular meeting --

[GitHub] [incubator-uniffle] xianjingfeng closed issue #575: [Improvement] Refactor ComposedClientReadHandler

2023-02-09 Thread via GitHub
xianjingfeng closed issue #575: [Improvement] Refactor ComposedClientReadHandler URL: https://github.com/apache/incubator-uniffle/issues/575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [incubator-uniffle] xianjingfeng commented on issue #133: [Improvement] Netty replace Grpc on data transfer

2023-02-09 Thread via GitHub
xianjingfeng commented on issue #133: URL: https://github.com/apache/incubator-uniffle/issues/133#issuecomment-1425103269 > After offline discussion, we should involve more people to participate in this issue. @zuston @leixm @advancedxy @kaijchen @smallzhongfeng @xianjingfeng Maybe we

[GitHub] [incubator-uniffle] jerqi commented on issue #133: [Improvement] Netty replace Grpc on data transfer

2023-02-09 Thread via GitHub
jerqi commented on issue #133: URL: https://github.com/apache/incubator-uniffle/issues/133#issuecomment-1425100400 After offline discussion, we should involve more people to participate in this issue. @zuston @leixm @advancedxy @kaijchen @smallzhongfeng @xianjingfeng Maybe we should have

[GitHub] [incubator-uniffle] kaijchen opened a new issue, #576: Flaky Test: AppBalanceSelectStorageStrategyTest#storageCounterMulThreadTest

2023-02-09 Thread via GitHub
kaijchen opened a new issue, #576: URL: https://github.com/apache/incubator-uniffle/issues/576 ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) ### Search before asking - [X] I have

[GitHub] [incubator-uniffle] kaijchen opened a new issue, #575: [Improvement] Refactor ComposedClientReadHandler

2023-02-09 Thread via GitHub
kaijchen opened a new issue, #575: URL: https://github.com/apache/incubator-uniffle/issues/575 ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) ### Search before asking - [X] I have

[GitHub] [incubator-uniffle] advancedxy commented on issue #133: [Improvement] Netty replace Grpc on data transfer

2023-02-09 Thread via GitHub
advancedxy commented on issue #133: URL: https://github.com/apache/incubator-uniffle/issues/133#issuecomment-1424198644 > https://github.com/leixm/incubator-uniffle/tree/netty_poc_2 Great. Do you think is it possible to submit an WIP pr now? > It is still in the development

[GitHub] [incubator-uniffle] jerqi commented on issue #133: [Improvement] Netty replace Grpc on data transfer

2023-02-09 Thread via GitHub
jerqi commented on issue #133: URL: https://github.com/apache/incubator-uniffle/issues/133#issuecomment-1424051399 > Can I add some ISSUE? Let's get involved. @jerqi Yes, you can. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-uniffle] leixm commented on issue #133: [Improvement] Netty replace Grpc on data transfer

2023-02-09 Thread via GitHub
leixm commented on issue #133: URL: https://github.com/apache/incubator-uniffle/issues/133#issuecomment-1424048433 Can I add some ISSUE? Let's get involved. @jerqi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-uniffle] leixm commented on issue #133: [Improvement] Netty replace Grpc on data transfer

2023-02-09 Thread via GitHub
leixm commented on issue #133: URL: https://github.com/apache/incubator-uniffle/issues/133#issuecomment-1424048330 Can I add some ISSUE? Let's get involved. @jerqi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-uniffle] leixm commented on issue #133: [Improvement] Netty replace Grpc on data transfer

2023-02-09 Thread via GitHub
leixm commented on issue #133: URL: https://github.com/apache/incubator-uniffle/issues/133#issuecomment-1424046583 > Hi, @leixm xianming, has this issue already been addressed in your internal prod env? Do you any ETA for the PR to be uploaded? It is still in the development process and

[GitHub] [incubator-uniffle] leixm commented on issue #133: [Improvement] Netty replace Grpc on data transfer

2023-02-09 Thread via GitHub
leixm commented on issue #133: URL: https://github.com/apache/incubator-uniffle/issues/133#issuecomment-1424046227 > addressed It is still in the development process and has not been applied to the production environment. -- This is an automated message from the Apache Git

[GitHub] [incubator-uniffle] leixm commented on issue #133: [Improvement] Netty replace Grpc on data transfer

2023-02-09 Thread via GitHub
leixm commented on issue #133: URL: https://github.com/apache/incubator-uniffle/issues/133#issuecomment-1424044217 @advancedxy @jerqi I have uploaded a POC code, which is helpful to alleviate the problem of FullGC, but many places still need to be optimized.

[GitHub] [incubator-uniffle] xianjingfeng closed issue #567: [FEATURE] Add the shuffle server metric about used memory when reading

2023-02-09 Thread via GitHub
xianjingfeng closed issue #567: [FEATURE] Add the shuffle server metric about used memory when reading URL: https://github.com/apache/incubator-uniffle/issues/567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-uniffle] advancedxy closed issue #571: [Improvement] Don't delete base storage path if it's already an empty dir

2023-02-09 Thread via GitHub
advancedxy closed issue #571: [Improvement] Don't delete base storage path if it's already an empty dir URL: https://github.com/apache/incubator-uniffle/issues/571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL