Re: [VOTE] Release Apache Uniffle (Incubating) 0.7.0-rc1

2023-02-28 Thread roryqi
Have you run uts in your local machine? I run `mvn package` twice. They all failed. Maybe we should cherrypick test fix to branch 0.7. https://github.com/apache/incubator-uniffle/issues/408 https://github.com/apache/incubator-uniffle/issues/612

[GitHub] [incubator-uniffle] kaijchen commented on issue #611: [Umbrella] Release 0.7.0

2023-02-28 Thread via GitHub
kaijchen commented on issue #611: URL: https://github.com/apache/incubator-uniffle/issues/611#issuecomment-1449355357 > I forgot deleting the pom.xml.versionBackup files, so do I need to cancel this vote and revote the rc-2 version after fixing? @kaijchen Yes, but no need to be hurry

[GitHub] [incubator-uniffle] zuston commented on issue #611: [Umbrella] Release 0.7.0

2023-02-28 Thread via GitHub
zuston commented on issue #611: URL: https://github.com/apache/incubator-uniffle/issues/611#issuecomment-1449290098 I forgot deleting the pom.xml.versionBackup files, so do I need to cancel this vote and revote the rc-2 version after fixing? @kaijchen -- This is an automated message fro

[GitHub] [incubator-uniffle] xumanbu commented on issue #584: [Subtask] [Netty] Implementation of client connection management

2023-02-28 Thread via GitHub
xumanbu commented on issue #584: URL: https://github.com/apache/incubator-uniffle/issues/584#issuecomment-1449274893 assgin for me,thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [incubator-uniffle] xumanbu commented on issue #640: [Subtask] [Netty] Metrics system

2023-02-28 Thread via GitHub
xumanbu commented on issue #640: URL: https://github.com/apache/incubator-uniffle/issues/640#issuecomment-1449274785 assgin for me,thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [incubator-uniffle] xumanbu commented on issue #593: [Subtask] [Netty] Writer support off heap memory to compress data

2023-02-28 Thread via GitHub
xumanbu commented on issue #593: URL: https://github.com/apache/incubator-uniffle/issues/593#issuecomment-1449274720 assgin for me,thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [incubator-uniffle] xumanbu commented on issue #592: [Subtask] [Netty] Reader support off heap memory to decompress data

2023-02-28 Thread via GitHub
xumanbu commented on issue #592: URL: https://github.com/apache/incubator-uniffle/issues/592#issuecomment-1449274597 assgin for me,thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [VOTE] Release Apache Uniffle (Incubating) 0.7.0-rc1

2023-02-28 Thread Kaijie Chen
-1 (non-binding) There is a unexpected `pom.xml.versionsBackup` in the source directory. And the version inside it is `0.7.0-snapshot`. I have checked: * Download links, checksums and PGP signatures are valid. * Source code distributions have correct names matching the current release. * Release

[GitHub] [incubator-uniffle] zuston commented on issue #611: [Umbrella] Release 0.7.0

2023-02-28 Thread via GitHub
zuston commented on issue #611: URL: https://github.com/apache/incubator-uniffle/issues/611#issuecomment-1449263234 > Minor versions are not like patch versions, the changes may be too many to describe in a sentence. Maybe you can include the link to the (proposed) release note instead w

[GitHub] [incubator-uniffle] kaijchen commented on issue #611: [Umbrella] Release 0.7.0

2023-02-28 Thread via GitHub
kaijchen commented on issue #611: URL: https://github.com/apache/incubator-uniffle/issues/611#issuecomment-1449254328 > I have sent the vote email to [dev@uniffle.apache.org](mailto:dev@uniffle.apache.org) Thanks. > Comparing to 0.6.1, a bug fix of memory leak is included:

[GitHub] [incubator-uniffle] zuston commented on issue #611: [Umbrella] Release 0.7.0

2023-02-28 Thread via GitHub
zuston commented on issue #611: URL: https://github.com/apache/incubator-uniffle/issues/611#issuecomment-1449246199 I have sent the vote email to dev@uniffle.apache.org cc @kaijchen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[VOTE] Release Apache Uniffle (Incubating) 0.7.0-rc1

2023-02-28 Thread Junfan Zhang
Hi Uniffle community, This is a call for vote to release Apache Uniffle (Incubating) 0.7.0-rc1 Comparing to 0.6.1, a bug fix of memory leak is included: https://github.com/apache/incubator-uniffle/compare/v0.6.1..v0.7.0-rc1 The git tag to be voted upon: https://github.com/apache/incubato

[GitHub] [incubator-uniffle] smallzhongfeng opened a new issue, #671: [FEATURE] Metrics of the number of apps submitted by users

2023-02-28 Thread via GitHub
smallzhongfeng opened a new issue, #671: URL: https://github.com/apache/incubator-uniffle/issues/671 ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) ### Search before asking - [X] I have

[GitHub] [incubator-uniffle] zuston commented on issue #611: [Umbrella] Release 0.7.0

2023-02-28 Thread via GitHub
zuston commented on issue #611: URL: https://github.com/apache/incubator-uniffle/issues/611#issuecomment-1448048877 > @zuston please refer to the task list in [#611 (comment)](https://github.com/apache/incubator-uniffle/issues/611#issue-1587121237) Thanks. I will do remaining tasks t

[GitHub] [incubator-uniffle] kaijchen commented on issue #611: [Umbrella] Release 0.7.0

2023-02-28 Thread via GitHub
kaijchen commented on issue #611: URL: https://github.com/apache/incubator-uniffle/issues/611#issuecomment-1448045651 @zuston please refer to the task list in https://github.com/apache/incubator-uniffle/issues/611#issue-1587121237 -- This is an automated message from the Apache Git Servi

[GitHub] [incubator-uniffle] zuston commented on issue #611: [Umbrella] Release 0.7.0

2023-02-28 Thread via GitHub
zuston commented on issue #611: URL: https://github.com/apache/incubator-uniffle/issues/611#issuecomment-1448039890 > > I have drafted the release. could you help check this? https://github.com/apache/incubator-uniffle/releases/tag/untagged-e126c5971ca7ac9e1d6d @advancedxy @kaijchen @jerqi

[GitHub] [incubator-uniffle] zuston commented on issue #611: [Umbrella] Release 0.7.0

2023-02-28 Thread via GitHub
zuston commented on issue #611: URL: https://github.com/apache/incubator-uniffle/issues/611#issuecomment-1448020415 > > You don't change the pom.xml 's version t0 0.7.0. > > Got it. Updated -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-uniffle] zuston commented on issue #611: [Umbrella] Release 0.7.0

2023-02-28 Thread via GitHub
zuston commented on issue #611: URL: https://github.com/apache/incubator-uniffle/issues/611#issuecomment-1448003064 > You don't change the pom.xml 's version t0 0.7.0. Got it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [incubator-uniffle] jerqi commented on issue #611: [Umbrella] Release 0.7.0

2023-02-28 Thread via GitHub
jerqi commented on issue #611: URL: https://github.com/apache/incubator-uniffle/issues/611#issuecomment-1447983319 You don't change the pom.xml 's version t0 0.7.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-uniffle] kaijchen commented on issue #611: [Umbrella] Release 0.7.0

2023-02-28 Thread via GitHub
kaijchen commented on issue #611: URL: https://github.com/apache/incubator-uniffle/issues/611#issuecomment-1447978666 > ```shell > git checkout branch-0.7 > git tag v0.7.0 > git push origin v0.7.0 > ``` Tag should be `v0.7.0-rc1` in this case. -- This is an automated me

[GitHub] [incubator-uniffle] kaijchen commented on issue #611: [Umbrella] Release 0.7.0

2023-02-28 Thread via GitHub
kaijchen commented on issue #611: URL: https://github.com/apache/incubator-uniffle/issues/611#issuecomment-1447976268 > Done https://dist.apache.org/repos/dist/dev/incubator/uniffle/ Artifacts looks good, but version should be changed to `0.7.0`. -- This is an automated message fro

[GitHub] [incubator-uniffle] zuston commented on issue #611: [Umbrella] Release 0.7.0

2023-02-28 Thread via GitHub
zuston commented on issue #611: URL: https://github.com/apache/incubator-uniffle/issues/611#issuecomment-1447934138 > Yes, the tarball should be named apache-uniffle-0.7.0-rc1-incubating-src.tar.gz. Edit:apache-uniffle-0.7.0-incubating-src.tar.gz under 0.7.0-rc1 directory. Done ht

[GitHub] [incubator-uniffle] kaijchen commented on issue #611: [Umbrella] Release 0.7.0

2023-02-28 Thread via GitHub
kaijchen commented on issue #611: URL: https://github.com/apache/incubator-uniffle/issues/611#issuecomment-1447881555 You can also refer to https://kvrocks.apache.org/community/create-a-release -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-uniffle] zuston commented on issue #611: [Umbrella] Release 0.7.0

2023-02-28 Thread via GitHub
zuston commented on issue #611: URL: https://github.com/apache/incubator-uniffle/issues/611#issuecomment-1447880317 I heard from @jerqi that we just need to do source release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [incubator-uniffle] kaijchen commented on issue #611: [Umbrella] Release 0.7.0

2023-02-28 Thread via GitHub
kaijchen commented on issue #611: URL: https://github.com/apache/incubator-uniffle/issues/611#issuecomment-1447880341 > OK. Could you tell me the steps or commands to build this tarball? Since we are making source release only, you can use `git-archive` to create the tarball.

[GitHub] [incubator-uniffle] zuston commented on issue #611: [Umbrella] Release 0.7.0

2023-02-28 Thread via GitHub
zuston commented on issue #611: URL: https://github.com/apache/incubator-uniffle/issues/611#issuecomment-1447875995 > > Yes, the tarball should be named apache-uniffle-0.7.0-rc1-incubating-src.tar.gz. > > OK. Could you tell me the steps or commands to build this tarball? And h

[GitHub] [incubator-uniffle] kaijchen commented on issue #611: [Umbrella] Release 0.7.0

2023-02-28 Thread via GitHub
kaijchen commented on issue #611: URL: https://github.com/apache/incubator-uniffle/issues/611#issuecomment-1447874973 > Yes, the tarball should be named apache-uniffle-0.7.0-rc1-incubating-src.tar.gz. Sorry, no `rc1` in tarball name, see https://dist.apache.org/repos/dist/dev/incuba

[GitHub] [incubator-uniffle] zuston commented on issue #611: [Umbrella] Release 0.7.0

2023-02-28 Thread via GitHub
zuston commented on issue #611: URL: https://github.com/apache/incubator-uniffle/issues/611#issuecomment-1447873914 > Yes, the tarball should be named apache-uniffle-0.7.0-rc1-incubating-src.tar.gz. OK. Could you tell me the steps or commands to build this tarball? -- This is an

[GitHub] [incubator-uniffle] kaijchen commented on issue #611: [Umbrella] Release 0.7.0

2023-02-28 Thread via GitHub
kaijchen commented on issue #611: URL: https://github.com/apache/incubator-uniffle/issues/611#issuecomment-1447870259 > OK. Do we need to set a rc version? No, because if everything goes well, `0.7.0-rc1` will become `0.7.0`. > Besides, does the source tarballs need to upload t

[GitHub] [incubator-uniffle] zuston commented on issue #611: [Umbrella] Release 0.7.0

2023-02-28 Thread via GitHub
zuston commented on issue #611: URL: https://github.com/apache/incubator-uniffle/issues/611#issuecomment-1447868959 Besides, does the source tarballs need to upload to apache svn before voting this release? -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [incubator-uniffle] zuston commented on issue #611: [Umbrella] Release 0.7.0

2023-02-28 Thread via GitHub
zuston commented on issue #611: URL: https://github.com/apache/incubator-uniffle/issues/611#issuecomment-1447863740 > > I have drafted the release. could you help check this? https://github.com/apache/incubator-uniffle/releases/tag/untagged-e126c5971ca7ac9e1d6d @advancedxy @kaijchen @jerqi

[GitHub] [incubator-uniffle] kaijchen commented on issue #611: [Umbrella] Release 0.7.0

2023-02-28 Thread via GitHub
kaijchen commented on issue #611: URL: https://github.com/apache/incubator-uniffle/issues/611#issuecomment-1447854115 > I have drafted the release. could you help check this? https://github.com/apache/incubator-uniffle/releases/tag/untagged-e126c5971ca7ac9e1d6d @advancedxy @kaijchen @jerqi

[GitHub] [incubator-uniffle] jerqi commented on issue #611: [Umbrella] Release 0.7.0

2023-02-28 Thread via GitHub
jerqi commented on issue #611: URL: https://github.com/apache/incubator-uniffle/issues/611#issuecomment-1447853878 > I have drafted the release. could you help check this? https://github.com/apache/incubator-uniffle/releases/tag/untagged-e126c5971ca7ac9e1d6d @advancedxy @kaijchen @jerqi

[GitHub] [incubator-uniffle] zuston commented on issue #611: [Umbrella] Release 0.7.0

2023-02-28 Thread via GitHub
zuston commented on issue #611: URL: https://github.com/apache/incubator-uniffle/issues/611#issuecomment-1447845524 I have drafted the release. could you help check this? https://github.com/apache/incubator-uniffle/releases/tag/untagged-e126c5971ca7ac9e1d6d @advancedxy @kaijchen @jerqi

[GitHub] [incubator-uniffle] crain-cn commented on issue #645: [Improvement] feat(operator): Support for custom initialization parameters.

2023-02-28 Thread via GitHub
crain-cn commented on issue #645: URL: https://github.com/apache/incubator-uniffle/issues/645#issuecomment-1447839178 > > > > From the issue description, I don't quite get what you want to archive. The main.go for controller and webhook already handles flag parsing. > > >

[GitHub] [incubator-uniffle] zuston commented on issue #611: [Umbrella] Release 0.7.0

2023-02-28 Thread via GitHub
zuston commented on issue #611: URL: https://github.com/apache/incubator-uniffle/issues/611#issuecomment-144643 > Hi, what's the status of 0.7.0 release? I'm working on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on