UNOMI-149 set default threshold of the strategy to 1
Project: http://git-wip-us.apache.org/repos/asf/incubator-unomi/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-unomi/commit/4213752d Tree: http://git-wip-us.apache.org/repos/asf/incubator-unomi/tree/4213752d Diff: http://git-wip-us.apache.org/repos/asf/incubator-unomi/diff/4213752d Branch: refs/heads/master Commit: 4213752df2f7a196647ee93526c88b0ea27cf915 Parents: c3d36bc Author: Taybou <benterki.ta...@gmail.com> Authored: Thu Feb 8 15:02:18 2018 +0100 Committer: Taybou <benterki.ta...@gmail.com> Committed: Thu Feb 8 15:02:18 2018 +0100 ---------------------------------------------------------------------- .../unomi/services/sorts/ScorePersonalizationStrategy.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-unomi/blob/4213752d/services/src/main/java/org/apache/unomi/services/sorts/ScorePersonalizationStrategy.java ---------------------------------------------------------------------- diff --git a/services/src/main/java/org/apache/unomi/services/sorts/ScorePersonalizationStrategy.java b/services/src/main/java/org/apache/unomi/services/sorts/ScorePersonalizationStrategy.java index 1109435..c9e22cd 100644 --- a/services/src/main/java/org/apache/unomi/services/sorts/ScorePersonalizationStrategy.java +++ b/services/src/main/java/org/apache/unomi/services/sorts/ScorePersonalizationStrategy.java @@ -41,7 +41,7 @@ public class ScorePersonalizationStrategy implements PersonalizationStrategy { Integer threshold = (Integer) personalizationRequest.getStrategyOptions().get("threshold"); if (threshold == null) { - threshold = 0; + threshold = 1; } for (PersonalizationService.PersonalizedContent personalizedContent : personalizationRequest.getContents()) { @@ -67,13 +67,11 @@ public class ScorePersonalizationStrategy implements PersonalizationStrategy { } } - boolean matchesAtLeastOneCondition = false; if (personalizedContent.getFilters() != null) { for (PersonalizationService.Filter filter : personalizedContent.getFilters()) { Condition condition = filter.getCondition(); if (condition != null && condition.getConditionTypeId() != null) { if (profileService.matchCondition(condition, profile, session)) { - matchesAtLeastOneCondition = true; if (filter.getProperties().get("score") != null) { score += (int) filter.getProperties().get("score"); } else { @@ -83,7 +81,7 @@ public class ScorePersonalizationStrategy implements PersonalizationStrategy { } } } - if (matchesAtLeastOneCondition && score >= threshold) { + if (score >= threshold) { t.put(personalizedContent.getId(), score); sortedContent.add(personalizedContent.getId()); }
