[GitHub] usergrid pull request: Update hasNextPage to return boolean

2016-01-07 Thread michaelarusso
Github user michaelarusso commented on the pull request: https://github.com/apache/usergrid/pull/375#issuecomment-169827910 @wooliet Thanks for the contribution! I'll merge this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] usergrid pull request: Update hasNextPage to return boolean

2016-01-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/usergrid/pull/375 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] usergrid pull request: Update hasNextPage to return boolean

2015-09-16 Thread shawnfeldman
Github user shawnfeldman commented on the pull request: https://github.com/apache/usergrid/pull/375#issuecomment-140809244 secret...@apache.org. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] usergrid pull request: Update hasNextPage to return boolean

2015-09-16 Thread shawnfeldman
Github user shawnfeldman commented on the pull request: https://github.com/apache/usergrid/pull/375#issuecomment-140809169 can you sign and email the icla to the secretary? https://www.apache.org/licenses/icla.txt --- If your project is set up for it, you can reply to this email and

[GitHub] usergrid pull request: Update hasNextPage to return boolean

2015-09-15 Thread wooliet
Github user wooliet commented on the pull request: https://github.com/apache/usergrid/pull/375#issuecomment-140440464 Sorry, I have not signed anything. The readme mentions "For larger PRs" and I didn't think this would be considered a large pull request. Using `!!` is concise

[GitHub] usergrid pull request: Update hasNextPage to return boolean

2015-09-04 Thread shawnfeldman
Github user shawnfeldman commented on the pull request: https://github.com/apache/usergrid/pull/375#issuecomment-137789667 why not just say (_next !== null && _next !== undefined) not sure we want to propagate !! around also have you signed an apache icla? --- If your proje

[GitHub] usergrid pull request: Update hasNextPage to return boolean

2015-09-04 Thread wooliet
GitHub user wooliet opened a pull request: https://github.com/apache/usergrid/pull/375 Update hasNextPage to return boolean The `hasNextPage` method returned evaluation of its `_next` property, which is either a string or null. Method documentation says it returns a boolean v