I'm +1 on the CommonsLogLogChute in Engine.
It probably also makes sense for ServetLogChute to be in Engine. I'm
not too worried about compile time dependencies as our build scripts
handles these automatically.
We should try to keep the list of dependencies up to date as that will
help people c
Hey folks,
So, the only reason CommonsLogLogSystem ever went into VelocityTools
was that that was the path of least resistance for me at the time. I
wanted it to be released soon, and Velocity releases didn't happen
soon.
Now that we are up to speed, more or less, the reality is that
CommonsLog
You got me there. I thought put will be called a lot less than get but you
are right,
we should be able to remove it as well.
-- Lei
Nathan Bubna wrote:
>
> On 4/2/07, Lei Gu <[EMAIL PROTECTED]> wrote:
>>
>> Hi Nathan,
>> a) In the original code, a new copy of string image is constructed and
>>
On 4/2/07, Lei Gu <[EMAIL PROTECTED]> wrote:
Hi Nathan,
a) In the original code, a new copy of string image is constructed and
returned as part of the token, which is part of a node. When we cache
templates, these nodes stay in memory forever or until the template itself
is booted from the cache
We are on JDK 1.5 and the memory model works for DCL if combined with
volatile key word. In JDK 1.5, volatile key word guarantees two threads see
the variable in the same order with the same value.
Thanks.
-- Lei
Velocity - Dev mailing list-2 wrote:
>
>
> [
> https://issues.apache.org/jir
[
https://issues.apache.org/jira/browse/VELOCITY-536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12486096
]
Nathan Bubna commented on VELOCITY-536:
---
Looking more carefully at this, rather than trusting my first look..
Hi Nathan,
a) In the original code, a new copy of string image is constructed and
returned as part of the token, which is part of a node. When we cache
templates, these nodes stay in memory forever or until the template itself
is booted from the cache. We improved this by checking against the stri
[
https://issues.apache.org/jira/browse/VELOCITY-536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12486071
]
Nathan Bubna commented on VELOCITY-536:
---
But the DCL'ed block only needs to happen once per instance. Isn't
[
https://issues.apache.org/jira/browse/VELOCITY-536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12486066
]
Christopher Schultz commented on VELOCITY-536:
--
"Even though those instructions may be re-ordered, the
[
https://issues.apache.org/jira/browse/VELOCITY-536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12486047
]
Will Glass-Husain commented on VELOCITY-536:
Quick question on the patch. Should the null check be ins
[
https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12486064
]
Nathan Bubna commented on VELOCITY-223:
---
Those are great numbers! I'm excited to have a such potential boos
[
https://issues.apache.org/jira/browse/VELOCITY-536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12486062
]
Nathan Bubna commented on VELOCITY-536:
---
"The only potential problem is that the VM or JIT could re-order ins
[
https://issues.apache.org/jira/browse/VELOCITY-536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12486059
]
Christopher Schultz commented on VELOCITY-536:
--
Regarding double-checked locking (DCL), it is typicall
When it's ready. :-)
So far, I've just seen one or two bug reports (plus one "known
issue"). VELOCITY-532 seems the most significant. Be nice to see if
there are any more in the next week or two.
Personally, I'm in favor of fixing this and re-releasing in the next month.
WILL
On 4/2/07, Dem
[
https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12486048
]
Will Glass-Husain commented on VELOCITY-223:
Nice catch.
One quick question. Have you tried the Strin
[
https://issues.apache.org/jira/browse/VELOCITY-536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12486054
]
Nathan Bubna commented on VELOCITY-536:
---
Null check? I see boolean checks...
Anyway, double-checked locking
[
https://issues.apache.org/jira/browse/VELOCITY-536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12486045
]
Will Glass-Husain commented on VELOCITY-536:
Incidentally, there's no need to attach the complete files
[
https://issues.apache.org/jira/browse/VELOCITY-536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12486043
]
Will Glass-Husain commented on VELOCITY-536:
Thanks for this as well. More info at:
http://www.mail-a
[
https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12486042
]
Will Glass-Husain commented on VELOCITY-223:
Thanks, Lei!
Also, see:
http://www.mail-archive.com/dev@v
[
https://issues.apache.org/jira/browse/VELOCITY-536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lei Gu updated VELOCITY-536:
Attachment: 536-patch.txt
Patch fixes
> Velocity Engine throws NullPointer Exception when two people cli
[
https://issues.apache.org/jira/browse/VELOCITY-536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lei Gu updated VELOCITY-536:
Attachment: VelocimacroProxy.java
ASTDirective.java
ASTSetDirective.java
Velocity Engine throws NullPointer Exception when two people click on the same
page at the same time for the first time
---
Key: VELOCITY-536
URL:
[
https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lei Gu updated VELOCITY-223:
Attachment: VelocityCharStream.java
StringImagePool.java
Issue number 223, Velocity Engin
[
https://issues.apache.org/jira/browse/VELOCITY-223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lei Gu updated VELOCITY-223:
Attachment: 223-patch.txt
Patch fixes for issue 223
Issue number 223, Velocity Engine uses excessive amo
Hi,
Considering the discovered bugs after the release of 1.5, when can we expect
a next minor release?
Thank you,
D.
--
View this message in context:
http://www.nabble.com/Next-minor-release---1.5.1--tf3505173.html#a9789041
Sent from the Velocity - Dev mailing list archive at Nabble.com.
--
25 matches
Mail list logo