Re: svn commit: r593549 - in /velocity/tools/branches/2.x/src/main/java/org/apache/velocity/tools: generic/ValueParser.java view/ParameterTool.java

2007-11-09 Thread Nathan Bubna
hey Claude, i'm not sure if you're done with this or if it's still in process, but there's a few problems so far (in decreasing order of importance): - ant test is now failing - the hasSubKeys things doesn't make any sense to me - stylistically, the practice for Velocity projects is to keep braces

Re: svn commit: r593549 - in /velocity/tools/branches/2.x/src/main/java/org/apache/velocity/tools: generic/ValueParser.java view/ParameterTool.java

2007-11-09 Thread Claude Brisson
Le vendredi 09 novembre 2007 à 16:15 +0100, Claude Brisson a écrit : > ValueParser now has protected get/setAllowSubkeys() boolean methods. > > The default value of allowSubkey shoud be the value of deprecatedMode, > but I'm not really sure of how this should be done. But I'm sure Nathan > will be

Re: svn commit: r593549 - in /velocity/tools/branches/2.x/src/main/java/org/apache/velocity/tools: generic/ValueParser.java view/ParameterTool.java

2007-11-09 Thread Claude Brisson
ValueParser now has protected get/setAllowSubkeys() boolean methods. The default value of allowSubkey shoud be the value of deprecatedMode, but I'm not really sure of how this should be done. But I'm sure Nathan will be of some help here. Also, since ValueParser is used internally by the Tool.con