[engine] StringEscapeUtils

2019-03-07 Thread Claude Brisson
The StringEscapeUtils class is moving from commons-lang3 to commons-text. We are using it in several reference insertion event handlers (to escape xml, javascript or html). For now the commons-lang3 version is still there, but deprecated. We should address this in engine 2.1, but how? 1) ju

Re: [engine] StringEscapeUtils

2019-03-07 Thread Nathan Bubna
Hmm. I may not be the best to weigh in on this, as i never used event handlers for escaping. I always preferred the direct, explicit control of escaping via tools, and trusted myself (YMMV) not to forget escaping anywhere important. I'll definitely agree that we shouldn't shade. I'm perfectly comf

[jira] [Commented] (VELOCITY-909) Refactor property key names

2019-03-07 Thread Claude Brisson (JIRA)
[ https://issues.apache.org/jira/browse/VELOCITY-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16787028#comment-16787028 ] Claude Brisson commented on VELOCITY-909: - See [the current proposal|https://v

[jira] [Created] (VELOCITY-910) Deprecation of org.apache.commons.lang3.StringEscapeUtils

2019-03-07 Thread Claude Brisson (JIRA)
Claude Brisson created VELOCITY-910: --- Summary: Deprecation of org.apache.commons.lang3.StringEscapeUtils Key: VELOCITY-910 URL: https://issues.apache.org/jira/browse/VELOCITY-910 Project: Velocity