[GitHub] [velocity-engine] michael-o edited a comment on pull request #3: Added the S3Resource Loader to pull velocity templates from Amazon S3…

2021-03-03 Thread GitBox
michael-o edited a comment on pull request #3: URL: https://github.com/apache/velocity-engine/pull/3#issuecomment-787081368 > > > To quote Michael on the dev list: > > > This seems to be a very specific resource loader and shall be hosted outside of core. > > This coul

Re: [VOTE] Engine 2.3 RC1 Release quality

2021-03-03 Thread Claude Brisson
Thanks for the review, Henning. I found a little bug myself, I was considering putting it aside for the next release, but working on all JDKs seems an important goal. Even if Oracle licensing went somehow rogue... By the way, I like how most open source projects decided that JDK 8 was the norm

[GitHub] [velocity-engine] arkanovicz merged pull request #20: Fixes failing tests on JDK 11+

2021-03-03 Thread GitBox
arkanovicz merged pull request #20: URL: https://github.com/apache/velocity-engine/pull/20 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[VOTE] Engine 2.3 RC2 Release quality

2021-03-03 Thread Claude Brisson
The Velocity Engine 2.3 RC2 is available since February 27. Main changes in this release: + New spring-velocity-support module, containing Spring framework Velocity Engine integration classes. + Security fix: let SecureUberspector block methods on ClassLoader and subclasses. Changes from RC1

Re: [VOTE] Engine 2.3 RC2 Release quality

2021-03-03 Thread Claude Brisson
+1 for GA. On 21-03-03 13 h 29, Claude Brisson wrote: The Velocity Engine 2.3 RC2 is available since February 27. Main changes in this release: + New spring-velocity-support module, containing Spring framework Velocity Engine integration classes. + Security fix: let SecureUberspector block me

Re: [VOTE] Engine 2.3 RC2 Release quality

2021-03-03 Thread Nathan Bubna
+1 GA On Wed, Mar 3, 2021 at 4:29 AM Claude Brisson wrote: > The Velocity Engine 2.3 RC2 is available since February 27. > > Main changes in this release: > > + New spring-velocity-support module, containing Spring framework > Velocity Engine integration classes. > + Security fix: let SecureUber

Re: [VOTE] Engine 2.3 RC2 Release quality

2021-03-03 Thread Will Glass-Husain
+1 GA built and ran tests in both JDK 8 and 11 on Windows. WILL On Wed, Mar 3, 2021 at 8:07 AM Nathan Bubna wrote: > +1 GA > > On Wed, Mar 3, 2021 at 4:29 AM Claude Brisson > wrote: > > > The Velocity Engine 2.3 RC2 is available since February 27. > > > > Main changes in this release: > > > >

Re: [VOTE] Engine 2.3 RC2 Release quality

2021-03-03 Thread Henning Schmiedehausen
Builds on JDK 8, 11 and 15 for me on MacOS 11 [X] General Availability (GA) On Wed, Mar 3, 2021 at 4:29 AM Claude Brisson wrote: > The Velocity Engine 2.3 RC2 is available since February 27. > [...] > > Sources: > > * https://github.com/apache/velocity-engine/releases/tag/2.3-RC1 -RC2

Re: [VOTE] Engine 2.3 RC1 Release quality

2021-03-03 Thread Henning Schmiedehausen
No worries. I would not fully agree with "Java becoming legacy"; the Java programming language might, but the JVM ecosystem (especially with GraalVM) and all the new and exciting languages is not. Licensing IMHO is pretty straightforward: Use OpenJDK in its different flavors (usually the RHEL/Ubun

Re: [VOTE] Engine 2.3 RC1 Release quality

2021-03-03 Thread Claude Brisson
You're quite correct in distinguishing the JVM and the language. I'm not sure that Java (the language) and C++ are in the same problem space. I see Rust as a kind of new C++, but about the Java language, it's especially the growing wave of Kotlin that makes me think that the use of the Java la