Re: #set warning if null

2007-11-28 Thread Claude Brisson
Retrospectively, I agree with Christoph's proposals and semantic, but I also agree with Will that now that we have the "directive.set.null.allowed" configuration property, the whole debate seems deprecated. In the thext major Velocity version, this flag should default to true. But I found a bug in

Re: #set warning if null

2007-11-22 Thread Will Glass-Husain
I though we already did this for V. 1.5? (allow #set to accept null). But we left it off for backwards compatibility. Check the code. WILL On Nov 22, 2007 10:01 AM, <[EMAIL PROTECTED]> wrote: > Hi Claude, > > I originally proposed to allow the bang character in the > #set( $!bar = $!foo ) di

Re: #set warning if null

2007-11-22 Thread apache
Hi Claude, I originally proposed to allow the bang character in the #set( $!bar = $!foo ) directive to: a) avoid logging the null from $!foo (this is current behaviour when rendering foo) b) allowing setting the context to null with then bang in $!bar I sent a patch many years ago (was rejecte

Re: #set warning if null

2007-11-22 Thread Nathan Bubna
On Nov 22, 2007 6:30 AM, Claude Brisson <[EMAIL PROTECTED]> wrote: > Hi dev, > > I'd like to change the behaviour of #set($foo = $evaluates_to_null) > > The current behaviour is to log (debug loglevel) the message "RHS of > #set statement is null...". > > What I'd like to do: > > - set the logleve

#set warning if null

2007-11-22 Thread Claude Brisson
Hi dev, I'd like to change the behaviour of #set($foo = $evaluates_to_null) The current behaviour is to log (debug loglevel) the message "RHS of #set statement is null...". What I'd like to do: - set the loglevel of this message to warn - don't log anything if the left reference is quiet, as