Re: [VOTE] Engine 2.3 RC1 Release quality

2021-03-03 Thread Claude Brisson
You're quite correct in distinguishing the JVM and the language. I'm not sure that Java (the language) and C++ are in the same problem space. I see Rust as a kind of new C++, but about the Java language, it's especially the growing wave of Kotlin that makes me think that the use of the Java

Re: [VOTE] Engine 2.3 RC1 Release quality

2021-03-03 Thread Henning Schmiedehausen
No worries. I would not fully agree with "Java becoming legacy"; the Java programming language might, but the JVM ecosystem (especially with GraalVM) and all the new and exciting languages is not. Licensing IMHO is pretty straightforward: Use OpenJDK in its different flavors (usually the

Re: [VOTE] Engine 2.3 RC1 Release quality

2021-03-03 Thread Claude Brisson
Thanks for the review, Henning. I found a little bug myself, I was considering putting it aside for the next release, but working on all JDKs seems an important goal. Even if Oracle licensing went somehow rogue... By the way, I like how most open source projects decided that JDK 8 was the

Re: [VOTE] Engine 2.3 RC1 Release quality

2021-03-02 Thread Henning Schmiedehausen
Builds and passes all tests with AdoptOpenJDK 8 on MacOS 11. Fails tests on Java 11 and 15 (3 failures, all related to internal changes in the JDK and brittle tests) I am somewhat 0 on this release, I don't really want to hold it up or make Claude do another round. All the fixes (that make this

Re: [VOTE] Engine 2.3 RC1 Release quality

2021-03-02 Thread Thomas Mortagne
+1 for GA, I could not spot any problem when executing XWiki tests On Tue, Mar 2, 2021 at 6:48 AM Will Glass-Husain wrote: > > +1 GA. > > @greg - I had to cd into the "pom" directory for Velocity Master. > > WILL > > On Mon, Mar 1, 2021 at 4:48 PM Nathan Bubna wrote: > > > +1 GA > > > > On Mon,

Re: [VOTE] Engine 2.3 RC1 Release quality

2021-03-01 Thread Will Glass-Husain
+1 GA. @greg - I had to cd into the "pom" directory for Velocity Master. WILL On Mon, Mar 1, 2021 at 4:48 PM Nathan Bubna wrote: > +1 GA > > On Mon, Mar 1, 2021 at 8:06 AM Claude Brisson > wrote: > > > The Velocity Engine 2.3 RC1 is available since February 27. > > > > Main changes in this

Re: [VOTE] Engine 2.3 RC1 Release quality

2021-03-01 Thread Nathan Bubna
+1 GA On Mon, Mar 1, 2021 at 8:06 AM Claude Brisson wrote: > The Velocity Engine 2.3 RC1 is available since February 27. > > Main changes in this release: > > + New spring-velocity-support module, containing Spring framework > Velocity Engine integration classes. > + Security fix: let

Re: [VOTE] Engine 2.3 RC1 Release quality

2021-03-01 Thread Greg Huber
Just for the velocity-engine-core-2.3.jar, works ok for me. [x] General Availability (GA) Cheers Not sure if its my setup but I get for $ git clone --branch velocity-master-4 https://github.com/apache/velocity-master.git $ cd velocity-master $ mvn install [INFO] Scanning for

Re: [VOTE] Engine 2.3 RC1 Release quality

2021-03-01 Thread Claude Brisson
+1 On 21-03-01 17 h 06, Claude Brisson wrote: The Velocity Engine 2.3 RC1 is available since February 27. Main changes in this release: + New spring-velocity-support module, containing Spring framework Velocity Engine integration classes. + Security fix: let SecureUberspector block methods

[VOTE] Engine 2.3 RC1 Release quality

2021-03-01 Thread Claude Brisson
The Velocity Engine 2.3 RC1 is available since February 27. Main changes in this release: + New spring-velocity-support module, containing Spring framework Velocity Engine integration classes. + Security fix: let SecureUberspector block methods on ClassLoader and subclasses. Release notes: