[ 
https://issues.apache.org/jira/browse/VELTOOLS-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nathan Bubna resolved VELTOOLS-105.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 2.x
                   2.0

Fixed in both 1.x branch and in the trunk (2.x).  Thanks for finding and 
following up on this, Cott!

> MessageTool doesn't support MessageResources the same way Struts does in 
> terms of scoping
> -----------------------------------------------------------------------------------------
>
>                 Key: VELTOOLS-105
>                 URL: https://issues.apache.org/jira/browse/VELTOOLS-105
>             Project: Velocity Tools
>          Issue Type: Bug
>          Components: VelocityStruts
>    Affects Versions: 1.4, 2.0
>            Reporter: Cott Lang
>             Fix For: 2.0, 2.x
>
>         Attachments: MessageResourcesTool.patch1
>
>
> We have an application that, for various reasons, inserts it's own 
> MessageResources object into the Request in the RequestProcessor.
> We do not have message-resource defined in the struts config.
> This works fine in Struts, because Struts (at least 1.2.9)  defaults 'bundle' 
> to Globals.MESSAGES_KEY if it's null and checks the page, request, and 
> application scopes in that order (see TagUtils)
> StrutsUtils has similar behavior.  Unfortunately, MessageResourcesTool 
> prevents it from working because getResources() returns an error if 'bundle' 
> is null and there was not a MessageResources in the ServletContext. 
> I fixed this by simply changing MessageResourcesTool to return the locally 
> cached 'resources' object if 'bundle' is null and resources is not, but 
> otherwise to call StrutsUtils and let it find the MessageResources.  To be 
> completely compatible with Struts, it seems like StrutsUtils also needs to be 
> modified to check the page scope before the request scope.
> 2.0 is different, but looks like it would still suffer from this problem in 
> our application. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to