Re: svn commit: r593549 - in /velocity/tools/branches/2.x/src/main/java/org/apache/velocity/tools: generic/ValueParser.java view/ParameterTool.java

2007-11-14 Thread Nathan Bubna
On Nov 13, 2007 8:52 AM, Nathan Bubna <[EMAIL PROTECTED]> wrote: > On Nov 13, 2007 8:07 AM, Nathan Bubna <[EMAIL PROTECTED]> wrote: > > On Nov 13, 2007 3:46 AM, Claude Brisson <[EMAIL PROTECTED]> wrote: > > > Le lundi 12 novembre 2007 à 16:18 -0800, Nathan Bubna a écrit : > > > > > > > My feeling

Re: svn commit: r593549 - in /velocity/tools/branches/2.x/src/main/java/org/apache/velocity/tools: generic/ValueParser.java view/ParameterTool.java

2007-11-13 Thread Nathan Bubna
On Nov 13, 2007 8:07 AM, Nathan Bubna <[EMAIL PROTECTED]> wrote: > On Nov 13, 2007 3:46 AM, Claude Brisson <[EMAIL PROTECTED]> wrote: > > Le lundi 12 novembre 2007 à 16:18 -0800, Nathan Bubna a écrit : > > > > My feeling here is that although foo.int is a cool syntax, it has too > > > > many backw

Re: svn commit: r593549 - in /velocity/tools/branches/2.x/src/main/java/org/apache/velocity/tools: generic/ValueParser.java view/ParameterTool.java

2007-11-13 Thread Nathan Bubna
On Nov 13, 2007 3:46 AM, Claude Brisson <[EMAIL PROTECTED]> wrote: > Le lundi 12 novembre 2007 à 16:18 -0800, Nathan Bubna a écrit : > > ah. ok, looked closer at the latest version. looks good. thx. :) > > but now i have a new question... why the expandSingletons stuff? we > > don't expand them

Re: svn commit: r593549 - in /velocity/tools/branches/2.x/src/main/java/org/apache/velocity/tools: generic/ValueParser.java view/ParameterTool.java

2007-11-13 Thread Claude Brisson
Le lundi 12 novembre 2007 à 16:18 -0800, Nathan Bubna a écrit : > ah. ok, looked closer at the latest version. looks good. thx. :) > but now i have a new question... why the expandSingletons stuff? we > don't expand them for $params.foo, why should we expand them for > $params.foo.bar? > > i'm

Re: svn commit: r593549 - in /velocity/tools/branches/2.x/src/main/java/org/apache/velocity/tools: generic/ValueParser.java view/ParameterTool.java

2007-11-12 Thread Nathan Bubna
On Nov 12, 2007 3:13 PM, Claude Brisson <[EMAIL PROTECTED]> wrote: > Le lundi 12 novembre 2007 à 10:53 -0800, Nathan Bubna a écrit : > > it's not the name so much as how it's used. it looks to me like once > > it searches for subkey "foo", it won't even try to find subkey "bar" > > or "woogie" or

Re: svn commit: r593549 - in /velocity/tools/branches/2.x/src/main/java/org/apache/velocity/tools: generic/ValueParser.java view/ParameterTool.java

2007-11-12 Thread Claude Brisson
Le lundi 12 novembre 2007 à 10:53 -0800, Nathan Bubna a écrit : > it's not the name so much as how it's used. it looks to me like once > it searches for subkey "foo", it won't even try to find subkey "bar" > or "woogie" or whatever. either that's wrong or i'm missing > something? The "hasSubkeys

Re: svn commit: r593549 - in /velocity/tools/branches/2.x/src/main/java/org/apache/velocity/tools: generic/ValueParser.java view/ParameterTool.java

2007-11-12 Thread Nathan Bubna
On Nov 10, 2007 2:54 AM, Claude Brisson <[EMAIL PROTECTED]> wrote: > Le vendredi 09 novembre 2007 à 12:15 -0800, Nathan Bubna a écrit : > > - the hasSubKeys things doesn't make any sense to me > > Maybe the name isn't appropriate. What I call "subkey" is "foo" or "bar" > in "foo.bar". Feel free to

Re: svn commit: r593549 - in /velocity/tools/branches/2.x/src/main/java/org/apache/velocity/tools: generic/ValueParser.java view/ParameterTool.java

2007-11-10 Thread Claude Brisson
Le vendredi 09 novembre 2007 à 12:15 -0800, Nathan Bubna a écrit : > - the hasSubKeys things doesn't make any sense to me Maybe the name isn't appropriate. What I call "subkey" is "foo" or "bar" in "foo.bar". Feel free to rename anything, English is not my mother tongue... > i'm also curious abou

Re: svn commit: r593549 - in /velocity/tools/branches/2.x/src/main/java/org/apache/velocity/tools: generic/ValueParser.java view/ParameterTool.java

2007-11-09 Thread Nathan Bubna
hey Claude, i'm not sure if you're done with this or if it's still in process, but there's a few problems so far (in decreasing order of importance): - ant test is now failing - the hasSubKeys things doesn't make any sense to me - stylistically, the practice for Velocity projects is to keep braces

Re: svn commit: r593549 - in /velocity/tools/branches/2.x/src/main/java/org/apache/velocity/tools: generic/ValueParser.java view/ParameterTool.java

2007-11-09 Thread Claude Brisson
Le vendredi 09 novembre 2007 à 16:15 +0100, Claude Brisson a écrit : > ValueParser now has protected get/setAllowSubkeys() boolean methods. > > The default value of allowSubkey shoud be the value of deprecatedMode, > but I'm not really sure of how this should be done. But I'm sure Nathan > will be

Re: svn commit: r593549 - in /velocity/tools/branches/2.x/src/main/java/org/apache/velocity/tools: generic/ValueParser.java view/ParameterTool.java

2007-11-09 Thread Claude Brisson
ValueParser now has protected get/setAllowSubkeys() boolean methods. The default value of allowSubkey shoud be the value of deprecatedMode, but I'm not really sure of how this should be done. But I'm sure Nathan will be of some help here. Also, since ValueParser is used internally by the Tool.con