Re: Replace Facebook/Yoga with a new implementation.

2017-11-05 Thread 申远
Extremely busy coding for double 11 now. > 在 2017年11月5日,14:23,Adam Feng 写道: > > How's it going? We need to release a version as soon as Yoga is removed. > > Thanks. > Adam Feng > > On 12 Oct 2017, 10:37 PM +0800, 申远 , wrote: >> flex-grow is already

[GitHub] incubator-weex-site issue #2: [WEEX-86] Update documentation for contributio...

2017-11-05 Thread Hanks10100
Github user Hanks10100 commented on the issue: https://github.com/apache/incubator-weex-site/pull/2 This PR is already merged into master. ---

[jira] [Commented] (WEEX-86) Reorganize the structure of documents and website

2017-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/WEEX-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239844#comment-16239844 ] ASF GitHub Bot commented on WEEX-86: Github user Hanks10100 commented on the issue:

Re: the max-width for css-style should be taken into consideration when drawing text

2017-11-05 Thread xing zhang
It's related with the algorithm drawing text: consider width first, if the css width is not specified, (consider about max-width now ) then we use `infinite` width as it's width meassuring the height. But people may don't know it's text width , the max-width is set. In a words, calculate text

[jira] [Created] (WEEX-92) How to use playground

2017-11-05 Thread wei (JIRA)
wei created WEEX-92: --- Summary: How to use playground Key: WEEX-92 URL: https://issues.apache.org/jira/browse/WEEX-92 Project: Weex Issue Type: Task Components: iOS Affects Versions: 0.12

Re: Plugin development

2017-11-05 Thread Adam Feng
Hi, Again,  thanks for your contribution. Maybe I can answer the first question,   The PR title should be of the form [WEEX-][COMPONENT] Title, where is the relevant JIRA number, COMPONENT is one of the PR categories(android, iOS, jsfm, web, component, doc, website, example, test,

Re: Plugin development

2017-11-05 Thread Tiago Alves
Hi! Done! https://github.com/apache/incubator-weex-site/pull/8 :D I have a couple questions: - Why do all PR names start with [WEEX-86][doc]? Namely, what does [WEEX-86] mean? I think this explanation should be part of the contributing guide. - I couldn't quite get the android test plugin

[GitHub] incubator-weex-site issue #8: [WEEX-86][doc] Adds a guide on how to create a...

2017-11-05 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex-site/pull/8 @Hanks10100 Please have a review. ---

[jira] [Commented] (WEEX-86) Reorganize the structure of documents and website

2017-11-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/WEEX-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239563#comment-16239563 ] ASF GitHub Bot commented on WEEX-86: Github user cxfeng1 commented on the issue:

[GitHub] incubator-weex-site pull request #8: guide-feature-create-plugin

2017-11-05 Thread tralves
GitHub user tralves opened a pull request: https://github.com/apache/incubator-weex-site/pull/8 guide-feature-create-plugin Greetings, This PR adds the page "Create a plugin" to guide the user on the process of starting, developing, testing and deploying a plugin.

Re: Replace Facebook/Yoga with a new implementation.

2017-11-05 Thread Adam Feng
How's it going? We need to release a version as soon as Yoga is removed. Thanks. Adam Feng On 12 Oct 2017, 10:37 PM +0800, 申远 , wrote: > flex-grow is already supported by flex shorthand, and it’s possible to > support flex-shrink in later version. > While, flex-basis is

Re: the max-width for css-style should be taken into consideration when drawing text

2017-11-05 Thread Adam Feng
Thanks for your contribution,  I have seen the pull request and reviewed the code,  it looked good to me,   can `max-height` also be supported? Thanks. Adam Feng On 5 Nov 2017, 12:22 PM +0800, xing zhang , wrote: >     Hi , I open an issue for support max-width in

Re: Plugin development

2017-11-05 Thread Adam Feng
Hi, Tiago, Thanks for your contribution! You can follow the new contribution guide[1](which is being reviewed and will be merged soon) to improve the documentation. [1]  https://github.com/cxfeng1/incubator-weex-site/blob/6a04e077e896709c5797ad30d9a31632a8e0a193/source/contributing.md Thanks.