You are right, I have renamed it to *Online Editor*, which is less
confusing.
Best Regards,
YorkShen
申远
Jan Piotrowski 于2019年8月7日周三 下午9:30写道:
> Thanks a lot.
>
> The only remaining thing here confusing might now be the duplication
> of "Playground" in the navigation as
>
Thanks, both of you.
In this case, I suggest we solve the problem under following procedure:
1. Remove the dependencies of danger-code_style_validation, then I can
merge the PR.
2. Publish it to somewhere( npm or other places ) with a different name
and a new version, then create a
>
> Thanks for your detailed reply.
>
> The license of the code itself is fine in my case. I think publish it to
> npm with a different name maybe a better solution. I will spend some time
> to do it.
>
You are right, only code format task in my PR is relied on third-party
code.I have removed the code of code format task. So you can merge the PR
now.
Thanks for your advice.
York Shen 于2019年8月7日周三 下午3:56写道:
> Correct me if I am wrong.
>
> It looks like you are relying on third-party code only
Thanks a lot.
The only remaining thing here confusing might now be the duplication
of "Playground" in the navigation as
https://weex.apache.org/tools/dotwe.html also uses that word.
J
Am Mi., 7. Aug. 2019 um 06:35 Uhr schrieb York Shen :
>
> I have update the website [1], which takes a little
As far as I am aware ASF rules only apply to code included in the
releases - what you do to build or test your code is not really
relevant to these requirements.
But obviously you should follow the licences of the code itself, which
seems fine in this case.
Of course if you want to keep that in
Correct me if I am wrong.
It looks like you are relying on third-party code only for code_format task in
TravisCI. If this is the case, I suggest you remove code_format task in your PR
first, as everything else looks good to me, I could just merge your PR at that
time. Then we can still