[GitHub] incubator-weex-site pull request #97: Update index.md for cn

2018-03-12 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex-site/pull/97 Update index.md for cn You can merge this pull request into a Git repository by running: $ git pull https://github.com/cxfeng1/incubator-weex-site patch-2 Alternatively you can

[GitHub] incubator-weex-site pull request #96: Update index.md in references

2018-03-12 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex-site/pull/96 Update index.md in references You can merge this pull request into a Git repository by running: $ git pull https://github.com/cxfeng1/incubator-weex-site patch-1 Alternatively

[GitHub] incubator-weex-site issue #76: fix a wrong url reference path in guide index...

2018-02-26 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex-site/pull/76 @Hanks10100 ---

[GitHub] incubator-weex-site pull request #19: [WEEX-86][doc] update the docs of the ...

2018-01-17 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/19#discussion_r162045127 --- Diff: source/references/components/scroller.md --- @@ -1,40 +1,39 @@ --- title: type: references -group: Build-in

[GitHub] incubator-weex-site pull request #19: [WEEX-86][doc] update the docs of the ...

2018-01-17 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/19#discussion_r162046482 --- Diff: source/references/modules/navigator.md --- @@ -1,17 +1,16 @@ --- title: navigator type: references -group: Build-in

[GitHub] incubator-weex-site pull request #19: [WEEX-86][doc] update the docs of the ...

2018-01-17 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/19#discussion_r162045750 --- Diff: source/references/components/scroller.md --- @@ -153,4 +153,4 @@ For example, a vertical list nested in a vertical list or scroller is

[GitHub] incubator-weex-site pull request #19: [WEEX-86][doc] update the docs of the ...

2018-01-17 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/19#discussion_r162046157 --- Diff: source/references/modules/navigator.md --- @@ -1,17 +1,16 @@ --- title: navigator type: references -group: Build-in

[GitHub] incubator-weex-site pull request #19: [WEEX-86][doc] update the docs of the ...

2018-01-17 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/19#discussion_r162045477 --- Diff: source/references/components/scroller.md --- @@ -1,40 +1,39 @@ --- title: type: references -group: Build-in

[GitHub] incubator-weex-site pull request #19: [WEEX-86][doc] update the docs of the ...

2018-01-17 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/19#discussion_r162044006 --- Diff: source/references/components/scroller.md --- @@ -1,40 +1,39 @@ --- title: type: references -group: Build-in

[GitHub] incubator-weex-site pull request #19: [WEEX-86][doc] update the docs of the ...

2018-01-17 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/19#discussion_r162045241 --- Diff: source/references/components/scroller.md --- @@ -1,40 +1,39 @@ --- title: type: references -group: Build-in

[GitHub] incubator-weex-site pull request #15: * [doc] update the document of extend-...

2018-01-17 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/15#discussion_r162039985 --- Diff: source/guide/extend-android.md --- @@ -5,70 +5,63 @@ group: Extend order: 6.3 version: 2.1 --- +# Android extend

[GitHub] incubator-weex-site pull request #15: * [doc] update the document of extend-...

2018-01-17 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/15#discussion_r162041587 --- Diff: source/guide/extend-android.md --- @@ -88,131 +81,149 @@ At the javascript side, call the module with javascript function to receive

[GitHub] incubator-weex-site pull request #15: * [doc] update the document of extend-...

2018-01-17 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/15#discussion_r162040312 --- Diff: source/guide/extend-android.md --- @@ -5,70 +5,63 @@ group: Extend order: 6.3 version: 2.1 --- +# Android extend

[GitHub] incubator-weex-site pull request #15: * [doc] update the document of extend-...

2018-01-17 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/15#discussion_r162041034 --- Diff: source/guide/extend-android.md --- @@ -5,70 +5,63 @@ group: Extend order: 6.3 version: 2.1 --- +# Android extend

[GitHub] incubator-weex-site pull request #15: * [doc] update the document of extend-...

2018-01-17 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/15#discussion_r162041187 --- Diff: source/guide/extend-android.md --- @@ -88,131 +81,149 @@ At the javascript side, call the module with javascript function to receive

[GitHub] incubator-weex-site pull request #15: * [doc] update the document of extend-...

2018-01-17 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/15#discussion_r162040271 --- Diff: source/guide/extend-android.md --- @@ -5,70 +5,63 @@ group: Extend order: 6.3 version: 2.1 --- +# Android extend

[GitHub] incubator-weex-site pull request #15: * [doc] update the document of extend-...

2018-01-17 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/15#discussion_r162040671 --- Diff: source/guide/extend-android.md --- @@ -5,70 +5,63 @@ group: Extend order: 6.3 version: 2.1 --- +# Android extend

[GitHub] incubator-weex-site pull request #15: * [doc] update the document of extend-...

2018-01-17 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/15#discussion_r162039801 --- Diff: source/guide/extend-android.md --- @@ -5,70 +5,63 @@ group: Extend order: 6.3 version: 2.1 --- +# Android extend

[GitHub] incubator-weex-site pull request #16: + [doc] Add doc for a component

2018-01-17 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/16#discussion_r162038971 --- Diff: source/cn/references/components/a.md --- @@ -6,81 +6,37 @@ order: 8.04 version: 2.1 --- -# <a> +`` 用ä

[GitHub] incubator-weex-site pull request #10: [WEEX-141][doc]Integrate With Your App...

2018-01-17 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/10#discussion_r162028021 --- Diff: source/guide/integrate-to-your-app.md --- @@ -8,102 +8,50 @@ version: 2.1 # Integrate to Your App -## Integrate to

[GitHub] incubator-weex-site pull request #10: [WEEX-141][doc]Integrate With Your App...

2018-01-17 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/10#discussion_r162027925 --- Diff: source/guide/integrate-to-your-app.md --- @@ -8,102 +8,50 @@ version: 2.1 # Integrate to Your App -## Integrate to

[GitHub] incubator-weex-site pull request #3: [WEEX-86][doc] Update weex-toolkit docu...

2018-01-07 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/3#discussion_r147129588 --- Diff: source/guide/index.md --- @@ -74,31 +74,40 @@ After doing that, you'll get a standard **Weex + Vue.js** project under the

[GitHub] incubator-weex-site pull request #10: [WEEX-141][doc]Integrate With Your App...

2017-12-18 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/10#discussion_r157477280 --- Diff: source/guide/integrate-to-your-app.md --- @@ -8,102 +8,49 @@ version: 2.1 # Integrate to Your App -## Integrate to

[GitHub] incubator-weex-site pull request #10: [WEEX-141][doc]Integrate With Your App...

2017-12-18 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/10#discussion_r157477480 --- Diff: source/guide/integrate-to-your-app.md --- @@ -8,102 +8,49 @@ version: 2.1 # Integrate to Your App -## Integrate to

[GitHub] incubator-weex-site pull request #9: [WEEX-86][doc] Update web component's d...

2017-12-18 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/9#discussion_r157476787 --- Diff: source/references/components/web.md --- @@ -6,144 +6,103 @@ order: 8.16 version: 2.1 --- -# <web>

[GitHub] incubator-weex-site pull request #9: [WEEX-86][doc] Update web component's d...

2017-12-18 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/9#discussion_r157476544 --- Diff: source/references/components/web.md --- @@ -6,144 +6,103 @@ order: 8.16 version: 2.1 --- -# <web>

[GitHub] incubator-weex-site pull request #7: [WEEX-86][doc] Update refresh component...

2017-12-18 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/7#discussion_r157440371 --- Diff: source/references/components/refresh.md --- @@ -1,222 +1,141 @@ --- -title: & +title: type: references g

[GitHub] incubator-weex-site pull request #5: [WEEX-86][doc] Update animation module'...

2017-12-18 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/5#discussion_r157439670 --- Diff: source/references/modules/animation.md --- @@ -47,62 +55,36 @@ Smooth and meaningful animation is very effective for enhancing the user

[GitHub] incubator-weex-site pull request #5: [WEEX-86][doc] Update animation module'...

2017-12-18 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/5#discussion_r157439218 --- Diff: source/references/modules/animation.md --- @@ -47,62 +55,36 @@ Smooth and meaningful animation is very effective for enhancing the user

[GitHub] incubator-weex-site pull request #2: [WEEX-86] Update documentation for cont...

2017-11-07 Thread cxfeng1
Github user cxfeng1 closed the pull request at: https://github.com/apache/incubator-weex-site/pull/2 ---

[GitHub] incubator-weex-site issue #8: [WEEX-86][doc] Adds a guide on how to create a...

2017-11-05 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex-site/pull/8 @Hanks10100 Please have a review. ---

[GitHub] incubator-weex-site issue #3: [WEEX-86][doc] Update guide and weex-toolkit d...

2017-10-26 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex-site/pull/3 Something wrong happened when I ran `weex create awesome-app`: ``` ➜ Test weex create awesome-app ? new version [0.4.7-beta2] of weexpack is detected. update now? Yes

[GitHub] incubator-weex-site pull request #4: [WEEX-86][doc] Update image component's...

2017-10-26 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/4#discussion_r147076974 --- Diff: source/cn/references/components/image.md --- @@ -6,181 +6,148 @@ order: 8.02 version: 2.1 --- -# <image>

[GitHub] incubator-weex-site pull request #4: [WEEX-86][doc] Update image component's...

2017-10-25 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex-site/pull/4#discussion_r147051068 --- Diff: source/cn/references/components/image.md --- @@ -6,181 +6,148 @@ order: 8.02 version: 2.1 --- -# <image>

[GitHub] incubator-weex-site pull request #4: [WEEX-86][doc] Update image component's...

2017-10-25 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex-site/pull/4 [WEEX-86][doc] Update image component's document. Add more examples(basic, placeholder, base64, resize, etc.) and add more details for usage notes. issue: 86 You can merge

[GitHub] incubator-weex-site pull request #2: [WEEX-86] Update documentation for cont...

2017-10-18 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex-site/pull/2 [WEEX-86] Update documentation for contribution. Separate contributing to several ways: reporting bugs, answering questions, joining in discussions, contributing documentation and

[GitHub] incubator-weex issue #271: 【iOS】 Make Weex Support DP

2017-04-21 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/271 @yuedongweng the PR is not right for your purpose. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-weex pull request #261: * [test] adjust recycler test to fit both ...

2017-04-13 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/261 * [test] adjust recycler test to fit both android and ios You can merge this pull request into a Git repository by running: $ git pull https://github.com/cxfeng1/incubator-weex 0.12

[GitHub] incubator-weex pull request #249: [ios] some bug fixes for compositing and i...

2017-04-11 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/249 [ios] some bug fixes for compositing and image component * move UIGraphicsEndImageContext() to override endDrawContext: * fix issue that image's frame can not be ch

[GitHub] incubator-weex pull request #248: + [doc] Add safety notice to extend-to-iOS...

2017-04-11 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/248 + [doc] Add safety notice to extend-to-iOS documentation. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cxfeng1/incubator-weex dev

[GitHub] incubator-weex pull request #236: + [ios] add feature compositing and border...

2017-04-09 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/236 + [ios] add feature compositing and border-x-x-radius support for image * add feature compositing for iOS to add the ability of merging several views to single * add example for

[GitHub] incubator-weex issue #235: [ios]Explicit start samples by terminal.

2017-04-09 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/235 Seems good to me, @acton393 Please have a code review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-weex pull request #206: *[ios] refactor gradient color

2017-03-31 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/206#discussion_r109192198 --- Diff: ios/sdk/WeexSDK/Sources/Utility/WXUtility.h --- @@ -357,6 +357,33 @@ CGRect WXPixelFrameResize(CGRect value) DEPRECATED_MSG_ATTRIBUTE(&quo

[GitHub] incubator-weex issue #206: *[ios] refactor gradient color

2017-03-31 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/206 @acton393 Please resolve conflicts first, @boboning Please have a review on it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-weex issue #172: * [android] allow 0 as width or height for view

2017-03-31 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/172 Maybe we should open a new thread in mailing list to discuss about layout upgrading. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-weex issue #192: add scrollable to scroller & slider

2017-03-30 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/192 Please add pull request to dev branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-weex issue #190: 【iOS】if setFrame (0, 0, width, 0), the height...

2017-03-30 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/190 please use english commit log and create another pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-weex issue #190: 【iOS】if setFrame (0, 0, width, 0), the height...

2017-03-30 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/190 please use english commit log --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-weex issue #188: *[iOS] bugfix:fix slider crash on iOS 8.x .

2017-03-29 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/188 please resolve the conflicts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-weex pull request #188: *[iOS] bugfix:fix slider crash on iOS 8.x ...

2017-03-29 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/188#discussion_r108828300 --- Diff: ios/sdk/WeexSDK/Sources/Component/WXSliderComponent.m --- @@ -284,6 +284,16 @@ - (BOOL)_isItemViewVisiable:(UIView *)itemView

[GitHub] incubator-weex issue #186: + [doc] add box-shadow doc , update textarea,scro...

2017-03-29 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/186 The android ci always fail on branch dev, can anyone fix it? @sospartan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-weex issue #186: + [doc] add box-shadow doc , update textarea,scro...

2017-03-29 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/186 English doc also needs to be updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-weex pull request #187: 0.11 dev bug fixes

2017-03-29 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/187 0.11 dev bug fixes * [android] recycler demo bugfix * [ios] fix issue that scrollable components can not scroll to top if frame.size < contentSize You can me

[GitHub] incubator-weex pull request #184: * [doc] add documentation for waterfall co...

2017-03-29 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/184 * [doc] add documentation for waterfall component You can merge this pull request into a Git repository by running: $ git pull https://github.com/cxfeng1/incubator-weex dev

[GitHub] incubator-weex pull request #181: * [doc] add notice and code example to exp...

2017-03-28 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/181 * [doc] add notice and code example to exporting sync method documentation You can merge this pull request into a Git repository by running: $ git pull https://github.com/cxfeng1

[GitHub] incubator-weex pull request #174: * [dev] fix recycler bugs and add recycler...

2017-03-27 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/174 * [dev] fix recycler bugs and add recycler tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/cxfeng1/incubator-weex 0.11-dev

[GitHub] incubator-weex pull request #149: 0.12 feature support accessibility

2017-03-27 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/149#discussion_r108164541 --- Diff: ios/sdk/WeexSDK/Sources/Layout/WXComponent+Layout.m --- @@ -205,6 +205,10 @@ - (void)_layoutDidFinish [self.ancestorScroller

[GitHub] incubator-weex pull request #149: 0.12 feature support accessibility

2017-03-27 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/149#discussion_r108122449 --- Diff: ios/sdk/WeexSDK/Sources/Layout/WXComponent+Layout.m --- @@ -205,6 +205,10 @@ - (void)_layoutDidFinish [self.ancestorScroller

[GitHub] incubator-weex pull request #149: 0.12 feature support accessibility

2017-03-27 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/149#discussion_r108122527 --- Diff: ios/sdk/WeexSDK/Sources/Model/WXComponent.m --- @@ -445,6 +448,23 @@ - (void)readyToRender - (void)updateAttributes:(NSDictionary

[GitHub] incubator-weex pull request #168: [WIP] Add recycler tests

2017-03-27 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/168 [WIP] Add recycler tests tests are verified on iOS, Android is working in progress for now. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-weex pull request #129: * [ios] optimize iconfont memory

2017-03-18 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/129#discussion_r106785579 --- Diff: ios/sdk/WeexSDK.xcodeproj/project.pbxproj --- @@ -32,7 +32,7 @@ 2AAFC1B61C48DFF70026D2FE /* WXSDKError.h in Headers

[GitHub] incubator-weex pull request #114: * [ios] reload index paths should not incl...

2017-03-16 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/114 * [ios] reload index paths should not include delete index paths,otherwise it will cause crash crash log: * Assertion failure in -[UICollectionView

[GitHub] incubator-weex issue #113: Capital error in iOS SDK

2017-03-15 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/113 @lforme Please rebase to master first, too many commits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-weex issue #100: validate接口补�

2017-03-14 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/100 @zshshr please review for Android changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-weex pull request #106: * [ios] fix issue that header at bottom no...

2017-03-14 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/106 * [ios] fix issue that header at bottom not work * fix issue that header at bottom not work * add footer support to waterfall example You can merge this pull request into a Git

[GitHub] incubator-weex pull request #103: * [ios] scrollToElement should have no eff...

2017-03-14 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/103 * [ios] scrollToElement should have no effect if the scroller itself can not scroll * demo:http://dotwe.org/vue/b1ca4e9b6caea65106b152048afd3677 You can merge this pull request

[GitHub] incubator-weex issue #80: Fix some grammatical issues on the English webpage

2017-03-09 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/80 @Jinjiang @DoranYun --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-weex issue #38: fix WXWebView weak reference with delegate when WX...

2017-03-09 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/38 Got it - - On 2017年3月9日 +0800 PM8:09, sospartan zheng , wrote: > I suggest don't merge directly next time, but notify contributor to re-send > PR to cor

[GitHub] incubator-weex issue #38: fix WXWebView weak reference with delegate when WX...

2017-03-09 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/38 @LouisLWang I have merged your pull requests to 0.11-dev, you can just close this issue --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-weex pull request #72: * [ios] Fix issue that [view setTransform:]...

2017-03-08 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/72 * [ios] Fix issue that [view setTransform:] not working after animation * all CABasicAnimaitions should be removed when animation stops, otherwise it will affect view or layer's tran

[GitHub] incubator-weex pull request #62: * [ios] Add reload interval to list to batc...

2017-03-07 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/62 * [ios] Add reload interval to list to batch move updates If cell movings are frequent(like list sorting), doing them one by one is slow , we need a mechanism to batch them. You can merge

[GitHub] incubator-weex pull request #55: * [ios] fix issue that remove header will c...

2017-03-07 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/55 * [ios] fix issue that remove header will cause removing cell. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cxfeng1/incubator-weex

[GitHub] incubator-weex pull request #53: * [ios] support loadmore event in recycler

2017-03-06 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/53 * [ios] support loadmore event in recycler * [ios] support loadmore event in recycler * [ios] remove unused exception handler You can merge this pull request into a Git repository by

[GitHub] incubator-weex pull request #43: * [ios] copy updates block to avoid crash

2017-03-06 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/43 * [ios] copy updates block to avoid crash You can merge this pull request into a Git repository by running: $ git pull https://github.com/cxfeng1/incubator-weex 0.11-dev Alternatively

[GitHub] incubator-weex pull request #35: Support waterfall and recycler

2017-03-05 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/35#discussion_r104340686 --- Diff: ios/sdk/WeexSDK/Sources/Component/WXCellComponent.m --- @@ -84,8 +95,8 @@ - (void)updateAttributes:(NSDictionary *)attributes

[GitHub] incubator-weex pull request #35: Support waterfall and recycler

2017-03-05 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/35#discussion_r104339708 --- Diff: ios/sdk/WeexSDK/Sources/Engine/WXSDKEngine.m --- @@ -72,6 +72,8 @@ + (void)_registerDefaultComponents [self registerComponent

[GitHub] incubator-weex pull request #35: Support waterfall and recycler

2017-03-05 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/35 Support waterfall and recycler * Add recycler component * support multi-column layout * [ios] support delete header in the middle You can merge this pull request into a Git