[jira] [Commented] (WEEX-75) [Vote] change weex branch flow

2017-09-27 Thread kfeagle (JIRA)
[ https://issues.apache.org/jira/browse/WEEX-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16183608#comment-16183608 ] kfeagle commented on WEEX-75: - +1 > [Vote] change weex bran

[jira] [Comment Edited] (WEEX-42) [iOS] box-shadow will overlop border-radius

2017-06-15 Thread kfeagle (JIRA)
[ https://issues.apache.org/jira/browse/WEEX-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051292#comment-16051292 ] kfeagle edited comment on WEEX-42 at 6/16/17 2:08 AM: -- I try to a

[jira] [Commented] (WEEX-42) [iOS] box-shadow will overlop border-radius

2017-06-15 Thread kfeagle (JIRA)
[ https://issues.apache.org/jira/browse/WEEX-42?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051292#comment-16051292 ] kfeagle commented on WEEX-42: - I try to add a view support boxshadow under the given view.

[GitHub] incubator-weex pull request #280: + [ios] update podfile

2017-04-21 Thread kfeagle
GitHub user kfeagle opened a pull request: https://github.com/apache/incubator-weex/pull/280 + [ios] update podfile + [ios] update podfile You can merge this pull request into a Git repository by running: $ git pull https://github.com/kfeagle/incubator-weex ios-pofile-0.12

[GitHub] incubator-weex pull request #277: + [ios] support timeline

2017-04-20 Thread kfeagle
GitHub user kfeagle opened a pull request: https://github.com/apache/incubator-weex/pull/277 + [ios] support timeline support timeline as follow: ![x](https://github.com/kfeagle/firstdemo/blob/master/devtools.png?raw=true) You can merge this pull request into a Git repository

[GitHub] incubator-weex pull request #269: + [ios] add gcanvas demo & fixbug wxdevtoo...

2017-04-17 Thread kfeagle
Github user kfeagle commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/269#discussion_r111880676 --- Diff: ios/playground/Podfile --- @@ -8,6 +8,8 @@ def common pod 'SDWebImage', '3.7.5' pod 'SocketRock

[GitHub] incubator-weex pull request #269: + [ios] add gcanvas demo & fixbug wxdevtoo...

2017-04-17 Thread kfeagle
Github user kfeagle commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/269#discussion_r111880583 --- Diff: WeexSDK.podspec --- @@ -0,0 +1,47 @@ +# coding: utf-8 +Pod::Spec.new do |s| + + s.name = "We

[GitHub] incubator-weex pull request #269: Ios demo 0.12 dev

2017-04-17 Thread kfeagle
GitHub user kfeagle opened a pull request: https://github.com/apache/incubator-weex/pull/269 Ios demo 0.12 dev + [ios] add gcanvas demo + [ios] fixbug wxdevtool crash + [ios] move pod spec to root directory You can merge this pull request into a Git repository by running

[GitHub] incubator-weex pull request #255: + [ios] fix bug picker

2017-04-12 Thread kfeagle
GitHub user kfeagle opened a pull request: https://github.com/apache/incubator-weex/pull/255 + [ios] fix bug picker * fixbug text color is not right * fixbug default seletion have no backgroundcolor You can merge this pull request into a Git repository by running: $ git

[GitHub] incubator-weex pull request #243: * [ios] bug fix box shadow

2017-04-11 Thread kfeagle
Github user kfeagle closed the pull request at: https://github.com/apache/incubator-weex/pull/243 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-weex pull request #243: * [ios] bug fix box shadow

2017-04-10 Thread kfeagle
GitHub user kfeagle opened a pull request: https://github.com/apache/incubator-weex/pull/243 * [ios] bug fix box shadow * [ios] bug fix box shadow You can merge this pull request into a Git repository by running: $ git pull https://github.com/kfeagle/incubator-weex ios-bugfix

[GitHub] incubator-weex pull request #233: + [ios] picker support custom title title ...

2017-04-09 Thread kfeagle
Github user kfeagle commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/233#discussion_r110575097 --- Diff: ios/sdk/WeexSDK/Sources/Module/WXPickerModule.m --- @@ -160,17 +201,52 @@ -(void)configPickerView [self.backgroundView

[GitHub] incubator-weex pull request #238: * [ios] change keyboard event to keybord a...

2017-04-09 Thread kfeagle
GitHub user kfeagle opened a pull request: https://github.com/apache/incubator-weex/pull/238 * [ios] change keyboard event to keybord and add animation for Navig… * [ios] change keyboard event to keybord and add animation for navigationBarHidden You can merge this pull request

[GitHub] incubator-weex pull request #237: * [ios] fix bug ci

2017-04-09 Thread kfeagle
GitHub user kfeagle opened a pull request: https://github.com/apache/incubator-weex/pull/237 * [ios] fix bug ci * [ios] fix bug ci You can merge this pull request into a Git repository by running: $ git pull https://github.com/kfeagle/incubator-weex ios-bugfix-ci-0.12-dev

[GitHub] incubator-weex pull request #233: + [ios] picker support custom title title ...

2017-04-07 Thread kfeagle
GitHub user kfeagle opened a pull request: https://github.com/apache/incubator-weex/pull/233 + [ios] picker support custom title title color background color and etc + [ios] picker support custom title titleColor cancelTitle confirmTitle cancelTitleColor

[GitHub] incubator-weex pull request #228: + [ios] add feature timer

2017-04-06 Thread kfeagle
GitHub user kfeagle opened a pull request: https://github.com/apache/incubator-weex/pull/228 + [ios] add feature timer support jsfm call timer directly , not through bridge. Because wxtimermodule execute until the jsbridge thread finish. it will delay . the minimum time

[GitHub] incubator-weex pull request #210: * [ios] the new slider component which is ...

2017-04-05 Thread kfeagle
Github user kfeagle commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/210#discussion_r109823455 --- Diff: ios/sdk/WeexSDK/Sources/Component/WXRecycleSliderComponent.m --- @@ -0,0 +1,528 @@ +/** + * Created by Weex. + * Copyright (c

[GitHub] incubator-weex pull request #207: + [ios] boxshadow shadowcolor change to co...

2017-03-31 Thread kfeagle
GitHub user kfeagle opened a pull request: https://github.com/apache/incubator-weex/pull/207 + [ios] boxshadow shadowcolor change to color + [ios] boxshadow shadowcolor change to color You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-weex pull request #197: * [ios] bug fix: customMonitorInfo only de...

2017-03-30 Thread kfeagle
GitHub user kfeagle opened a pull request: https://github.com/apache/incubator-weex/pull/197 * [ios] bug fix: customMonitorInfo only deal dictionary and string * [ios] bug fix: customMonitorInfo only deal dictionary and string You can merge this pull request into a Git repository

[GitHub] incubator-weex issue #186: + [doc] add box-shadow doc , update textarea,scro...

2017-03-29 Thread kfeagle
Github user kfeagle commented on the issue: https://github.com/apache/incubator-weex/pull/186 @cxfeng1 thanks for remind , add english doc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-weex pull request #186: + [doc] add box-shadow doc , update textar...

2017-03-29 Thread kfeagle
GitHub user kfeagle opened a pull request: https://github.com/apache/incubator-weex/pull/186 + [doc] add box-shadow doc , update textarea,scrolltoelement + [doc] add box-shadow doc , update textarea,scrolltoelement You can merge this pull request into a Git repository by running

[GitHub] incubator-weex pull request #176: + [example] update index, list add box sha...

2017-03-27 Thread kfeagle
GitHub user kfeagle opened a pull request: https://github.com/apache/incubator-weex/pull/176 + [example] update index, list add box shadow demo + [example] update index, list add box shadow demo You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-weex pull request #170: + [ios] bug fix: boxshadow crash in setsha...

2017-03-27 Thread kfeagle
GitHub user kfeagle opened a pull request: https://github.com/apache/incubator-weex/pull/170 + [ios] bug fix: boxshadow crash in setshadowcolor + [ios] bug fix: boxshadow crash in setshadowcolor You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-weex pull request #162: * [ios] bugfix : remove self in boxshadow

2017-03-27 Thread kfeagle
Github user kfeagle closed the pull request at: https://github.com/apache/incubator-weex/pull/162 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-weex pull request #162: * [ios] bugfix : remove self in boxshadow

2017-03-26 Thread kfeagle
GitHub user kfeagle opened a pull request: https://github.com/apache/incubator-weex/pull/162 * [ios] bugfix : remove self in boxshadow * [ios] bugfix : remove self in boxshadow You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-weex pull request #154: + [example] add showcase input box shadow ...

2017-03-23 Thread kfeagle
GitHub user kfeagle opened a pull request: https://github.com/apache/incubator-weex/pull/154 + [example] add showcase input box shadow chatroom + [example] add showcase input box shadow chatroom You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-weex pull request #153: + [ios] add keyboard shown event

2017-03-23 Thread kfeagle
GitHub user kfeagle opened a pull request: https://github.com/apache/incubator-weex/pull/153 + [ios] add keyboard shown event - input and textarea add number type - when keyboard show or hide will fire event You can merge this pull request into a Git repository by running

[GitHub] incubator-weex pull request #111: + [ios] textarea add maxlength ,because an...

2017-03-15 Thread kfeagle
GitHub user kfeagle opened a pull request: https://github.com/apache/incubator-weex/pull/111 + [ios] textarea add maxlength ,because android textarea has this attributes - textarea add maxlength ,because android textarea has this attributes - demo ```html

[GitHub] incubator-weex pull request #63: + [ios] fix bug box-shadow

2017-03-07 Thread kfeagle
GitHub user kfeagle opened a pull request: https://github.com/apache/incubator-weex/pull/63 + [ios] fix bug box-shadow to support the follow case ,update box-shadow http://dotwe.org/vue/bda48e3c453f1eb6f28732c5063f3bbf You can merge this pull request into a Git repository by

[GitHub] incubator-weex pull request #45: * [ios] fix refresh and loading

2017-03-06 Thread kfeagle
Github user kfeagle commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/45#discussion_r104403350 --- Diff: ios/sdk/WeexSDK/Sources/Component/WXScrollerComponent.m --- @@ -465,12 +465,15 @@ - (void)scrollViewDidScroll:(UIScrollView *)scrollView

[GitHub] incubator-weex pull request #35: Support waterfall and recycler

2017-03-05 Thread kfeagle
Github user kfeagle commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/35#discussion_r104340778 --- Diff: ios/sdk/WeexSDK/Sources/Component/WXCellComponent.m --- @@ -84,8 +95,8 @@ - (void)updateAttributes:(NSDictionary *)attributes

[GitHub] incubator-weex pull request #35: Support waterfall and recycler

2017-03-05 Thread kfeagle
Github user kfeagle commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/35#discussion_r104340578 --- Diff: ios/sdk/WeexSDK/Sources/Component/WXHeaderComponent.m --- @@ -0,0 +1,76 @@ +/** + * Created by Weex. + * Copyright (c) 2016

[GitHub] incubator-weex pull request #35: Support waterfall and recycler

2017-03-05 Thread kfeagle
Github user kfeagle commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/35#discussion_r104340618 --- Diff: ios/sdk/WeexSDK/Sources/Component/WXCellComponent.m --- @@ -97,7 +108,7 @@ - (void)_removeFromSupercomponent { [super

[GitHub] incubator-weex pull request #35: Support waterfall and recycler

2017-03-05 Thread kfeagle
Github user kfeagle commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/35#discussion_r104340597 --- Diff: ios/sdk/WeexSDK/Sources/Component/WXHeaderComponent.m --- @@ -0,0 +1,76 @@ +/** + * Created by Weex. + * Copyright (c) 2016

[GitHub] incubator-weex pull request #35: Support waterfall and recycler

2017-03-05 Thread kfeagle
Github user kfeagle commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/35#discussion_r104340583 --- Diff: ios/sdk/WeexSDK/Sources/Component/WXHeaderComponent.m --- @@ -0,0 +1,76 @@ +/** + * Created by Weex. + * Copyright (c) 2016

[GitHub] incubator-weex pull request #35: Support waterfall and recycler

2017-03-05 Thread kfeagle
Github user kfeagle commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/35#discussion_r104340552 --- Diff: ios/sdk/WeexSDK/Sources/Component/WXCellComponent.m --- @@ -107,8 +118,10 @@ - (void)removeFromSuperview - (void

[GitHub] incubator-weex pull request #35: Support waterfall and recycler

2017-03-05 Thread kfeagle
Github user kfeagle commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/35#discussion_r104340454 --- Diff: ios/sdk/WeexSDK/Sources/Component/WXCellComponent.m --- @@ -84,8 +95,8 @@ - (void)updateAttributes:(NSDictionary *)attributes

[GitHub] incubator-weex pull request #35: Support waterfall and recycler

2017-03-05 Thread kfeagle
Github user kfeagle commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/35#discussion_r104339593 --- Diff: ios/sdk/WeexSDK/Sources/Engine/WXSDKEngine.m --- @@ -72,6 +72,8 @@ + (void)_registerDefaultComponents [self registerComponent

[GitHub] incubator-weex pull request #32: Ios bugfix textarea 0.11 dev

2017-03-04 Thread kfeagle
Github user kfeagle commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/32#discussion_r104287286 --- Diff: ios/sdk/WeexSDK/Sources/Component/WXEditComponent.m --- @@ -342,6 +354,13 @@ - (void)updateAttributes:(NSDictionary *)attributes

[GitHub] incubator-weex pull request #32: Ios bugfix textarea 0.11 dev

2017-03-04 Thread kfeagle
Github user kfeagle commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/32#discussion_r104287275 --- Diff: ios/sdk/WeexSDK/Sources/Component/WXEditComponent.m --- @@ -264,6 +272,10 @@ -(void)setFont:(UIFont *)font { } +-(void

[GitHub] incubator-weex pull request #32: Ios bugfix textarea 0.11 dev

2017-03-03 Thread kfeagle
GitHub user kfeagle opened a pull request: https://github.com/apache/incubator-weex/pull/32 Ios bugfix textarea 0.11 dev fixbug: when text overflow ,text will show You can merge this pull request into a Git repository by running: $ git pull https://github.com/kfeagle

[GitHub] incubator-weex pull request #27: + [ios] fix compile bug about wxeditcompone...

2017-03-02 Thread kfeagle
GitHub user kfeagle opened a pull request: https://github.com/apache/incubator-weex/pull/27 + [ios] fix compile bug about wxeditcomponent fix compile bug about wxeditcomponent You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-weex pull request #12: + [ios] because rax transform number to nat...

2017-03-01 Thread kfeagle
GitHub user kfeagle opened a pull request: https://github.com/apache/incubator-weex/pull/12 + [ios] because rax transform number to native,the text weight will lose effect because rax transform number to native,the text weight will lose effect when textweight is number. change

[GitHub] incubator-weex pull request #11: + [ios] fix websocket module crash when rea...

2017-03-01 Thread kfeagle
GitHub user kfeagle opened a pull request: https://github.com/apache/incubator-weex/pull/11 + [ios] fix websocket module crash when reason is nil in specific environment - websocket module crash when reason is nil in specific environment - update websocket demo - loadmore