Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/234#discussion_r110518695
--- Diff:
android/sdk/src/main/java/com/taobao/weex/appfram/pickers/WXPickersModule.java
---
@@ -361,6 +402,98 @@ public void onClick
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/191#discussion_r110369848
--- Diff: android/sdk/src/main/java/com/taobao/weex/WXSDKManager.java ---
@@ -218,7 +218,11 @@ public static WXSDKManager getInstance
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/217#discussion_r110099218
--- Diff:
android/sdk/src/main/java/com/taobao/weex/ui/view/gesture/WXGesture.java ---
@@ -309,12 +320,14 @@ public boolean onTouch(View v
GitHub user sospartan opened a pull request:
https://github.com/apache/incubator-weex/pull/217
[android] disable click event when gesture already consume touch event
Disable click event when gesture is consumed same serial touch-event.
You can merge this pull request into a Git
id for one reason or the other, and the
>> > >> original creator is "missing" or don't want to remove it, how should
>> we
>> > get
>> > >> it taken away?
>> > >>
>> > >>
>> > >> Thanks
>> > >> --
>> > >> Niclas Hedhman, Software Developer
>> > >> http://polygene.apache.org - New Energy for Java
>> >
>>
>>
>>
>> --
>> Niclas Hedhman, Software Developer
>> http://polygene.apache.org - New Energy for Java
>>
>>
>>
>>
>> --
>> sospartan
>> Phone:13588488290
>> HangZhou
>>
>
--
sospartan
Phone:13588488290
HangZhou
Github user sospartan commented on the issue:
https://github.com/apache/incubator-weex/pull/172
Agreed. Let's discuss yoga upgrading in dev@
On Fri, Mar 31, 2017 at 4:38 PM, éå°é£ <notificati...@github.com> wrote:
> Maybe we should open a new thread i
-dev' branch, trigger mail
notification and Travis-CI build when we push something to 'xx-dev'.
I've try to told to them. But it seems not working.
--
sospartan
https://weex-project.io
It has been fixed. Pls rebase your PR brach.
On Fri, Mar 31, 2017 at 11:13 AM, sospartan <sospar...@apache.org> wrote:
> The CI problem is located, https://github.com/
> apache/incubator-weex/commit/e00277acf77e061d8af769051e87a295a56518ef
> Some method depended by JUnit test
The CI problem is located,
https://github.com/apache/incubator-weex/commit/e00277acf77e061d8af769051e87a295a56518ef
Some method depended by JUnit testcase is removed. I've tell the author to
fix that.
On Fri, Mar 31, 2017 at 10:39 AM, Adam Feng <cxfe...@gmail.com> wrote:
> @
Hi,
I've called a vote for invite TianYi Ma as new weex committer.
It's been more than 72 hours.
The result :
> +1 votes: 3 binding
+0 votes: 0 binding
-1 votes: 0 binding
Thanks to Jinjiang Zhao, He Sai and Adam Feng for this votes.
--
sospartan
https://weex-project.io
GitHub user sospartan opened a pull request:
https://github.com/apache/incubator-weex/pull/179
Update README.md
Fix markdown.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sospartan/incubator-weex patch-1
Alternatively you can
Github user sospartan commented on the issue:
https://github.com/apache/incubator-weex/pull/149
update case: http://dotwe.org/weex/5b56a108a7748a56d58d1a715c08d4ab
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
-- Forwarded message --
From: sospartan <sospar...@apache.org>
Date: Thu, Mar 23, 2017 at 9:28 AM
Subject: [RESULT][VOTE]Invite Yuan Shen as weex committer
To: priv...@weex.incubator.apache.org
HI,
It has been more than 72 hours since the request and vote is now closed
Github user sospartan commented on the issue:
https://github.com/apache/incubator-weex/pull/141
We will merge 0.11-dev to master when v0.11 released. So this PR will not
proceed currently. Thank you.
---
If your project is set up for it, you can reply to this email and have your
Github user sospartan commented on the issue:
https://github.com/apache/incubator-weex/pull/124
@YorkShen pls mention 'break change' in your commit log like @weex-bot said.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/104#discussion_r106101327
--- Diff: android/sdk/src/main/java/com/taobao/weex/WXSDKManager.java ---
@@ -196,6 +196,16 @@ private WXSDKManager() {
mBridgeManager
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/104#discussion_r106100623
--- Diff: android/sdk/src/main/java/com/taobao/weex/dom/WXDomStatement.java
---
@@ -256,9 +255,10 @@
* and {@link WXDomManager
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/104#discussion_r106099913
--- Diff: android/sdk/src/main/java/com/taobao/weex/dom/RenderTask.java ---
@@ -0,0 +1,227
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/104#discussion_r106099709
--- Diff: android/sdk/src/main/java/com/taobao/weex/dom/action/Actions.java
---
@@ -0,0 +1,314
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/97#discussion_r105813237
--- Diff:
android/sdk/src/main/java/com/taobao/weex/ui/component/WXEmbed.java ---
@@ -327,9 +331,7 @@ public void onCreated(NestedContainer comp
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/97#discussion_r105626238
--- Diff:
android/sdk/src/main/java/com/taobao/weex/ui/component/WXEmbed.java ---
@@ -327,9 +331,7 @@ public void onCreated(NestedContainer comp
Github user sospartan commented on the issue:
https://github.com/apache/incubator-weex/pull/80
ðð¼
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user sospartan commented on the issue:
https://github.com/apache/incubator-weex/pull/38
I suggest don't merge directly next time, but notify contributor to re-send
PR to correct branch.
éå°é£ <notificati...@github.com>äº2017å¹´3æ9æ¥
å¨åä¸å6:58å
GitHub user sospartan opened a pull request:
https://github.com/apache/incubator-weex/pull/78
Use danger to find potential break change
Danger script will find any modification match pattern
`/^-\s*?public\s+[\s\S]+$/ `, java file only.
You can merge this pull request into a Git
GitHub user sospartan opened a pull request:
https://github.com/apache/incubator-weex/pull/69
[android] fix ConcurrentModificationException in registeration.
Fix fail process when re-register component/module/service, when possible
cause ConcurrentModificationException
Github user sospartan commented on the issue:
https://github.com/apache/incubator-weex/pull/60
Do not send to master, use `dev` instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/65#discussion_r104835372
--- Diff:
android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java ---
@@ -202,7 +202,7 @@
/** package **/ T mHost
Github user sospartan commented on the issue:
https://github.com/apache/incubator-weex/pull/20
@168668660 what's going on?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user sospartan commented on the issue:
https://github.com/apache/incubator-weex/pull/46
@MythChen ä¸è¦æ交PRå°masterï¼è¯·éæ°æ交å°devåæ¯ï¼è°¢è°¢ã
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user sospartan closed the pull request at:
https://github.com/apache/incubator-weex/pull/47
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user sospartan opened a pull request:
https://github.com/apache/incubator-weex/pull/48
Fix scroller loadmoreoffset
Same as #8
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sospartan/incubator-weex
0.11-dev-fix-scroller
GitHub user sospartan opened a pull request:
https://github.com/apache/incubator-weex/pull/47
0.11 dev fix scroller loadmoreoffset
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sospartan/incubator-weex
0.11-dev-fix
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/38#discussion_r104574263
--- Diff: ios/sdk/WeexSDK/Sources/Component/WXWebComponent.m ---
@@ -23,7 +23,7 @@ @implementation WXWebView
- (void)dealloc
GitHub user sospartan opened a pull request:
https://github.com/apache/incubator-weex/pull/40
* [android] fix ConcurrentModificationException in list sticky map
```
java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextEntry(HashMap.java:806
GitHub user sospartan opened a pull request:
https://github.com/apache/incubator-weex/pull/39
[android]fix list concurrent exception
```
java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextEntry(HashMap.java:806)
at java.util.HashMap
Github user sospartan commented on the issue:
https://github.com/apache/incubator-weex/pull/30
Ignore ci fail by danger.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user sospartan opened a pull request:
https://github.com/apache/incubator-weex/pull/37
* [android] use a dom for destroy , avoid NPE after component destroyed.
Use a placeholder object for component's dom after destory.
You can merge this pull request into a Git repository
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/35#discussion_r104339043
--- Diff: android/sdk/src/main/java/com/taobao/weex/dom/WXDomHandler.java
---
@@ -290,6 +291,7 @@ public boolean handleMessage(Message msg
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/35#discussion_r104339883
--- Diff:
android/sdk/src/main/java/com/taobao/weex/ui/view/listview/adapter/ListBaseViewHolder.java
---
@@ -251,6 +252,10 @@ public void bindData
Github user sospartan commented on the issue:
https://github.com/apache/incubator-weex/pull/23
This data should only be access by JS thread, u should figure that out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user sospartan commented on the issue:
https://github.com/apache/incubator-weex/pull/30
@zshshr @YorkShen æè®°å¾ææ©çå°±æ¯è¿æ ·çå§
åæ¥ææ¹æç°å¨è¿ä¸ªæ ·åç
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/4#discussion_r104080119
--- Diff: android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java ---
@@ -490,7 +490,7 @@ public void render(String template, Map<String, Obj
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/4#discussion_r104080132
--- Diff: android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java ---
@@ -467,7 +467,7 @@ public void render(String template, Map<String, Obj
101 - 143 of 143 matches
Mail list logo
