[GitHub] incubator-weex pull request #35: Support waterfall and recycler

2017-03-05 Thread sospartan
Github user sospartan commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/35#discussion_r104339043 --- Diff: android/sdk/src/main/java/com/taobao/weex/dom/WXDomHandler.java --- @@ -290,6 +291,7 @@ public boolean handleMessage(Message msg) {

[GitHub] incubator-weex pull request #35: Support waterfall and recycler

2017-03-05 Thread sospartan
Github user sospartan commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/35#discussion_r104339883 --- Diff: android/sdk/src/main/java/com/taobao/weex/ui/view/listview/adapter/ListBaseViewHolder.java --- @@ -251,6 +252,10 @@ public void

[GitHub] incubator-weex pull request #35: Support waterfall and recycler

2017-03-05 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/35#discussion_r104340686 --- Diff: ios/sdk/WeexSDK/Sources/Component/WXCellComponent.m --- @@ -84,8 +95,8 @@ - (void)updateAttributes:(NSDictionary *)attributes -

[GitHub] incubator-weex pull request #35: Support waterfall and recycler

2017-03-05 Thread kfeagle
Github user kfeagle commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/35#discussion_r104340454 --- Diff: ios/sdk/WeexSDK/Sources/Component/WXCellComponent.m --- @@ -84,8 +95,8 @@ - (void)updateAttributes:(NSDictionary *)attributes -

[GitHub] incubator-weex pull request #35: Support waterfall and recycler

2017-03-05 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/35 Support waterfall and recycler * Add recycler component * support multi-column layout * [ios] support delete header in the middle You can merge this pull request into a Git