Re: How to determine if a Resource truly is static or cacheable?

2007-11-07 Thread Johan Compagner
If a sharedresourcetarget is created for a ResourceReference then the bind() is called on the ResourceReference so the Resource is created this has to be done because else the url can't be completely constructed. But a Resource itself is just a simple constainer of data how the byte[] can be

Re: [VOTE] Release Wicket 1.3.0 release candidate 1

2007-11-07 Thread Frank Bille
I cancel this vote, because of bugs found. I will restart it tonight when I have created a new release. Thank you all for participating. Frank On Nov 4, 2007 2:43 PM, Frank Bille [EMAIL PROTECTED] wrote: Hi all, I have uploaded the artifacts to my p.a.o account. This is what I have

Re: [VOTE] Release Wicket 1.3.0 release candidate 1

2007-11-07 Thread Frank Bille
Well, I could do it from head again and just restart it totally. Would it then be fair to say that all issues said to be fixed for rc2 should set to fixed for rc1? I'll do it tonight around 7pm GMT+2 Frank On Nov 6, 2007 12:13 AM, Johan Compagner [EMAIL PROTECTED] wrote: ok so what are we

Re: [VOTE] Release Wicket 1.3.0 release candidate 1

2007-11-07 Thread Al Maw
Frank Bille wrote: No problem. When I release it will be tested. Both the compile, unit test and manual testing. And then we will convince Martijn to also test it on his OSX. when I call for a vote again. FWIW, the branch now has 100% passing tests on my OS X box. Regards, Al

Re: [VOTE] Release Wicket 1.3.0 release candidate 1

2007-11-07 Thread Johan Compagner
the problem is that i just checked out wicket part and not the complete tree and then uses svn merge revision x to y. It seems to work fine but as i couldn't really test it (didn't compile/build because i couldn't generate the right project and classpath files) johan On 11/7/07, Frank Bille

Re: [VOTE] Release Wicket 1.3.0 release candidate 1

2007-11-07 Thread Johan Compagner
i applied just the unit test patch to that rc1 tag. Can you test it? johan On 11/7/07, Frank Bille [EMAIL PROTECTED] wrote: That would be much easier for me, if you do that. Then I only have to update my local checkout of the RC1 and run the release again. Let me know what you do :-)

Re: [VOTE] Release Wicket 1.3.0 release candidate 1

2007-11-07 Thread Frank Bille
On Nov 7, 2007 3:30 PM, Johan Compagner [EMAIL PROTECTED] wrote: i applied just the unit test patch to that rc1 tag. Can you test it? I will test it when I build the release tonight at around 7PM GM+2. But I expect it to work if it's the same as you did on trunk :-) Thank you Frank

Re: How to determine if a Resource truly is static or cacheable?

2007-11-07 Thread Johan Compagner
But if they are not targetted with a ResourceReference then they won't get that url Yes i know that the SharedResourceRequestTarget also does the lazy registering but he has to do that because urls can be out there, generated previous server start. So yes a resource doesn't have to be there yet

Re: [VOTE] Release Wicket 1.3.0 release candidate 1

2007-11-07 Thread Frank Bille
That would be much easier for me, if you do that. Then I only have to update my local checkout of the RC1 and run the release again. Let me know what you do :-) Frank On Nov 7, 2007 12:53 PM, Johan Compagner [EMAIL PROTECTED] wrote: i can try to patch the RC1 tag if that is easier. and then

Re: [VOTE] Release Wicket 1.3.0 release candidate 1 (second try)

2007-11-07 Thread Frank Bille
On Nov 7, 2007 7:18 PM, Frank Bille [EMAIL PROTECTED] wrote: * Run mvn clean install on the distribution. Installs, no test failures. * Run RAT[1] on the release and checked the output. Nothing to notice. * Tried different things in the examples, like ajax, links, images, forms, guice and

Re: [VOTE] Release Wicket 1.3.0 release candidate 1

2007-11-07 Thread Frank Bille
No problem. When I release it will be tested. Both the compile, unit test and manual testing. And then we will convince Martijn to also test it on his OSX. when I call for a vote again. Frank On Nov 7, 2007 4:02 PM, Johan Compagner [EMAIL PROTECTED] wrote: the problem is that i just checked

Re: escaping/commenting scripts in the wicket:head tag..

2007-11-07 Thread Matej Knopp
I wouldn't mind, as long as we check whether the script doesn't already include [CDATA[ section. -Matej On 11/7/07, Johan Compagner [EMAIL PROTECTED] wrote: Hi, When i do this in a panels html: html wicket:head script function test() { var x = 10; if (x 10 x 10) {}

Re: How to determine if a Resource truly is static or cacheable?

2007-11-07 Thread Ate Douma
Johan Compagner wrote: If a sharedresourcetarget is created for a ResourceReference then the bind() is called on the ResourceReference so the Resource is created this has to be done because else the url can't be completely constructed. Cool, so that covers the ResourceReference. But not all

Re: [VOTE] Release Wicket 1.3.0 release candidate 1 (second try)

2007-11-07 Thread Al Maw
Frank Bille wrote: [x] Release Apache Wicket 1.3.0-rc1 Al