Re: default build profile

2008-04-12 Thread Martijn Dashorst
fixed On 4/11/08, Maurice Marrink [EMAIL PROTECTED] wrote: fine by me. Maurice On Fri, Apr 11, 2008 at 7:51 PM, Igor Vaynberg [EMAIL PROTECTED] wrote: well, it is convinient to have the sources deployed every time i mvn install wicket, because i have projects in my eclipse

Re: Id on Components

2008-04-12 Thread Korbinian Bachl - privat
Thanks for clear answer; In case i I add a feature request: would it even be possible to change the Id at a later time? I catch me regularly to add Components like Links, Panels etc. to a ListComponent and have them rendered later on to different Markups in different ListViews - and that

Re: Id on Components

2008-04-12 Thread Johan Compagner
Configuring the prefix wicket is something on my todo for 1.5 On 4/12/08, Korbinian Bachl - privat [EMAIL PROTECTED] wrote: Thanks for clear answer; In case i I add a feature request: would it even be possible to change the Id at a later time? I catch me regularly to add Components like

Re: default build profile

2008-04-12 Thread Martijn Dashorst
Still uses the javadoc Martijn On 4/12/08, Johan Compagner [EMAIL PROTECTED] wrote: What does bambo build now? On 4/12/08, Martijn Dashorst [EMAIL PROTECTED] wrote: fixed On 4/11/08, Maurice Marrink [EMAIL PROTECTED] wrote: fine by me. Maurice On Fri,

when do we release 1.4m1?

2008-04-12 Thread Martijn Dashorst
See subject Martijn -- Buy Wicket in Action: http://manning.com/dashorst Apache Wicket 1.3.2 is released Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.2

Vararg all the add(xxx) methods or not?

2008-04-12 Thread Johan Compagner
I ask the same question on the meeting and there they pretty much all said why not.. So add(Component... child) add(IBehavior... behavior) add(IValidator... validator) Johan

Re: Id on Components

2008-04-12 Thread Korbinian Bachl - privat
great News! Thx, Korbinian Johan Compagner schrieb: Configuring the prefix wicket is something on my todo for 1.5 On 4/12/08, Korbinian Bachl - privat [EMAIL PROTECTED] wrote: Thanks for clear answer; In case i I add a feature request: would it even be possible to change the Id at a later

Re: when do we release 1.4m1?

2008-04-12 Thread Johan Compagner
I would say in about 1.5 week. That should be then more then enough to java5 most sources. On 4/12/08, Martijn Dashorst [EMAIL PROTECTED] wrote: See subject Martijn -- Buy Wicket in Action: http://manning.com/dashorst Apache Wicket 1.3.2 is released Get it now:

Re: Id on Components

2008-04-12 Thread Korbinian Bachl - privat
Hi Martijn, ok, if it so wrong then how to better solve this situation: Goal: Generic Suckerfish drop Down with Multiple levels, usable for Bookmarkable,Page + AjaxLinks etc.; My Solution: 1 Panel holding outer Markup, inheriting a TreePanel; Links are injected using a ListLinkListItem;

Re: when do we release 1.4m1?

2008-04-12 Thread Mark Derricutt
So soon? wow :) On Sat, Apr 12, 2008 at 8:59 PM, Martijn Dashorst [EMAIL PROTECTED] wrote: See subject Martijn -- Buy Wicket in Action: http://manning.com/dashorst Apache Wicket 1.3.2 is released Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.2 -- It is easier to

Re: Id on Components

2008-04-12 Thread Juergen Donnerstag
changing the prefix is possible already. There are some test cases which do that. The only thing that needs to be done is consistency since there are some components/behaviors/whatever which use hardcoded wicket. Juergen On Sat, Apr 12, 2008 at 10:56 AM, Johan Compagner [EMAIL PROTECTED] wrote:

Re: when do we release 1.4m1?

2008-04-12 Thread Juergen Donnerstag
what about the 4500 generics related warnings in the core project alone. Will they be fixed in 1.5 weeks or do we plan to release with all these warnings? Juergen On Sat, Apr 12, 2008 at 11:10 AM, Johan Compagner [EMAIL PROTECTED] wrote: I would say in about 1.5 week. That should be then more

Re: when do we release 1.4m1?

2008-04-12 Thread Johan Compagner
a lot of warnings are internal the outside world should be as complete as possible But it doesn't have to be finished its a milestone not a release On Sat, Apr 12, 2008 at 11:40 AM, Juergen Donnerstag [EMAIL PROTECTED] wrote: what about the 4500 generics related warnings in the core project

Re: Vararg all the add(xxx) methods or not?

2008-04-12 Thread Frank Bille
Can't see why not Frank On Sat, Apr 12, 2008 at 11:14 AM, Johan Compagner [EMAIL PROTECTED] wrote: I ask the same question on the meeting and there they pretty much all said why not.. So add(Component... child) add(IBehavior... behavior) add(IValidator... validator) Johan

Re: Vararg all the add(xxx) methods or not?

2008-04-12 Thread Martijn Dashorst
It doesn't break API, just binary compatibility. Should just be a recompile then... I'm not sure if it will be used much, but it doesn't add bloat and doesn't create wrong impressions. For those that do like to work this way it adds the feature without bothering those that don't. +1 Martijn On

Re: Id on Components

2008-04-12 Thread Korbinian Bachl - privat
Hi Matej, sorry for this noobish question, but could you please give me an example of your factories idea? Best, Korbinian Matej Knopp schrieb: On Sat, Apr 12, 2008 at 10:24 AM, Korbinian Bachl - privat [EMAIL PROTECTED] wrote: Thanks for clear answer; In case i I add a feature request:

Re: Vararg all the add(xxx) methods or not?

2008-04-12 Thread Tim O'Brien
Would also make sense to make MarkupContainer#addOrReplace(Component... child) Tim On Apr 12, 2008, at 4:14 AM, Johan Compagner wrote: I ask the same question on the meeting and there they pretty much all said why not.. So add(Component... child) add(IBehavior... behavior)

Re: Id on Components

2008-04-12 Thread Juergen Donnerstag
search for wcn: in src/test/**.html This is how you can do it: html xmlns:wcn=http://wicket.apache.org;. Most of the markup related code should be able to handle; but as I said, most likely not there are some problems. It is not really tested end to end. Juergen On Sat, Apr 12, 2008 at 11:58

Re: when do we release 1.4m1?

2008-04-12 Thread Martijn Dashorst
It was my understanding that we should only do the IModel generification and make this a really quick release. Anything that delays that release should wait until 1.5 IMO. This includes updating all of core to java 5. Martijn On 4/12/08, Johan Compagner [EMAIL PROTECTED] wrote: a lot of

Re: [vote] update servlet-api dependency to 2.5

2008-04-12 Thread Juergen Donnerstag
[X] servletapi 2.5 Juergen

Re: [vote] update servlet-api dependency to 2.5

2008-04-12 Thread Paolo Di Tommaso
[X] servletapi 2.4 ftw! Note: first version of tomcat having Java 5 as prerequisite is Tomcat 5.5 that implements Servlet API 2.4 Regards. // Paolo On Sat, Apr 12, 2008 at 3:28 PM, Martijn Dashorst [EMAIL PROTECTED] wrote: This is a vote to update our servlet API dependency to 2.5 (since

Re: [vote] update servlet-api dependency to 2.5

2008-04-12 Thread Martijn Dashorst
A new method getContextPath() was added to ServletContext. Formerly context path information was only available in the request object, following the logic that the same context object might be bound to multiple paths so you'd only know the path at request time. However, no known servers have

Re: [vote] update servlet-api dependency to 2.5

2008-04-12 Thread Maurice Marrink
[x] servlet api 2.5 But if there are compelling reasons to use 2.4 or even stick to 2.3 that is fine too. Maurice On Sat, Apr 12, 2008 at 4:06 PM, Martijn Dashorst [EMAIL PROTECTED] wrote: A new method getContextPath() was added to ServletContext. Formerly context path information was only

Re: when do we release 1.4m1?

2008-04-12 Thread Frank Bille
What about next weekend? Frank On Sat, Apr 12, 2008 at 10:59 AM, Martijn Dashorst [EMAIL PROTECTED] wrote: See subject Martijn -- Buy Wicket in Action: http://manning.com/dashorst Apache Wicket 1.3.2 is released Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.2

Re: Fisheye for Wicket and Wicket Stuff

2008-04-12 Thread Jeremy Thomerson
Are these linked to anywhere on the http://wicket.apache.org site? I am away from my computer right now, and wanted to look at some Wicket code that I was thinking about earlier, so I pulled up the site to go to the fisheye view of the source - to no avail - I couldn't find the links. Jeremy

Re: Vararg all the add(xxx) methods or not?

2008-04-12 Thread Ryan Gravener
+1 nb On Sat, Apr 12, 2008 at 5:57 AM, Martijn Dashorst [EMAIL PROTECTED] wrote: It doesn't break API, just binary compatibility. Should just be a recompile then... I'm not sure if it will be used much, but it doesn't add bloat and doesn't create wrong impressions. For those that do like

Re: Vararg all the add(xxx) methods or not?

2008-04-12 Thread Igor Vaynberg
then can we get rid of add(Component), add(IBehavior), etc ? -igor On Sat, Apr 12, 2008 at 2:14 AM, Johan Compagner [EMAIL PROTECTED] wrote: I ask the same question on the meeting and there they pretty much all said why not.. So add(Component... child) add(IBehavior... behavior)

Re: Vararg all the add(xxx) methods or not?

2008-04-12 Thread Johan Compagner
yes i meant as a replacement not an addition On Sat, Apr 12, 2008 at 8:28 PM, Igor Vaynberg [EMAIL PROTECTED] wrote: then can we get rid of add(Component), add(IBehavior), etc ? -igor On Sat, Apr 12, 2008 at 2:14 AM, Johan Compagner [EMAIL PROTECTED] wrote: I ask the same question on

Re: Vararg all the add(xxx) methods or not?

2008-04-12 Thread Johan Compagner
ok i committed it Let see how this works then. On Sat, Apr 12, 2008 at 11:14 AM, Johan Compagner [EMAIL PROTECTED] wrote: I ask the same question on the meeting and there they pretty much all said why not.. So add(Component... child) add(IBehavior... behavior) add(IValidator... validator)

Re: when do we release 1.4m1?

2008-04-12 Thread Johan Compagner
we can try that but then make the release Sunday evening I like to have another full weekend to see if we got it all johan On Sat, Apr 12, 2008 at 7:28 PM, Frank Bille [EMAIL PROTECTED] wrote: What about next weekend? Frank On Sat, Apr 12, 2008 at 10:59 AM, Martijn Dashorst [EMAIL

Re: Vararg all the add(xxx) methods or not?

2008-04-12 Thread Igor Vaynberg
is check on component:935 needed? can behaviors array ever be null? add((ibehavior)null) will give you ibehavior[]{null} no? -igor On Sat, Apr 12, 2008 at 11:36 AM, Johan Compagner [EMAIL PROTECTED] wrote: ok i committed it Let see how this works then. On Sat, Apr 12, 2008 at 11:14 AM,

Re: Vararg all the add(xxx) methods or not?

2008-04-12 Thread Maurice Marrink
you could still do add((IBehavior[])null) so the null check needs to stay. Maurice On Sat, Apr 12, 2008 at 8:52 PM, Igor Vaynberg [EMAIL PROTECTED] wrote: is check on component:935 needed? can behaviors array ever be null? add((ibehavior)null) will give you ibehavior[]{null} no? -igor

Re: Vararg all the add(xxx) methods or not?

2008-04-12 Thread Johan Compagner
that would be silly code :) But i dont mind to much, i just kept the null check to be sure. On Sat, Apr 12, 2008 at 9:03 PM, Maurice Marrink [EMAIL PROTECTED] wrote: you could still do add((IBehavior[])null) so the null check needs to stay. Maurice On Sat, Apr 12, 2008 at 8:52 PM, Igor

Re: Vararg all the add(xxx) methods or not?

2008-04-12 Thread Maurice Marrink
true, unfortunately the jvm does not yet have a method to turn off silly code. When it does suddenly a whole lot of application won't run anymore ;) Maurice On Sat, Apr 12, 2008 at 9:17 PM, Johan Compagner [EMAIL PROTECTED] wrote: that would be silly code :) But i dont mind to much, i just

Re: when do we release 1.4m1?

2008-04-12 Thread Frank Bille
Sure thing. Sunday evening april 20. is our aim. Frank On Sat, Apr 12, 2008 at 8:38 PM, Johan Compagner [EMAIL PROTECTED] wrote: we can try that but then make the release Sunday evening I like to have another full weekend to see if we got it all johan On Sat, Apr 12, 2008 at 7:28 PM,

Re: [vote] update servlet-api dependency to 2.5

2008-04-12 Thread Ate Douma
[X] servletapi 2.4 ftw! Although the getContextPath() method added to servlet api 2.5 might be really nice to use, just for that reason (nice) only and not because we really need it for a critical feature implementation, is in my view not good enough. It would force tomcat 5.5 users to upgrade

Re: [vote] update servlet-api dependency to 2.5

2008-04-12 Thread Eduardo Ito
[X] servletapi 2.4 ftw! I would like to use Wicket with WebSphere! It uses Java 5 but is J2EE 1.4 compatible. (Tomcat 5.5 also uses Servlet 2.4) I think you should be a little conservative with this, you would rule out a lot of people if you change to Servlet 2.5. On Sat, Apr 12, 2008 at

Re: [vote] update servlet-api dependency to 2.5

2008-04-12 Thread James Carman
On Sat, Apr 12, 2008 at 9:28 AM, Martijn Dashorst [EMAIL PROTECTED] wrote: This is a vote to update our servlet API dependency to 2.5 (since we require Java 5, there is little use to stay with 2.3 iiuc) [ ] servletapi 2.5 ftw! [ ] servletapi 2.4 ftw! [ ] servletapi 2.3 ftw! [x]

Re: [vote] update servlet-api dependency to 2.5

2008-04-12 Thread Peter Ertl
You wouldn't believe how many developers are still bound to old or lame versions of webcontainers and struggle with their managers for an upgrade. I mandate for not upgrading the servlet api requirements unless there are really compelling reasons (nice to have is not enough). Besides: