Re: wicket trunk: Compilation failure

2009-06-22 Thread James Carman
It's bad practice to check in code that "breaks the build" regardless of where which branch (or trunk) it's checked into.  The code can be incomplete and not work correctly, but it definitely shouldn't break the build. I'm not trying to be all "holier-than-thou" or anything. I've broken our build

Re: wicket trunk: Compilation failure

2009-06-22 Thread Juergen Donnerstag
/** Disabled until we fixed the issue that WicketTestCase or WicketTester is not available in other projects. They are in src/test/java. Maven will create a compile error since in Maven the test folder is not exported, which is what we want. We don't want the test cases to be part of the Wicket d

Re: wicket trunk: Compilation failure

2009-06-22 Thread Martin Funk
yeah, but than its only half of the fun :-) mf Am 22.06.2009 um 19:43 schrieb Igor Vaynberg: if you dont like failures dont svn up off a trunk :) -igor On Mon, Jun 22, 2009 at 9:22 AM, Martin Funk wrote: Beyond that compilation failure I noticed that there are two incarnations of org.apac

Wicket Stuff commit access

2009-06-22 Thread Michael Würtinger
Hi folks! I would like to contribute to wicketstuff and therefore would like to ask you for commit access to the subversion repository. My Sourceforge username is: mwuertinger Best regards, Michael Würtinger signature.asc Description: This is a digitally signed message part.

Re: wicket trunk: Compilation failure

2009-06-22 Thread Igor Vaynberg
if you dont like failures dont svn up off a trunk :) -igor On Mon, Jun 22, 2009 at 9:22 AM, Martin Funk wrote: > Beyond that compilation failure I noticed that there are two incarnations of > org.apache.wicket.WicketTestCase on in wicket and one in wicket-extensions. > They seem so similar, that

Re: wicket trunk: Compilation failure

2009-06-22 Thread Juergen Donnerstag
I'll fix it. I added the DatePickerTest to the datetime project over the weekend. No test case at all existed for that project so far. Juergen

Re: wicket trunk: Compilation failure

2009-06-22 Thread Martin Funk
Beyond that compilation failure I noticed that there are two incarnations of org.apache.wicket.WicketTestCase on in wicket and one in wicket-extensions. They seem so similar, that I fail to see a reason for their double existence. One more I got. The tests are broken for quite a while now:

Re: wicket trunk: Compilation failure

2009-06-22 Thread Igor Vaynberg
compilation failure is in a test class, looks like someone didnt move the test case. something that would work in eclipse but not with maven. http://wicketstuff.org/teamcity/viewLog.html?buildId=4051&tab=buildResultsDiv&buildTypeId=bt2 -igor On Mon, Jun 22, 2009 at 8:32 AM, Juergen Donnerstag wr

Re: wicket trunk: Compilation failure

2009-06-22 Thread Juergen Donnerstag
I just did "maven -Dmaven.test.skip=true clean install" and it completed successfully (on 1.4 trunk from 18 hrs ago). -Juergen On Mon, Jun 22, 2009 at 1:16 PM, Martin Funk wrote: > anyone else bothered by that? > > mf >

Re: svn commit: r786424 - /wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js

2009-06-22 Thread Johan Compagner
done On Fri, Jun 19, 2009 at 17:55, Igor Vaynberg wrote: > any plans to check this into trunk? > > On Fri, Jun 19, 2009 at 2:27 AM, wrote: > > Author: jcompagner > > Date: Fri Jun 19 09:27:06 2009 > > New Revision: 786424 > > > > URL: http://svn.apache.org/viewvc?rev=786424&view=rev > > Log: > >

wicket trunk: Compilation failure

2009-06-22 Thread Martin Funk
anyone else bothered by that? mf