Re: git commit: change 'void' methods to pass-through checked argument

2012-02-10 Thread Igor Vaynberg
i dont really like this. having a set of checks at the top of the method is easier to read/parse then a bunch of checks mixed with a bunch of assignments... -igor On Fri, Feb 10, 2012 at 2:47 PM, wrote: > Updated Branches: >  refs/heads/master b0118c114 -> 57a09fbe6 > > > change 'void' methods

Re: source/commits in jira

2012-02-10 Thread Johan Compagner
That could be tricky, because not all commits are always related to an issue i think.. But if the UI gives you the option (in eclipse at least for svn) then it is easer NOT to forget :) On Fri, Feb 10, 2012 at 17:12, Igor Vaynberg wrote: > we can write a server hook to make sure the string is pr

Re: source/commits in jira

2012-02-10 Thread Martin Grigorov
On Fri, Feb 10, 2012 at 6:12 PM, Igor Vaynberg wrote: > we can write a server hook to make sure the string is present i > suppose. i am not sure if infra would like that or not... Not all commits are related to a ticket - minor tweaks, javadoc, ... > > -igor > > On Fri, Feb 10, 2012 at 8:10 AM,

Re: source/commits in jira

2012-02-10 Thread Igor Vaynberg
we can write a server hook to make sure the string is present i suppose. i am not sure if infra would like that or not... -igor On Fri, Feb 10, 2012 at 8:10 AM, Johan Compagner wrote: > can we somehow force that? Just like we did with svn that has that build in > case:xxx support (in the commit

Re: source/commits in jira

2012-02-10 Thread Johan Compagner
can we somehow force that? Just like we did with svn that has that build in case:xxx support (in the commit dialog?) But i will place WICKET-XXX then in all my commits from now on On Fri, Feb 10, 2012 at 17:08, Martin Grigorov wrote: > On Fri, Feb 10, 2012 at 6:02 PM, Johan Compagner > wrote:

Re: source/commits in jira

2012-02-10 Thread Martin Grigorov
On Fri, Feb 10, 2012 at 6:08 PM, Martin Grigorov wrote: > On Fri, Feb 10, 2012 at 6:02 PM, Johan Compagner wrote: >> thx >> so it all depends first on: >> http://studio.plugins.atlassian.com/browse/JGIT-74 >> >> but then if we do the commit, how do we say to git that this is issue XXX ? >> So tha

Re: source/commits in jira

2012-02-10 Thread Martin Grigorov
On Fri, Feb 10, 2012 at 6:02 PM, Johan Compagner wrote: > thx > so it all depends first on: > http://studio.plugins.atlassian.com/browse/JGIT-74 > > but then if we do the commit, how do we say to git that this is issue XXX ? > So that the plugin knows that that commit is for that issue? > > I gues

Re: source/commits in jira

2012-02-10 Thread Johan Compagner
thx so it all depends first on: http://studio.plugins.atlassian.com/browse/JGIT-74 but then if we do the commit, how do we say to git that this is issue XXX ? So that the plugin knows that that commit is for that issue? I guess we we need to fill in certain things on commit we should start with t

Re: source/commits in jira

2012-02-10 Thread Martin Grigorov
https://issues.apache.org/jira/browse/INFRA-4157 On Fri, Feb 10, 2012 at 5:44 PM, Jeremy Thomerson wrote: > Feel free to email infrastruct...@apache.org to bring the subject up there. > > -- > Jeremy Thomerson > http://wickettraining.com > *Need a CMS for Wicket?  Use Brix! http://brixcms.org* >

Re: source/commits in jira

2012-02-10 Thread Jeremy Thomerson
Feel free to email infrastruct...@apache.org to bring the subject up there. -- Jeremy Thomerson http://wickettraining.com *Need a CMS for Wicket? Use Brix! http://brixcms.org* On Fri, Feb 10, 2012 at 9:59 AM, Bertrand Guay-Paquet < ber...@step.polymtl.ca> wrote: > Hi, > > I asked the same que

Re: source/commits in jira

2012-02-10 Thread Bertrand Guay-Paquet
Hi, I asked the same question on dec 22 and Igor replied : infra is working on this afaik. -igor So I guess they haven't finished yet! Bertrand On 10/02/2012 9:34 AM, Johan Compagner wrote: Hi, What "broke" now that we are over to git is the nice link between jira issues and the source co

source/commits in jira

2012-02-10 Thread Johan Compagner
Hi, What "broke" now that we are over to git is the nice link between jira issues and the source code so this tab: https://issues.apache.org/jira/browse/WICKET-1654?page=com.atlassian.jirafisheyeplugin:fisheye-issuepanel#issue-tabs (or that subversion tab which ofcourse will not work anymore) i

Re: Again Inline Enclosure does not ... wicket:extend and wicket:child and workaround

2012-02-10 Thread Martin Grigorov
On Fri, Feb 10, 2012 at 10:16 AM, The Genuiini wrote: > > Hi! > > I have tested, it works okay, but now the point of view is different (and not > so handy)! It is handy for me because you wont report weird problems like the one in the mentioned ticket ;-) We are aware about the problem and at s

Re: Again Inline Enclosure does not ... wicket:extend and wicket:child and workaround

2012-02-10 Thread The Genuiini
Hi! I have tested, it works okay, but now the point of view is different (and not so handy)! T.G. > > Okay, thanks. Sounds valuable advise to test, so. its kind of "wide sense" > workaround for problem :-) > > T.G. > > >Hi, > > > >I'd recommend you to not use InlineEnclosure if it causes y