Re: [3/3] git commit: Revert WICKET-5226 CDI integration fails in Glassfish 4.0 with WELD-000070

2013-07-05 Thread Martin Grigorov
Should we update/create any Jira tickets too ? On Fri, Jul 5, 2013 at 6:01 PM, papega...@apache.org wrote: Revert WICKET-5226 CDI integration fails in Glassfish 4.0 with WELD-70 This reverts commit 4bc20743fe628341a7cce407b36fa1984b912f92. Conflicts:

Re: [3/3] git commit: Revert WICKET-5226 CDI integration fails in Glassfish 4.0 with WELD-000070

2013-07-05 Thread Cedric Gatay
I think https://issues.apache.org/jira/browse/WICKET-5264 is sufficient, may be we could add a copy/paste of our irc conv in the issue to narrow things down. __ Cedric Gatay (@Cedric_Gatay http://twitter.com/Cedric_Gatay) http://code-troopers.com | http://www.bloggure.info |

[VOTE] Release Apache Wicket 6.9.1 - fix for CDI issues

2013-07-05 Thread Martijn Dashorst
This is a vote to release Apache Wicket 6.9.1 This is a patch release for 6.9.0 because in 6.9.0 the CDI integration was broken for injecting into anonymous inner classes (see WICKET-5226). This release only contains (in addition to anything that was fixed in 6.9.0) the reversal of the

Re: [VOTE] Release Apache Wicket 6.9.1 - fix for CDI issues

2013-07-05 Thread Cedric Gatay
Hi, Nothing has been changed regarding the jQuery issue discussed yesterday ? __ Cedric Gatay (@Cedric_Gatay http://twitter.com/Cedric_Gatay) http://code-troopers.com | http://www.bloggure.info | http://cedric.gatay.fr On Fri, Jul 5, 2013 at 6:17 PM, Martijn Dashorst martijn.dasho...@gmail.com

Re: [VOTE] Release Apache Wicket 6.9.1 - fix for CDI issues

2013-07-05 Thread Cedric Gatay
Seems to work ok for me in the biggest CDI enabled app I got (tested on Glassfish 3.1.2.2). To answer my previous question, jQuery version is 1.10.1 So : [X] Yes, release Apache Wicket 6.9.1 Regards, __ Cedric Gatay (@Cedric_Gatay http://twitter.com/Cedric_Gatay) http://code-troopers.com |

Re: [VOTE] Release Apache Wicket 6.9.1 - fix for CDI issues

2013-07-05 Thread Emond Papegaaij
+1 to release One minor issue: we should upgrade the versions of the experimental modules because the versions got upgraded in 6.9.1. For example, wicket-6.x has wicket-atmosphere-0.12-SNAPSHOT and wicket-6.9.1 contains 0.12. Btw, can you add 6.9.1 to jira, so I can close the ticket as fixed in

Re: [VOTE] Release Apache Wicket 6.9.1 - fix for CDI issues

2013-07-05 Thread Igor Vaynberg
+1 to release -igor On Fri, Jul 5, 2013 at 9:17 AM, Martijn Dashorst martijn.dasho...@gmail.com wrote: This is a vote to release Apache Wicket 6.9.1 This is a patch release for 6.9.0 because in 6.9.0 the CDI integration was broken for injecting into anonymous inner classes (see WICKET-5226).