apparently eclipse formatter setup in master is incorrect. i am
working on a new queuing implementation idea and keep getting crap
like this all over the code, any ideas? after running code cleanup on
the workspace all the files are modified and i have effectively lost
my changes...
-igor
diff --
Done.
https://issues.apache.org/jira/browse/WICKET-5490
Martin Grigorov
Wicket Training and Consulting
On Fri, Dec 20, 2013 at 8:48 PM, Igor Vaynberg wrote:
> i am guessing that the id of the component would be useful for logging
> in some cases, but i think it should just be passed in as an ex
Our format defines lineSplit=100, so that lines gets wrapped correctly.
If you're using Eclipse's Save Actions, do you have "format edited
lines" selected in the configuration?
Regards
Sven
On 01/28/2014 09:52 AM, Igor Vaynberg wrote:
apparently eclipse formatter setup in master is incorrec
if the formatter config is correct i shouldnt have to just format
edited lines...
-igor
On Tue, Jan 28, 2014 at 4:30 AM, Sven Meier wrote:
> Our format defines lineSplit=100, so that lines gets wrapped correctly.
>
> If you're using Eclipse's Save Actions, do you have "format edited lines"
> sel
if the formatter config is correct i shouldnt have to just format edited
lines...
Correct.
It's just that we've coded with difference format settings / IDEs in the past
years. To be sure we'd have to run the formatter once on all files.
Sven
On 01/28/2014 05:12 PM, Igor Vaynberg wrote:
if
I think the setting "format edited lines" is not in the committed
.settings/ and that's why Igor's IDE touches code that it should not.
I am +1 to reformat all files now and have cleaner commit diffs in the
future.
But we should do this for 1.5, 6.x and 7.x. Otherwise I think Git will have
big pro
"format edited lines" are configured in org.eclipse.jdt.ui.prefs, and these
files are no longer under version control.
Sven
On 01/28/2014 05:35 PM, Martin Grigorov wrote:
I think the setting "format edited lines" is not in the committed
.settings/ and that's why Igor's IDE touches code that i
the format edited lines only applies to save actions, it will do
nothing to help me with my ctrl+shift+f twitch. i often format code as
i work on it because i just brain dump it all into a single line and
let the ide format it by pressing ctrl+shift+f. this happens multiple
times before saving.
an
On Tue, Jan 28, 2014 at 7:13 PM, Igor Vaynberg wrote:
> the format edited lines only applies to save actions, it will do
> nothing to help me with my ctrl+shift+f twitch. i often format code as
> i work on it because i just brain dump it all into a single line and
> let the ide format it by pressi
Should we strive to ease the addition of lambda expressions to Wicket by
introducing single method interfaces in various places in Wicket 7?
For a contrived example:
AbstractLink#setBody(IModel bodyModel) {}
Could be:
AbstractLink#setBody(IReadModel bodyModel) {}
So that you can do:
I have been a bit out of touch due to work taking me away from Wicket
development for a while, sorry about that.
But I really like this idea.
For one, IModel is, in hindsight, clearly a thing that does *two*
things. I could see it being changed to IReadableModel and
IWriteableModel, with IModel s
then change eclipse formatter settings to match whatever is in our
code base now?
-igor
On Tue, Jan 28, 2014 at 10:21 AM, Martin Grigorov wrote:
> On Tue, Jan 28, 2014 at 7:13 PM, Igor Vaynberg wrote:
>
>> the format edited lines only applies to save actions, it will do
>> nothing to help me wit
12 matches
Mail list logo
